Re: [PHP-DEV] [RFC] Unbundle ext/interbase

2019-03-29 Thread Dan Ackroyd
On Mon, 25 Mar 2019 at 23:04, Stanislav Malyshev wrote: > > In my opinion, deprecation warnings should be used for functionality > that the used needs to remove from the code. That's not what we're doing > here - That's a good point. Another thing that probably needs consideration is that

Re: [PHP-DEV] [RFC] Unbundle ext/interbase

2019-03-25 Thread Stanislav Malyshev
Hi! > I see the following options to go about this extension: > > 1) Add a deprecation warning as the functionality will effective cease > to exist in php-src. We don't know if this extension will be taken As an end user (in this case, PHP developer that needs to use Firebase functionality), I

Re: [PHP-DEV] [RFC] Unbundle ext/interbase

2019-03-24 Thread Lester Caine
On 24/03/2019 13:47, Dan Ackroyd wrote: It's worth noting that even after the extension is moved from core to it's own repository, most people using it on Debian or Centos/Redhat/Fedora won't notice any difference. On one hand this is correct but the reason I got stung with a move to PHP7.2

Re: [PHP-DEV] [RFC] Unbundle ext/interbase

2019-03-24 Thread Dan Ackroyd
On Sun, 24 Mar 2019 at 12:32, Rowan Collins wrote: > Presumably the PECL extension... the new home of the extension gets more > publicity. > It's worth noting that even after the extension is moved from core to it's own repository, most people using it on Debian or Centos/Redhat/Fedora won't

Re: [PHP-DEV] [RFC] Unbundle ext/interbase

2019-03-24 Thread Kalle Sommer Nielsen
Hi Peter Den søn. 24. mar. 2019 kl. 14.39 skrev Peter Kokot : > I'm all in for helping out here with both users using this and > maintainers that need to worry about if this extension is even working > ok. However, just one quick thought. The deprecation usually means > that some functionality

Re: [PHP-DEV] [RFC] Unbundle ext/interbase

2019-03-24 Thread Peter Kokot
Hello, On Fri, 22 Mar 2019 at 14:26, Kalle Sommer Nielsen wrote: > > G'day internals > > I'd like to start the discussion for the future of the ext/interbase > extension: > https://wiki.php.net/rfc/deprecate-and-remove-ext-interbase > > The rationale for pushing this extension out of the core

Re: [PHP-DEV] [RFC] Unbundle ext/interbase

2019-03-24 Thread Rowan Collins
On 24 March 2019 11:33:45 GMT+00:00, Lester Caine wrote: > problem then is that PHP7.4 >essentially becomes a nogo zone because there is no way to remove the >deprecation warnings Presumably the PECL extension, with no deprecation warnings, could be set up straight away, and builds offered for

Re: [PHP-DEV] [RFC] Unbundle ext/interbase

2019-03-24 Thread Lester Caine
On 24/03/2019 10:58, Kalle Sommer Nielsen wrote: Your objection to the deprecation and removal of ext/interbase has been noted, and will be recorded at vote time. I have no doubt the rfc will go through, my problem then is that PHP7.4 essentially becomes a nogo zone because there is no way to

Re: [PHP-DEV] [RFC] Unbundle ext/interbase

2019-03-24 Thread Kalle Sommer Nielsen
Den søn. 24. mar. 2019 kl. 10.05 skrev Lester Caine : > > On 24/03/2019 01:42, Kalle Sommer Nielsen wrote: > > Besides this, it has further magic behavior if the multiple > > connections are created with the same credentials as one in the same > > process, I'm not sure if this is fixed with

Re: [PHP-DEV] [RFC] Unbundle ext/interbase

2019-03-24 Thread Lester Caine
On 24/03/2019 01:42, Kalle Sommer Nielsen wrote: Besides this, it has further magic behavior if the multiple connections are created with the same credentials as one in the same process, I'm not sure if this is fixed with Nikita's patch. But that IS the point here ... In fact many people using

Re: [PHP-DEV] [RFC] Unbundle ext/interbase

2019-03-23 Thread Kalle Sommer Nielsen
Den søn. 24. mar. 2019 kl. 03.11 skrev Lester Caine : > > (Neely forgot to fix reply address!) > > On 24/03/2019 00:22, Kalle Sommer Nielsen wrote: > > mysql_connect('localhost', 'user', 'password'); > > mysql_select_db('test'); // The last created connection is implicitly added > > here > > This

Re: [PHP-DEV] [RFC] Unbundle ext/interbase

2019-03-23 Thread Lester Caine
(Neely forgot to fix reply address!) On 24/03/2019 00:22, Kalle Sommer Nielsen wrote: mysql_connect('localhost', 'user', 'password'); mysql_select_db('test'); // The last created connection is implicitly added here This situation never exists in Firebird or Interbase. The ONLY way to connect

Re: [PHP-DEV] [RFC] Unbundle ext/interbase

2019-03-23 Thread Kalle Sommer Nielsen
Hi Lester Den lør. 23. mar. 2019 kl. 23.41 skrev Lester Caine : > Thread safety is one area where the way the extension was structured > originally may now be wrong, but the main problem with multiple > connections is confined completely to multiple connections to a single > database. In

Re: [PHP-DEV] [RFC] Unbundle ext/interbase

2019-03-23 Thread Rowan Collins
On 23 March 2019 21:09:35 GMT+00:00, Kalle Sommer Nielsen wrote: > the extension can be taken over by anyone who >wants to from the relevant community, it just will not be distributed >by default with PHP. In fact if the extension is released on PECL, it >gives the relevant community more freedom

Re: [PHP-DEV] [RFC] Unbundle ext/interbase

2019-03-23 Thread Lester Caine
On 23/03/2019 21:09, Kalle Sommer Nielsen wrote: I updated the RFC with a section earlier to list some of the issues the extension currently has. Thread safety is one area where the way the extension was structured originally may now be wrong, but the main problem with multiple connections

Re: [PHP-DEV] [RFC] Unbundle ext/interbase

2019-03-23 Thread Kalle Sommer Nielsen
Den lør. 23. mar. 2019 kl. 22.59 skrev Lester Caine : > So is there anything else which is required to bring the extension up to > date? There is nothing above that prevents the extension doing it's job > for the vast majority of users and even the suggestion that it is > unusable due to Bug 72175

Re: [PHP-DEV] [RFC] Unbundle ext/interbase

2019-03-23 Thread Lester Caine
On 22/03/2019 13:26, Kalle Sommer Nielsen wrote: I'd like to start the discussion for the future of the ext/interbase extension: https://wiki.php.net/rfc/deprecate-and-remove-ext-interbase Currently I am seeing 6 open bugs against ext/interbase going back to 2009 ... 48447 - 2009 The oldest

Re: [PHP-DEV] [RFC] Unbundle ext/interbase

2019-03-23 Thread Dan Ackroyd
On Fri, 22 Mar 2019 at 13:26, Kalle Sommer Nielsen wrote: > G'day internals > To everyone reading this thread please note: Although people are free to discuss RFCs amongst themselves off-list, it is not appropriate behaviour to contact people discussing an RFC on this list through other

Re: [PHP-DEV] [RFC] Unbundle ext/interbase

2019-03-23 Thread Lester Caine
On 22/03/2019 16:25, Nikita Popov wrote: I've created a patch forhttps://bugs.php.net/bug.php?id=72175 (last comment), which seems to be the biggest open problem in the interbase extension. I'd appreciate it if you or someone else who uses firebird could test this. OK now got a test framework

Re: [PHP-DEV] [RFC] Unbundle ext/interbase

2019-03-22 Thread Lester Caine
On 22/03/2019 16:25, Nikita Popov wrote: I've created a patch forhttps://bugs.php.net/bug.php?id=72175 (last comment), which seems to be the biggest open problem in the interbase extension. I'd appreciate it if you or someone else who uses firebird could test this. Nikita Am I jumping the

Re: [PHP-DEV] [RFC] Unbundle ext/interbase

2019-03-22 Thread Nikita Popov
On Fri, Mar 22, 2019 at 3:10 PM Lester Caine wrote: > On 22/03/2019 13:26, Kalle Sommer Nielsen wrote: > > G'day internals > > > > I'd like to start the discussion for the future of the ext/interbase > extension: > > https://wiki.php.net/rfc/deprecate-and-remove-ext-interbase > > > > The

Re: [PHP-DEV] [RFC] Unbundle ext/interbase

2019-03-22 Thread Dan Ackroyd
On Fri, 22 Mar 2019 at 14:10, Lester Caine wrote: > > it has been impossible in recent years to get a handle > on just what needs to be done TO maintain it. Yes, figuring out what needs to be done takes more time that writing the code. Did you not know this? This is what takes up most of my

Re: [PHP-DEV] [RFC] Unbundle ext/interbase

2019-03-22 Thread Kalle Sommer Nielsen
G'day Lester Den fre. 22. mar. 2019 kl. 16.10 skrev Lester Caine : > It is not that we don't want to stand up and maintain it, it has been > impossible in recent years to get a handle on just what needs to be done > TO maintain it. The PDO extension is in a much worse state than the main >

Re: [PHP-DEV] [RFC] Unbundle ext/interbase

2019-03-22 Thread Lester Caine
On 22/03/2019 13:26, Kalle Sommer Nielsen wrote: G'day internals I'd like to start the discussion for the future of the ext/interbase extension: https://wiki.php.net/rfc/deprecate-and-remove-ext-interbase The rationale for pushing this extension out of the core is mentioned in the RFC. Unless

Re: [PHP-DEV] [RFC] Unbundle ext/interbase

2019-03-22 Thread Joe Watkins
Morning Kalle, Seems like a reasonable plan, +1 Cheers Joe On Fri, 22 Mar 2019 at 14:26, Kalle Sommer Nielsen wrote: > G'day internals > > I'd like to start the discussion for the future of the ext/interbase > extension: > https://wiki.php.net/rfc/deprecate-and-remove-ext-interbase > > The