Re: [PHP-DEV] Re: 8.1 / Exception / Property Type / Backwards compatbility

2021-08-27 Thread Ben Ramsey
Nikita Popov wrote on 8/27/21 10:40: >> If we don't want downstream users to redeclare the properties, why are >> they protected? >> > > To allow downstreams users to write $this->line = 123. > Got it. When I asked the question, I was thinking about passing it through the constructor,

Re: [PHP-DEV] Re: 8.1 / Exception / Property Type / Backwards compatbility

2021-08-27 Thread Nikita Popov
On Fri, Aug 27, 2021 at 5:35 PM Ben Ramsey wrote: > Nikita Popov wrote on 8/26/21 14:57: > > On Thu, Aug 26, 2021 at 8:34 PM Ben Ramsey wrote: > > > >> Nikita Popov wrote on 8/26/21 09:57: > >>> Right. I at least do not plan to address this issue. If you take a > >>> protected property and

Re: [PHP-DEV] Re: 8.1 / Exception / Property Type / Backwards compatbility

2021-08-27 Thread Ben Ramsey
Nikita Popov wrote on 8/26/21 14:57: > On Thu, Aug 26, 2021 at 8:34 PM Ben Ramsey wrote: > >> Nikita Popov wrote on 8/26/21 09:57: >>> Right. I at least do not plan to address this issue. If you take a >>> protected property and publicly re-export it, then any compatibility >> issues >>> are on

Re: [PHP-DEV] Re: 8.1 / Exception / Property Type / Backwards compatbility

2021-08-26 Thread Nikita Popov
On Thu, Aug 26, 2021 at 8:34 PM Ben Ramsey wrote: > Nikita Popov wrote on 8/26/21 09:57: > > Right. I at least do not plan to address this issue. If you take a > > protected property and publicly re-export it, then any compatibility > issues > > are on you. > > This does not appear to affect

Re: [PHP-DEV] Re: 8.1 / Exception / Property Type / Backwards compatbility

2021-08-26 Thread Ben Ramsey
Nikita Popov wrote on 8/26/21 09:57: > Right. I at least do not plan to address this issue. If you take a > protected property and publicly re-export it, then any compatibility issues > are on you. This does not appear to affect only cases where one is re-exporting a protected property as public.

Re: [PHP-DEV] Re: 8.1 / Exception / Property Type / Backwards compatbility

2021-08-26 Thread Nikita Popov
On Thu, Aug 26, 2021 at 4:43 PM Dan Ackroyd wrote: > On Thu, 26 Aug 2021 at 12:42, Björn Larsson via internals > wrote: > > > > Den 2021-08-10 kl. 11:55, skrev Philip Hofstetter: > > > The following valid <= PHP 8.0 code that intends to make the $line > property > > > public is a fatal error

Re: [PHP-DEV] Re: 8.1 / Exception / Property Type / Backwards compatbility

2021-08-26 Thread Ben Ramsey
Dan Ackroyd wrote on 8/26/21 09:43: > On Thu, 26 Aug 2021 at 12:42, Björn Larsson via internals > wrote: >> >> Den 2021-08-10 kl. 11:55, skrev Philip Hofstetter: >>> The following valid <= PHP 8.0 code that intends to make the $line property >>> public is a fatal error in 8.1 > >>> >>> For

Re: [PHP-DEV] Re: 8.1 / Exception / Property Type / Backwards compatbility

2021-08-26 Thread Dan Ackroyd
On Thu, 26 Aug 2021 at 12:42, Björn Larsson via internals wrote: > > Den 2021-08-10 kl. 11:55, skrev Philip Hofstetter: > > The following valid <= PHP 8.0 code that intends to make the $line property > > public is a fatal error in 8.1 > > > > For method return types, we have