Re: [PHP-DEV] Re: [RFC][DISCUSSION] Match expression v2

On Fri, Jun 5, 2020 at 3:10 PM Ilija Tovilo wrote: > > Hi internals > > > I'd like to announce the match expression v2 RFC: > > https://wiki.php.net/rfc/match_expression_v2 > > Small reminder: Two weeks have passed since I announced the match v2 > RFC with little new discussion. I'll leave it

[PHP-DEV] [VOTE] Attribute Amendments

Hello internals, I have opened voting for four different amendments to the Attributes RFC https://wiki.php.net/rfc/attribute_amendments The voting period ends at 2020-06-22 8:00 UTC. greetings Benjamin

Re: [PHP-DEV] [VOTE] Attribute Amendments

Hey Benjamin, On Mon, Jun 8, 2020 at 10:13 AM Benjamin Eberlei wrote: > Hello internals, > > I have opened voting for four different amendments to the Attributes RFC > > https://wiki.php.net/rfc/attribute_amendments > > The voting period ends at 2020-06-22 8:00 UTC. > > greetings > Benjamin >

Re: [PHP-DEV] New functions `hash_serialize` and `hash_unserialize`?

On Mon, 2020-06-08 at 09:01 -0400, Eddie Kohler wrote: > I'm writing to gauge interest in two new functions to the PHP `hash` > extension, `hash_serialize` and `hash_unserialize`. These functions > would serialize and unserialize the internals of a HashContext > objectallowing a partially-computed

Re: [PHP-DEV] [VOTE] Attribute Amendments

On Mon, Jun 8, 2020 at 11:11 AM Lester Caine wrote: > On 08/06/2020 09:44, Marco Pivetta wrote: > > I was mostly conflicted around the "allow grouped attributes" bit, but > > James Titcumb (who currently cannot write to this list due to bounced > > emails) convinced me that it is a good

Re: [PHP-DEV] Session default settings (use_strict_mode)

Enabling same-site cookies by default is a little risky now, because current browsers don't always set them properly. https://bugs.chromium.org/p/chromium/issues/detail?id=961617 On Sun, Jun 7, 2020 at 6:42 PM Claude Pache wrote: > > > > Le 7 juin 2020 à 22:15, AllenJB a écrit : > > > > Are

Re: [PHP-DEV] [RFC] [Discussion] Remove inappropriate inheritance signature checks on private methods

On Wed, May 27, 2020 at 12:07 AM Pedro Magalhães wrote: > On Tue, May 26, 2020 at 3:46 PM Marco Pivetta wrote: > >> Considering that, as far as I know, only the constructor remains >> "special". >> > > Leaving the special case only for constructors instead of all magic > methods sounds better

Re: [PHP-DEV] [RFC] Shorter attribute syntax

On Sun, Jun 7, 2020, at 11:36 PM, Theodore Brown wrote: > > Bracket-based syntaxes, particularly with grouping, are more clearly > > separated from the main code, particularly when used inline. For instance: > > > > `$f = @@Something @@AnotherThing function(@@Special @@ReallyInt int $var) > >

Re: [PHP-DEV] [RFC] Named arguments

On Fri, Jun 5, 2020 at 3:40 PM Nikita Popov wrote: > On Fri, Jun 5, 2020 at 12:45 PM Christian Schneider > wrote: > >> Am 05.05.2020 um 15:51 schrieb Nikita Popov : >> > \I've now updated the old proposal on this topic, and moved it back >> under >> > discussion:

Re: [PHP-DEV] [VOTE] Attribute Amendments

On 08/06/2020 09:44, Marco Pivetta wrote: I was mostly conflicted around the "allow grouped attributes" bit, but James Titcumb (who currently cannot write to this list due to bounced emails) convinced me that it is a good replacement for `/**` and `*/`: If twenty years of documentation

[PHP-DEV] New functions `hash_serialize` and `hash_unserialize`?

Hello internals! Thanks for PHP! I'm writing to gauge interest in two new functions to the PHP `hash` extension, `hash_serialize` and `hash_unserialize`. These functions would serialize and unserialize the internals of a HashContext object, allowing a partially-computed hash to be saved, then

Re: [PHP-DEV] [VOTE] Attribute Amendments

On Mon, 8 Jun 2020 at 09:13, Benjamin Eberlei wrote: > > I have opened voting for four different amendments to the Attributes RFC > > https://wiki.php.net/rfc/attribute_amendments To explain a 'no' vote. > Should a secondary grouped syntax for attributes be introduced? Voted no, as it's not

Re: [PHP-DEV] RFC: Error backtraces

On Tue, 2 Jun 2020 at 21:57, Max Semenik wrote: > > Thanks for your input! > > The problem with this is that it doesn't get called on fatal errors, That would be an easier and smaller thing to fix, rather than also changing error/warning handling. A stack trace shown on fatal errors that

[PHP-DEV] What to do with ext/imap?

Hi all, I'm wondering what to do with ext/imap, which uses libc-client which had its latest release (2007f) in 2011. There is a respective feature request in the bug tracker () where some ideas have been discussed, but apparently, not much happened for a while, and

Re: [PHP-DEV] [VOTE] Attribute Amendments

On 08/06/2020 16:30, Benjamin Eberlei wrote: On Mon, Jun 8, 2020 at 11:11 AM Lester Caine > wrote: On 08/06/2020 09:44, Marco Pivetta wrote: > I was mostly conflicted around the "allow grouped attributes" bit, but > James Titcumb (who currently

Re: [PHP-DEV] [VOTE] Attribute Amendments

On Mon, Jun 8, 2020, at 11:47 AM, Lester Caine wrote: > On 08/06/2020 16:30, Benjamin Eberlei wrote: > > > > > > On Mon, Jun 8, 2020 at 11:11 AM Lester Caine > > wrote: > > > > On 08/06/2020 09:44, Marco Pivetta wrote: > > > I was mostly conflicted around the

Re: [PHP-DEV] [VOTE] Attribute Amendments

On Mon, Jun 8, 2020 at 6:48 PM Lester Caine wrote: > On 08/06/2020 16:30, Benjamin Eberlei wrote: > > > > > > On Mon, Jun 8, 2020 at 11:11 AM Lester Caine > > wrote: > > > > On 08/06/2020 09:44, Marco Pivetta wrote: > > > I was mostly conflicted around the

Re: [PHP-DEV] [VOTE] Attribute Amendments

Hey, I'm not sure what you're referring to as "generic variable system" but given that you mentioned "type", I assume you mean typed variables? If so, PHP is never going to have typed variables due to performance implications. As for the `/**` and `*/`, I believe Marco was talking about Doctrine

Re: [PHP-DEV] [RFC] [Discussion] Remove inappropriate inheritance signature checks on private methods

Hey Pedro, On Mon, Jun 8, 2020 at 5:59 PM Pedro Magalhães wrote: > On Wed, May 27, 2020 at 12:07 AM Pedro Magalhães wrote: > >> On Tue, May 26, 2020 at 3:46 PM Marco Pivetta wrote: >> >>> Considering that, as far as I know, only the constructor remains >>> "special". >>> >> >> Leaving the

Re: [PHP-DEV] What to do with ext/imap?

On Mon, 8 Jun 2020 at 18:15, Christoph M. Becker wrote: > Hi all, > > I'm wondering what to do with ext/imap, which uses libc-client which had > its latest release (2007f) in 2011. There is a respective feature > request in the bug tracker () where some > ideas have

Re: [PHP-DEV] [RFC] Shorter attribute syntax

Hi Theodore, On 08.06.20 06:36, Theodore Brown wrote: ```php // 170 characters for attributes (162 not counting leading whitespace) << ManyToMany(Phonenumber::class), JoinTable("users_phonenumbers"), JoinColumn("user_id", "id"), InverseJoinColumn("phonenumber_id", "id",

Re: [PHP-DEV] [RFC] Shorter attribute syntax

On Mon, June 8, 2020 at 1:08 PM Markus Fischer wrote: > I noticed that my `@` character did bleed/meld almost with the first > character of the attribute name...wide characters like the `M` almost > touch the `@`. Hi Markus, The first question that comes to my mind is, wouldn't this also be

Re: [PHP-DEV] [RFC] Shorter attribute syntax

Hi Markus, On 08/06/2020 19:08, Markus Fischer wrote: Since we humans read source more often then we write, I can only suggest to everyone to conduct their own "visual" testing first and not just judge on technical merits => I think it makes sense to consider both here, since we're already

Re: [PHP-DEV] [RFC] Shorter attribute syntax

On Mon, June 8, 2020 at 10:01 AM Larry Garfield wrote: > FWIW, I find both alternatives ugly to my eye. So, there's that. > > Given that `@` is off the table for obvious reasons, my preference > would frankly be for Rust's `#[]`, which has the nice side effect > of being a normal comment in