[PHP-DEV] Re: Request for wiki karma

2022-06-20 Thread Christoph M. Becker
On 20.06.2022 at 06:43, shinji igarashi wrote: > I'd like to request a wiki RFC karma for constants in traits. > > The initial discussion on internals about it is here. > https://externals.io/message/110741 > > I have taken over Stephen's proposal and have a PoC implementation working on > my end

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-06-20 Thread Go Kudo
2022年6月20日(月) 22:16 Guilliam Xavier : > Hi, > > > https://wiki.php.net/rfc/random_extension_improvement > > Thanks, but I am not sure about your argument in "Classnames are not > canonicalized": does "PHP applies strict PascalCase to class names" > (which remains to be proved) really imply to

Re: [PHP-DEV] Discussion about new Curl URL API and ext/curl improvements

2022-06-20 Thread Pierrick Charron
Rowan, all, Thanks again for your comments. PHP8.2 is going to be feature freeze in exactly one month now and as the currently proposed improvements have not received any interest (and that's OK), I will put those aside for the moment and come back with a new approach that I hope will be better

Re: [PHP-DEV] Discussion about new Curl URL API and ext/curl improvements

2022-06-20 Thread Christoph M. Becker
On 20.06.2022 at 15:13, Pierrick Charron wrote: > Thanks again for your comments. PHP8.2 is going to be feature freeze in > exactly one month now and as the currently proposed improvements have not > received any interest (and that's OK), I will put those aside for the > moment and come back with

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-06-20 Thread Christoph M. Becker
On 20.06.2022 at 16:44, Go Kudo wrote: > 2022年6月20日(月) 23:37 Lynn : > >> On Mon, Jun 20, 2022 at 3:15 PM Guilliam Xavier > wrote: >> https://wiki.php.net/rfc/random_extension_improvement >>> >>> Thanks, but I am not sure about your argument in "Classnames are not >>> canonicalized": does

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-06-20 Thread Go Kudo
2022年6月21日(火) 0:42 Tim Düsterhus : > Hi > > On 6/20/22 17:12, Go Kudo wrote: > >> CombinedLCG > > > > This is provided as an OOP implementation for the `lcg_value()` function, > > but I don't actually > > want it to be used anymore, so I probably shouldn't provide a class for > it. > > > > And to

Re: [PHP-DEV] Make iterator_to_array() accept all iterables

2022-06-20 Thread Guilliam Xavier
On Fri, Jun 17, 2022 at 7:21 PM Tim Düsterhus wrote: > > Hi > > On 6/17/22 18:06, Guilliam Xavier wrote: > >> https://github.com/php/php-src/pull/8819 > > > > Just so that it can't be said that it hasn't been asked: what about > > iterator_count(), and iterator_apply()? > > I also came across

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-06-20 Thread Nicolas Grekas
> An RFC has been created to fix an issue in Random Extension 5.x. > > https://wiki.php.net/rfc/random_extension_improvement > > Voting on this RFC will begin in two weeks (2022-07-02), in time for the > PHP 8.2 Feature Freeze. (Vote finished in 2022-07-16, Feature Freeze is > 2022-07-19) > > In

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-06-20 Thread Go Kudo
2022年6月20日(月) 23:58 Nicolas Grekas : > > An RFC has been created to fix an issue in Random Extension 5.x. > > > > https://wiki.php.net/rfc/random_extension_improvement > > > > Voting on this RFC will begin in two weeks (2022-07-02), in time for the > > PHP 8.2 Feature Freeze. (Vote finished in

Re: [PHP-DEV] Discussion about new Curl URL API and ext/curl improvements

2022-06-20 Thread Rowan Tommins
On 20/06/2022 14:44, Christoph M. Becker wrote: Given that designing a new OO API obviously isn't uncontroversial, and that there are only four weeks left till feature freeze, it might be best to go with a simple procedural API for PHP 8.2 only. I haven't read back through the thread, but my

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-06-20 Thread Guilliam Xavier
Hi, > https://wiki.php.net/rfc/random_extension_improvement Thanks, but I am not sure about your argument in "Classnames are not canonicalized": does "PHP applies strict PascalCase to class names" (which remains to be proved) really imply to rename *acronyms* (e.g. "CombinedLCG" to

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-06-20 Thread Lynn
On Mon, Jun 20, 2022 at 3:15 PM Guilliam Xavier wrote: > Hi, > > > https://wiki.php.net/rfc/random_extension_improvement > > Thanks, but I am not sure about your argument in "Classnames are not > canonicalized": does "PHP applies strict PascalCase to class names" > (which remains to be proved)

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-06-20 Thread Go Kudo
2022年6月20日(月) 23:37 Lynn : > On Mon, Jun 20, 2022 at 3:15 PM Guilliam Xavier > > wrote: > > > Hi, > > > > > https://wiki.php.net/rfc/random_extension_improvement > > > > Thanks, but I am not sure about your argument in "Classnames are not > > canonicalized": does "PHP applies strict PascalCase

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-06-20 Thread Tim Düsterhus
Hi On 6/20/22 16:57, Nicolas Grekas wrote: I'm wondering: does Random\SerializableEngine extend Random\Engine? Can this be mentioned in the RFC? If not, what about making it this way? Having this interface only contain __(un)serialize would look strange to me, aka too broad for the name and the

Re: [PHP-DEV] [VOTE] Stricter implicit boolean coercions

2022-06-20 Thread Andreas Leathley
The vote has been closed, the RFC has been declined with 14 to 3 votes. It would have been interesting to get some more feedback on why people voted No - some took part in the discussion, but most didn't. My assumption is that most didn't find this important enough, especially if strict types is

[PHP-DEV] Acronyms in class names (was: [RFC] [Under Discussion] Random Extension Improvement)

2022-06-20 Thread Tim Düsterhus
Hi On 6/20/22 16:36, Lynn wrote: Not specifically directed at this discussion, but perhaps this needs a revision. HTTPStatus is much harder to read for me than HttpStatus and it's unclear where the boundary of an acronym starts or stops. If anyone ever decides to make an RFC for this, you have

Re: [PHP-DEV] Discussion about new Curl URL API and ext/curl improvements

2022-06-20 Thread Craig Francis
On 20 Jun 2022, at 14:44, Christoph M. Becker wrote: > On 20.06.2022 at 15:13, Pierrick Charron wrote: >> about the new Curl URL API, I think it's still time to finalize the >> discussions and include it in the 8.2 release as it allows us to solve some >> potential security issues. > > Given

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-06-20 Thread Tim Düsterhus
Hi On 6/20/22 17:12, Go Kudo wrote: CombinedLCG This is provided as an OOP implementation for the `lcg_value()` function, but I don't actually want it to be used anymore, so I probably shouldn't provide a class for it. And to begin with, the current CombinedLCG cannot even be seeded with

[PHP-DEV] [PHP 8.2] 30 days before feature freeze

2022-06-20 Thread Pierrick Charron
Hi internal, This is a friendly reminder from your RMs that the PHP 8.2 feature-freeze is in a month now [1] and time flies. If you plan to submit a RFC you have until July 5th to open it for vote so that it can be closed on time. Regards, Sergey, Pierrick and Ben [1]

Re: [PHP-DEV] Discussion about new Curl URL API and ext/curl improvements

2022-06-20 Thread Sara Golemon
On Sat, Jun 18, 2022 at 9:53 PM Pierrick Charron wrote: > I hope you don't mind, I took some of your code from your "Enable > strict_types checking for curl_setopt()" pull request [1] to do some test > on introducing this but only on the OOP API. It's working very well [2]. > Can I know why this

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-06-20 Thread Tim Düsterhus
Hi On 6/20/22 07:20, Go Kudo wrote: What about a signature like `Randomizer::pickArrayKeys(array $array, int $num): array`? The previous behavior when `int $num` is 1 can be easily reproduced as follows: ```php $randomizer = new Random\Randomizer(new Random\Engine\Mt19937(1234, MT_RAND_PHP));

Re: [PHP-DEV] [PHP 8.2] 30 days before feature freeze

2022-06-20 Thread Dan Ackroyd
On Mon, 20 Jun 2022 at 22:26, Pierrick Charron wrote: > > If you plan to submit a RFC you have > until July 5th to open it for vote so that it can be closed on time. Does that mean tomorrow midnight, or midnight today (aka in about 30 minutes time), is the last chance for RFCs to be announced as

Re: [PHP-DEV] Discussion about new Curl URL API and ext/curl improvements

2022-06-20 Thread Pierrick Charron
> > > I haven't read back through the thread, but my impression was that *for > the curl URL facility specifically* the opposite was the case: a simple > object with no procedural equivalent would be everyone's preference. > CurlFile provides enough of a precedent for adding that IMO. > +1 > >

Re: [PHP-DEV] [PHP 8.2] 30 days before feature freeze

2022-06-20 Thread Ben Ramsey
On 6/20/22 17:28, Dan Ackroyd wrote: On Mon, 20 Jun 2022 at 22:26, Pierrick Charron wrote: If you plan to submit a RFC you have until July 5th to open it for vote so that it can be closed on time. Does that mean tomorrow midnight, or midnight today (aka in about 30 minutes time), is the

[PHP-DEV] [RFC] [Under Discussion] PDO driver specific sub-classes

2022-06-20 Thread Dan Ackroyd
Hi, Following previous discussions, here is an RFC to have DB specific classes for PDO. https://wiki.php.net/rfc/pdo_driver_specific_subclasses cheers Dan Ack -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php

Re: [PHP-DEV] [RFC] [Under Discussion] PDO driver specific sub-classes

2022-06-20 Thread Stephen Reay
Sent from my iPhone > On 21 Jun 2022, at 06:08, Dan Ackroyd wrote: > > Hi, > > Following previous discussions, here is an RFC to have DB specific > classes for PDO. > > https://wiki.php.net/rfc/pdo_driver_specific_subclasses > > cheers > Dan > Ack > > -- > PHP Internals - PHP Runtime

Re: [PHP-DEV] [RFC] [Under Discussion] PDO driver specific sub-classes

2022-06-20 Thread Larry Garfield
On Mon, Jun 20, 2022, at 6:01 PM, Dan Ackroyd wrote: > Hi, > > Following previous discussions, here is an RFC to have DB specific > classes for PDO. > > https://wiki.php.net/rfc/pdo_driver_specific_subclasses > > cheers > Dan > Ack I'm conceptually in favor of this. A few comments: * Any chance