Re: [PHP-DEV] [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-04 Thread naitsirch
Am 02-Sep-2023 21:41:50 +0200 schrieb dossche.ni...@gmail.com: > Hello internals > > I'm opening the discussion for my RFC "DOM HTML5 parsing and serialization > support". > https://wiki.php.net/rfc/domdocument_html5_parser > > Kind regards > Niels > > -- > PHP Internals - PHP Runtime

[PHP-DEV] Re: [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-04 Thread Ben Ramsey
On 9/2/23 14:41, Niels Dossche wrote: I'm opening the discussion for my RFC "DOM HTML5 parsing and serialization support". https://wiki.php.net/rfc/domdocument_html5_parser Thanks, Niels. This is much needed. This proposal introduces the DOM\HTML5Document class that extends the

Re: [PHP-DEV] [RFC] [Discussion] Add 4 new rounding modes to round() function

2023-09-04 Thread Tim Düsterhus
Hi On 9/3/23 17:50, Alexandru Pătrănescu wrote: I believe consistency is important and using UP for "away from zero" and DOWN for "towards zero" sounds good to me. That was so far used consistently everywhere, as far as I'm aware. Documentation is very clear about what they mean, and you can

Re: [PHP-DEV] [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-04 Thread Niels Dossche
Hey Christian Thank you for going through my proposal. On 04/09/2023 09:23, naitsi...@e.mail.de wrote: > Am 02-Sep-2023 21:41:50 +0200 schrieb dossche.ni...@gmail.com: >> Hello internals >> >> I'm opening the discussion for my RFC "DOM HTML5 parsing and serialization >> support". >>

[PHP-DEV] Re: [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-04 Thread Niels Dossche
Hi Dennis On 04/09/2023 21:54, Dennis Snell wrote: > Thanks for the proposal Niels, > > I’ve dealt with my own grief working through issues in DOMDocument and > wanting it to work but finding it inadequate. > >> HTML5 > > This would be a great starting point; I would love it if we took the >

[PHP-DEV] Re: [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-04 Thread Dennis Snell via internals
Thanks for the proposal Niels, I’ve dealt with my own grief working through issues in DOMDocument and wanting it to work but finding it inadequate. > HTML5 This would be a great starting point; I would love it if we took the opportunity to fix named character reference decoding, as PHP has

Re: [PHP-DEV] [RFC] [Discussion] Add 4 new rounding modes to round() function

2023-09-04 Thread Jorg Sowa
Thank you all for the comments. The naming brought some constructive discussion. My preferred solution would be inconsistent PHP_ROUND_AWAY_FROM_ZERO and PHP_ROUND_TOWARD_ZERO as those are friendlier to the most of developers and are not possible to mistake with other modes. I would go even one