Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a final decision

2008-02-06 Thread Hannes Magnusson
On Feb 6, 2008 2:13 AM, Rasmus Lerdorf [EMAIL PROTECTED] wrote: Daniel Brown wrote: On Feb 5, 2008 3:26 PM, Daniel Brown [EMAIL PROTECTED] wrote: On Feb 5, 2008 3:23 PM, Pierre Joye [EMAIL PROTECTED] wrote: Hi, It seems that there is voices in favor of keeping the GPC related

Re: [PHP-DEV] json_encode() bug

2008-02-06 Thread Derick Rethans
On Tue, 5 Feb 2008, Richard Lynch wrote: On Sun, February 3, 2008 7:51 pm, Stanislav Malyshev wrote: Like I mentioned before (I think), it should not return an empty string of course because programmatically it's not possible to check for this. As most of our functions return false in

Re: [PHP-DEV] type hinting

2008-02-06 Thread Pierre Joye
On Feb 6, 2008 9:31 AM, Derick Rethans [EMAIL PROTECTED] wrote: I still we should add simple static typehints (ie. just the types that we use in the manual) - and they should behave in the same way as the other type hints that we laready have. Same here. -- Pierre http://blog.thepimp.net |

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a final decision

2008-02-06 Thread Derick Rethans
On Tue, 5 Feb 2008, Mike Willbanks wrote: I know they've been marked deprecated and all, but, really, what's the cost/penalty to having a couple functions around for legacy apps? Then we will continue to be at the same old issue of they exist, people will continue to use them and never

Re: [PHP-DEV] Splitting the subject: the PECL/PHP relationship

2008-02-06 Thread Marco
You forget that for most shared hosters they just install PHP so that they can say they support it, but actually don't give a ratsass about what is actually supported. I totally agree, most hosts just install what comes as default with a distribution, they don't care or even bother with PECL

Re: [PHP-DEV] type hinting

2008-02-06 Thread Derick Rethans
On Wed, 6 Feb 2008, Steph Fox wrote: As with so many topics on this list, I have no authority to influence the outcome. I personally think they've all got rules to instantly delete my email (but that's cause I'm paranoid). That's rubbish Richard - in some ways you're the most important

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a final decision

2008-02-06 Thread Derick Rethans
On Tue, 5 Feb 2008, Pierre Joye wrote: There is not really a need to discuss the removal again, that's why I ask for a simple vote: +1: remove them (as it is now in HEAD) -1: Restore them and always return FALSE (not 0) 0: I don't care, do what you wish, I never use them anyway I don't

Re: [PHP-DEV] Splitting the subject: the PECL/PHP relationship

2008-02-06 Thread Steph Fox
Hi both, I totally agree, most hosts just install what comes as default with a distribution, they don't care or even bother with PECL in 99% of cases in my experience. Well - that can't be entirely true or there'd be next to no MySQL support out there! I just think we make it needlessly

Re: [PHP-DEV] Splitting the subject: the PECL/PHP relationship

2008-02-06 Thread Marco
Well - that can't be entirely true or there'd be next to no MySQL support out there! I knew that would come back and bite me on the ass as soon as I posted! :-) MySQL support is one of the noteable exceptions as its considered core to web-hosts (In their eyes PHP and MySQL are one) other

Re: [PHP-DEV] Splitting the subject: the PECL/PHP relationship

2008-02-06 Thread Pierre Joye
On Feb 6, 2008 11:12 AM, Marco [EMAIL PROTECTED] wrote: Well - that can't be entirely true or there'd be next to no MySQL support out there! I knew that would come back and bite me on the ass as soon as I posted! :-) MySQL support is one of the noteable exceptions as its considered core

Re: [PHP-DEV] Splitting the subject: the PECL/PHP relationship

2008-02-06 Thread Steph Fox
Hi Pierre, The main reason (from my experiences) for the ISP is lazynes. They don't care about what the users may need or not but simply run configure, make make install, or use the xyz distribtutions default package to run common applications like phpmyadmin or wordpress. That's a heck of an

Re: [PHP-DEV] Splitting the subject: the PECL/PHP relationship

2008-02-06 Thread Steph Fox
Hi Marco, I think one of the reasons hosts don't like / use PECL is trust, they trust what comes with the PHP core packages and consider anything else a security risk. Maybe a combination of better distribution, package details, stability (beta / alpha) etc and maybe something that deals

Re: [PHP-DEV] Splitting the subject: the PECL/PHP relationship

2008-02-06 Thread Pierre Joye
On Feb 6, 2008 11:32 AM, Steph Fox [EMAIL PROTECTED] wrote: Hi Pierre, The main reason (from my experiences) for the ISP is lazynes. They don't care about what the users may need or not but simply run configure, make make install, or use the xyz distribtutions default package to run

Re: [PHP-DEV] TSRM mutex return value inconsitencies

2008-02-06 Thread Dmitry Stogov
Hi Scott, I'm fine with your patch. Please commit it, or let me know if you like me to commit it. Thanks. Dmitry. Scott MacVicar wrote: Hi, While doing some threaded work I noticed that tsrm_mutex_lock and tsrm_mutex_unlock return different values for Windows and Linux (using pthread).

Re: [PHP-DEV] Splitting the subject: the PECL/PHP relationship

2008-02-06 Thread Richard Quadling
On 06/02/2008, Steph Fox [EMAIL PROTECTED] wrote: By the way: http://www.nexen.net/articles/dossier/18038-base_configuration_for_php_5.2.5.php Thanks for that, Pierre. But I think those stats add to the argument for making PECL easier to deal with, rather than diminishing it. - Steph

Re: [PHP-DEV] Splitting the subject: the PECL/PHP relationship

2008-02-06 Thread Steph Fox
By the way: http://www.nexen.net/articles/dossier/18038-base_configuration_for_php_5.2.5.php Thanks for that, Pierre. But I think those stats add to the argument for making PECL easier to deal with, rather than diminishing it. - Steph -- Pierre http://blog.thepimp.net |

Re: [PHP-DEV] type hinting

2008-02-06 Thread Tomi Kaistila
I still we should add simple static typehints (ie. just the types that we use in the manual) - and they should behave in the same way as the other type hints that we laready have. I also agree with this too. Add the common types first and then if there is a good reason, add special ones but

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a final decision

2008-02-06 Thread Jochem Maas
-1 Pierre Joye schreef: Hi, It seems that there is voices in favor of keeping the GPC related functions in HEAD/php6 but returning always FALSE. I thought the decision was already done but I rather prefer to ask the list a second time and be done with this topic (and be free to bogus any other

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a final decision

2008-02-06 Thread Lokrain
-1 On Feb 5, 2008 10:23 PM, Pierre Joye [EMAIL PROTECTED] wrote: Hi, It seems that there is voices in favor of keeping the GPC related functions in HEAD/php6 but returning always FALSE. I thought the decision was already done but I rather prefer to ask the list a second time and be done

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a final decision

2008-02-06 Thread Vesselin Kenashkov
+1 - remove the functions To make a script compatible one has to add function get_magic_quotes_gpc(){return 0;} in one of his library files. I think the current change is somewhat similar to PHP_INI_ALL in PHP - PHP_INI_PERDIR for magic_quotes_gpc made in 4.2.3. It also could lead to breakage

Re: [PHP-DEV] [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_3) / zend_API.czend_API.h php-src/ext/standard type.c

2008-02-06 Thread Marcus Boerger
Hello Pierre, internal c-level code is written in a way that it expects $this to be available and will crash if it is not for the most. Thus we prevent calling internal dynamic functions as static ones unless they are flagged as such. Tuesday, February 5, 2008, 11:17:11 PM, you wrote: On Feb

Re: [PHP-DEV] type hinting

2008-02-06 Thread Sam Barrow
On Wed, 2008-02-06 at 09:31 +0100, Derick Rethans wrote: On Wed, 6 Feb 2008, Steph Fox wrote: As with so many topics on this list, I have no authority to influence the outcome. I personally think they've all got rules to instantly delete my email (but that's cause I'm paranoid).

Re: [PHP-DEV] TSRM mutex return value inconsitencies

2008-02-06 Thread Scott MacVicar
Hi Dmitry, I don't have karma for TSRM only php-src. Scott Dmitry Stogov wrote: Hi Scott, I'm fine with your patch. Please commit it, or let me know if you like me to commit it. Thanks. Dmitry. Scott MacVicar wrote: Hi, While doing some threaded work I noticed that tsrm_mutex_lock and

Re: [PHP-DEV] type hinting

2008-02-06 Thread Derick Rethans
On Wed, 6 Feb 2008, Sam Barrow wrote: On Wed, 2008-02-06 at 09:31 +0100, Derick Rethans wrote: I still we should add simple static typehints (ie. just the types that we use in the manual) - and they should behave in the same way as the other type hints that we laready have. True,

Re: [PHP-DEV] type hinting

2008-02-06 Thread Chris Stockton
To me it does not make sense to have a scalar type hint. For the simple reason it's inconsistent with PHP, and it adds no value other then the fact you then know the value is not on array (or maybe not a resource?). It's also inconsistent with PHP, array type hinting, is complemented by array

Re: [PHP-DEV] type hinting

2008-02-06 Thread Sam Barrow
On Wed, 2008-02-06 at 14:20 +0100, Derick Rethans wrote: On Wed, 6 Feb 2008, Sam Barrow wrote: On Wed, 2008-02-06 at 09:31 +0100, Derick Rethans wrote: I still we should add simple static typehints (ie. just the types that we use in the manual) - and they should behave in the same

Re: [PHP-DEV] type hinting

2008-02-06 Thread Sam Barrow
On Wed, 2008-02-06 at 06:30 -0700, Chris Stockton wrote: To me it does not make sense to have a scalar type hint. For the simple reason it's inconsistent with PHP, and it adds no value other then the fact you then know the value is not on array (or maybe not a Ok. Well the array type hint

Re: [PHP-DEV] type hinting

2008-02-06 Thread Pierre Joye
HI Sam, On Feb 6, 2008 2:33 PM, Sam Barrow [EMAIL PROTECTED] wrote: On Wed, 2008-02-06 at 14:20 +0100, Derick Rethans wrote: On Wed, 6 Feb 2008, Sam Barrow wrote: On Wed, 2008-02-06 at 09:31 +0100, Derick Rethans wrote: I still we should add simple static typehints (ie. just the

Re: [PHP-DEV] type hinting

2008-02-06 Thread Chris Stockton
Ok. Well the array type hint ensures that it is an array. This just does the opposite then, I don't see a problem with that. I like to be able to protected my code from having arrays/objects accidentally inserted into databases or outputted. I completely understand you want to create (easier)

Re: [PHP-DEV] type hinting

2008-02-06 Thread Elizabeth M Smith
Wow, you guys sure are a bit harsh Here's the problem - there's a group of people who really want true (I might say javaish) type-hints for scalar values - int, bool, string, float, and won't settle for anything less. There's a group who thinks type hints are stupid because of the way php

Re: [PHP-DEV] type hinting

2008-02-06 Thread Sam Barrow
On Wed, 2008-02-06 at 15:31 +0100, Pierre Joye wrote: HI Sam, On Feb 6, 2008 2:33 PM, Sam Barrow [EMAIL PROTECTED] wrote: On Wed, 2008-02-06 at 14:20 +0100, Derick Rethans wrote: On Wed, 6 Feb 2008, Sam Barrow wrote: On Wed, 2008-02-06 at 09:31 +0100, Derick Rethans wrote:

Re: [PHP-DEV] type hinting

2008-02-06 Thread Pierre Joye
Hi Sam, On Feb 6, 2008 4:08 PM, Sam Barrow [EMAIL PROTECTED] wrote: On Wed, 2008-02-06 at 15:31 +0100, Pierre Joye wrote: HI Sam, On Feb 6, 2008 2:33 PM, Sam Barrow [EMAIL PROTECTED] wrote: On Wed, 2008-02-06 at 14:20 +0100, Derick Rethans wrote: On Wed, 6 Feb 2008, Sam Barrow

Re: [PHP-DEV] type hinting

2008-02-06 Thread Sam Barrow
On Wed, 2008-02-06 at 10:09 -0500, Elizabeth M Smith wrote: Wow, you guys sure are a bit harsh Here's the problem - there's a group of people who really want true (I might say javaish) type-hints for scalar values - int, bool, string, float, and won't settle for anything less.

Re: [PHP-DEV] type hinting

2008-02-06 Thread Lukas Kahwe Smith
Hi All, Just a suggestion. Maybe make your case analyzing a set of representative php applications for calls to the various is*() methods (maybe even factoring in assert()). This could help in showing how often people are currently forced to write out type checks. My humble guess:

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a final decision

2008-02-06 Thread Geoffrey Sneddon
On 5 Feb 2008, at 20:23, Pierre Joye wrote: There is not really a need to discuss the removal again, that's why I ask for a simple vote: +1 -- Geoffrey Sneddon http://gsnedders.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] type hinting

2008-02-06 Thread Pierre Joye
On Feb 6, 2008 5:13 PM, Lukas Kahwe Smith [EMAIL PROTECTED] wrote: Hi All, Just a suggestion. Maybe make your case analyzing a set of representative php applications for calls to the various is*() methods (maybe even factoring in assert()). This could help in showing how often people are

Re: [PHP-DEV] type hinting

2008-02-06 Thread Chris Stockton
Really, it's not the most accurate test, to make it more accurate you would only check parameter variables but I wanted something fast. These are the calls to the is_* family from a major library. All calls are within a Class { }. I think this shows several things, a couple I would like to mention

Re: [PHP-DEV] type hinting

2008-02-06 Thread Stefan Priebsch
Sam Barrow schrieb: If anyone has any objections to a scalar type hint please raise a valid point. Chris Stockton schrieb: This library would probably have ~300(String) + ~110(Int) ~40(Resource) ~30(Bool) ~10(Float) = 500 less function calls, and much cleaner code if there was type hinting.

Re: [PHP-DEV] type hinting

2008-02-06 Thread Alain Williams
On Wed, Feb 06, 2008 at 06:47:23PM +0100, Stefan Priebsch wrote: Sam Barrow schrieb: If anyone has any objections to a scalar type hint please raise a valid point. Chris Stockton schrieb: This library would probably have ~300(String) + ~110(Int) ~40(Resource) ~30(Bool) ~10(Float) = 500

Re: [PHP-DEV] type hinting

2008-02-06 Thread Stanislav Malyshev
This library would probably have ~300(String) + ~110(Int) ~40(Resource) ~30(Bool) ~10(Float) = 500 less function calls, and much cleaner code if there was type hinting. You forgot the code that you'd have to write to deal with the situation that typehinted function fails. I understand a lot

Re: [PHP-DEV] type hinting

2008-02-06 Thread Pierre Joye
On Feb 6, 2008 7:13 PM, Stanislav Malyshev [EMAIL PROTECTED] wrote: with. Bottom line all stubbornness should be put aside and look to see if it would improve the language use and appeal to a large user base, No, it won't improve. for you. Cheers, -- Pierre http://blog.thepimp.net |

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a final decision

2008-02-06 Thread Markus Fischer
Markus Fischer wrote: +1 I didn't realized it until I read Rasmus' mail. In this case, -1 to not break BC. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a final decision

2008-02-06 Thread Mark van der Velden
Pierre Joye wrote: Hi, +1: remove them (as it is now in HEAD) -1: Restore them and always return FALSE (not 0) 0: I don't care, do what you wish, I never use them anyway -1 -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a final decision

2008-02-06 Thread Cristian Rodriguez
2008/2/6, Derick Rethans [EMAIL PROTECTED]: I don't care that much, but I think it would matter if the functions just are there and return false (so -1). for set_magic_quotes_runtime(), if true is passed, it should still throw a fatal error, if false is passed it should not (or actually 1

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a final decision

2008-02-06 Thread Pierre Joye
On Feb 6, 2008 9:20 PM, Cristian Rodriguez [EMAIL PROTECTED] wrote: 2008/2/6, Derick Rethans [EMAIL PROTECTED]: I don't care that much, but I think it would matter if the functions just are there and return false (so -1). for set_magic_quotes_runtime(), if true is passed, it should still

RE: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a final decision

2008-02-06 Thread Andi Gutmans
-1 Suggestion to enhance the suggestion: return false + emit E_STRICT message (but I am also fine with pure return false if people don't like this suggestion). Andi -Original Message- From: Pierre Joye [mailto:[EMAIL PROTECTED] Sent: Tuesday, February 05, 2008 12:23 PM To: PHP

[PHP-DEV] Re: get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a final decision

2008-02-06 Thread Nathan Rixham
0 for me -1 for all the people who'll bug the mailing lists askign where they've gone suggest: E_NOTICE or E_STRICT telling the magic_quotes_runtime has gone BUT in the next php 5.2.X release so peeps get used to it! Pierre Joye wrote: Hi, It seems that there is voices in favor of keeping

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a final decision

2008-02-06 Thread Pierre Joye
Hi Andi, On Feb 7, 2008 12:56 AM, Andi Gutmans [EMAIL PROTECTED] wrote: -1 Suggestion to enhance the suggestion: return false + emit E_STRICT message (but I am also fine with pure return false if people don't like this suggestion). Sounds reasonable too. It would be nice to add a deprecate

Re: [PHP-DEV] _REQUEST and variable_order

2008-02-06 Thread Sam Barrow
On Wed, 2008-02-06 at 16:39 -0800, Stanislav Malyshev wrote: Hi! This topic was already discussed here but never arrived to a conclusion, so I will raise it again. The Problem: We have $_REQUEST superglobal, which is often used to abstract GET/POST requests. However, in most cases we do

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a final decision

2008-02-06 Thread Steph Fox
I'm going to rock the boat again I guess... Suggestion to enhance the suggestion: return false + emit E_STRICT message (but I am also fine with pure return false if people don't like this suggestion). Sounds reasonable too. It would be nice to add a deprecate notice in 5.3.x as well.

Re: [PHP-DEV] _REQUEST and variable_order

2008-02-06 Thread Jessie Hernandez
Sam Barrow wrote: On Wed, 2008-02-06 at 16:39 -0800, Stanislav Malyshev wrote: [snip] The proposal(s): 1. One way to fix it is to create a new .ini request_order that would control just _REQUEST. 2. Other solution would be to keep variables_order but drop 'C' parsing from _REQUEST - i.e.

[PHP-DEV] Re: get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a final decision

2008-02-06 Thread Gregory Beaver
Pierre Joye wrote: -1: Restore them and always return FALSE (not 0) -1 -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] _REQUEST and variable_order

2008-02-06 Thread Rasmus Lerdorf
Stanislav Malyshev wrote: Hi! This topic was already discussed here but never arrived to a conclusion, so I will raise it again. The Problem: We have $_REQUEST superglobal, which is often used to abstract GET/POST requests. However, in most cases we do not want GET/POST variables to

Re: [PHP-DEV] _REQUEST and variable_order

2008-02-06 Thread Sam Barrow
On Wed, 2008-02-06 at 20:27 -0800, Rasmus Lerdorf wrote: Stanislav Malyshev wrote: Hi! This topic was already discussed here but never arrived to a conclusion, so I will raise it again. The Problem: We have $_REQUEST superglobal, which is often used to abstract GET/POST