Re: [PHP-DEV] [RFC] GitHub Pull Requests Triage Team

Big +1 for me. This is good a idea to make contributors' work easier. On 31 October 2014 05:57, John Bafford wrote: > Hi, > > I would like to propose the creation of a team to triage the pull requests > on GitHub, to help ensure that the pull requests are handled in a timely > manner. I am also

Re: [PHP-DEV] New Standardized HTTP Interface

So far there seems to be a lot of concern around BC, and particularly removing or getting rid of GPC superglobals. So I completely understand the concerns and hope to address them as clearly as possible. First, for the sake of BC I think removing the superglobals from the language should not be do

Re: [PHP-DEV] [RFC] Using objects as keys

> On Oct 30, 2014, at 6:20 PM, Lester Caine wrote: > > On 30/10/14 17:42, Rowan Collins wrote: >> The use case which came up recently was UString objects, which can >> easily be converted to and from plain PHP strings, but would be useful >> as keys in their own right. With current PHP you could

Re: [PHP-DEV] [RFC] Using objects as keys

On 30/10/14 17:42, Rowan Collins wrote: > The use case which came up recently was UString objects, which can > easily be converted to and from plain PHP strings, but would be useful > as keys in their own right. With current PHP you could do $foo[ > (string)$u_str ] = $bar; with the proposed RFC, y

Re: [PHP-DEV] [RFC] Using objects as keys

> On Oct 30, 2014, at 3:28 PM, Andrea Faulds wrote: > > >> On 30 Oct 2014, at 19:51, Will Fitch wrote: >> >> My only concern at this point is the default value of the hash. If we were >> to use spl _object_hash, we could be setting a precedence that a hash must >> be unique to each object.

Re: [PHP-DEV] New Standardized HTTP Interface

On 10/30/14, 1:23 PM, Sherif Ramadan wrote: Hello Internals, I've been meaning to write up a full-blown RFC for introducing a new standardized HTTP interface for PHP core for some time now. I figure now with PHP 7 on the road map this might be a good time to start this discussion since it involv

[PHP-DEV] [RFC] GitHub Pull Requests Triage Team

Hi, I would like to propose the creation of a team to triage the pull requests on GitHub, to help ensure that the pull requests are handled in a timely manner. I am also volunteering to lead such a team, should the RFC be approved. https://wiki.php.net/rfc/github-pr PHP’s GitHub repository has

Re: [PHP-DEV] New Standardized HTTP Interface

> On Oct 30, 2014, at 4:15 PM, Andrea Faulds wrote: > > >> On 30 Oct 2014, at 20:49, Sherif Ramadan wrote: >> >> No, the interface makes it possible to implement your own behavior, but it >> does not prevent PHP from implementing default behavior. In that PHP would >> implement its own Htt

Re: [PHP-DEV] New Standardized HTTP Interface

> On 30 Oct 2014, at 20:49, Sherif Ramadan wrote: > > No, the interface makes it possible to implement your own behavior, but it > does not prevent PHP from implementing default behavior. In that PHP would > implement its own HttpRequest class, for example, which the user can then > extend to

Re: [PHP-DEV] Re: phpdbg situation in PHP-5.6

> Am 30.10.2014 um 19:23 schrieb Stas Malyshev : > > Hi! > >> An alternative would be just putting a few #if 0 in code >> (phpdbg_out.c where the outputting of anything is centralized) to >> make XML stuff not usable. Maybe that one is the cleanest and least >> invasive with still allowing us to

Re: [PHP-DEV] New Standardized HTTP Interface

On Thu, Oct 30, 2014 at 4:42 PM, Andrea Faulds wrote: > > > On 30 Oct 2014, at 20:33, Sherif Ramadan > wrote: > > > > Yes, this proposal is intended to do two things. 1) Fix the > aforementioned problems. > > By the sounds of things, it doesn’t fix these problems, it just adds a new > interface

Re: [PHP-DEV] New Standardized HTTP Interface

> On 30 Oct 2014, at 20:33, Sherif Ramadan wrote: > > Yes, this proposal is intended to do two things. 1) Fix the aforementioned > problems. By the sounds of things, it doesn’t fix these problems, it just adds a new interface which lacks them. That’s not the same thing. > 2) Improve upon the

Re: [PHP-DEV] New Standardized HTTP Interface

On Thu, Oct 30, 2014 at 4:24 PM, Andrea Faulds wrote: > > > On 30 Oct 2014, at 19:49, Sherif Ramadan > wrote: > > > > Well, let's look at how well providing implementation has worked out for > > PHP so far. > > > > GPC variables are implementation. They pose rigidity to userland code > for a > >

Re: [PHP-DEV] [RFC] Using objects as keys

> On 30 Oct 2014, at 19:51, Will Fitch wrote: > > My only concern at this point is the default value of the hash. If we were to > use spl _object_hash, we could be setting a precedence that a hash must be > unique to each object. In addition to what Stas says above, well, not all objects work

Re: [PHP-DEV] New Standardized HTTP Interface

> On 30 Oct 2014, at 19:49, Sherif Ramadan wrote: > > Well, let's look at how well providing implementation has worked out for > PHP so far. > > GPC variables are implementation. They pose rigidity to userland code for a > number of reasons. For example, if you do send a PUT request to PHP, PHP

Re: [PHP-DEV] [RFC] Using objects as keys

Hi! > My only concern at this point is the default value of the hash. If we > were to use spl _object_hash, we could be setting a precedence that a > hash must be unique to each object. I don't think there should be any default value. Most objects are not suitable as keys, only some of them are (

Re: [PHP-DEV] New Standardized HTTP Interface

On Thu, Oct 30, 2014 at 2:30 PM, Florian Margaine wrote: > > > I find this very... useless. Sure, interfaces are not useless. But I don't > think php-src is there to dictate what userland code should look like. It > should provide *implementations*, not interfaces. > Well, let's look at how well

Re: [PHP-DEV] [RFC] Using objects as keys

> On Oct 30, 2014, at 1:32 PM, Stas Malyshev wrote: > > Hi! > >> Put another way, I think a key question here is: >> >> class Foo { >> public $bar; >> } >> >> $a = new Foo; >> $a->bar = 'baz'; >> $b = new Foo; >> $b->bar = 'baz'; >> >> $arr[$a] = true; >> $arr[$b] = true; >> >> >> Does

Re: [PHP-DEV] New Standardized HTTP Interface

Florian Margaine wrote on 30/10/2014 18:30: Hi, On Thu, Oct 30, 2014 at 7:23 PM, Sherif Ramadan wrote: Since it's an interface, it only dictates the facilitation of PHP's built-in functionality and the user's desired implementation, but no the implementation itself. I find this very... usel

Re: [PHP-DEV] [RFC] Using objects as keys

Larry Garfield wrote on 30/10/2014 18:07: On 10/30/14, 2:19 AM, Will Fitch wrote: On Oct 30, 2014, at 2:13 AM, Christian Stoller wrote: From: Alexander Lisachenko [mailto:lisachenko...@gmail.com], Sent: Monday, October 27, 2014 11:18 AM Hello, internals! The name __hash is not final

Re: [PHP-DEV] [RFC] Using objects as keys

Hi! > Put another way, I think a key question here is: > > class Foo { >public $bar; > } > > $a = new Foo; > $a->bar = 'baz'; > $b = new Foo; > $b->bar = 'baz'; > > $arr[$a] = true; > $arr[$b] = true; > > > Does $arr now contain one value or two? That depends on the semantics of class Fo

Re: [PHP-DEV] New Standardized HTTP Interface

Hi, On Thu, Oct 30, 2014 at 7:23 PM, Sherif Ramadan wrote: > Hello Internals, > > I've been meaning to write up a full-blown RFC for introducing a new > standardized HTTP interface for PHP core for some time now. I figure now > with PHP 7 on the road map this might be a good time to start this >

Re: [PHP-DEV] Re: phpdbg situation in PHP-5.6

Hi! > An alternative would be just putting a few #if 0 in code > (phpdbg_out.c where the outputting of anything is centralized) to > make XML stuff not usable. Maybe that one is the cleanest and least > invasive with still allowing us to change the whole XML stuff. And at > the same time the norma

[PHP-DEV] New Standardized HTTP Interface

Hello Internals, I've been meaning to write up a full-blown RFC for introducing a new standardized HTTP interface for PHP core for some time now. I figure now with PHP 7 on the road map this might be a good time to start this discussion since it involves breaking some backwards compatibility that

Re: [PHP-DEV] [RFC] Using objects as keys

On 10/30/14, 2:19 AM, Will Fitch wrote: On Oct 30, 2014, at 2:13 AM, Christian Stoller wrote: From: Alexander Lisachenko [mailto:lisachenko...@gmail.com], Sent: Monday, October 27, 2014 11:18 AM Hello, internals! The name __hash is not final, I am open to using __toKey instead or any

Re: [PHP-DEV] [RFC] Using objects as keys

Lester Caine wrote on 30/10/2014 16:44: On 30/10/14 15:06, Rowan Collins wrote: On 30 October 2014 10:40:10 GMT, Lester Caine wrote: On 30/10/14 07:19, Will Fitch wrote: The magic method is more of a PHP approach while an interface would be more appropriate. That said, this RFC is a true re

Re: [PHP-DEV] New globals for PUT and DELETE

On 10/28/14, 11:25 AM, Michael Wallner wrote: On 28/10/14 16:58, Ben Ramsey wrote: On Oct 26, 2014, at 4:30 PM, Will Fitch wrote: 100% agree. Perhaps focusing on getting pecl/http v2 added as ext or core should be the real discussion: https://wiki.php.net/rfc/pecl_http

[PHP-DEV] opcache.revalidate_freq is PHP_INI_ALL?

https://github.com/php/php-src/blob/master/ext/opcache/zend_accelerator_module.c#L259 That looks suspicious to me and in simple testing doesn't appear to be the case. I mean, you can set it per-dir, but it doesn't make any difference at that point. Dmitry, could you go through the list of opcache

Re: [PHP-DEV] [RFC] Using objects as keys

On 30/10/14 15:06, Rowan Collins wrote: > On 30 October 2014 10:40:10 GMT, Lester Caine wrote: >> On 30/10/14 07:19, Will Fitch wrote: >>> The magic method is more of a PHP approach while an interface would >> be more appropriate. That said, this RFC is a true representation of a >> hash vs somet

[PHP-DEV] Re: phpdbg situation in PHP-5.6

On Thu, Oct 30, 2014 at 1:21 PM, Bob Weinand wrote: > > Am 30.10.2014 um 13:06 schrieb Ferenc Kovacs : > On Thu, Oct 30, 2014 at 11:59 AM, Bob Weinand wrote: > >> Hey, I can accept that. >> >> But it’d be great if you could only revert now in the 5.6.3 release >> branch, not in the 5.6 developme

Re: [PHP-DEV] [RFC] Using objects as keys

On 30 October 2014 10:40:10 GMT, Lester Caine wrote: >On 30/10/14 07:19, Will Fitch wrote: >> The magic method is more of a PHP approach while an interface would >be more appropriate. That said, this RFC is a true representation of a >hash vs something like spl_object_hash. That’s what causes us

Re: [PHP-DEV] Re: phpdbg situation in PHP-5.6

On Oct 30, 2014 5:59 PM, "Bob Weinand" wrote: > To add for 3.: Issues where with what I really couldn’t think of (separate build dir on Linux…) or the issues with a JSON dep or Windows which I couldn’t test. For this part, I can get you and Joe full msdn subscription if desired.

Re: [PHP-DEV] Re: [RFC] Access to aliases definition by reflection

On Thu, Oct 30, 2014 at 2:43 AM, Miloslav Hůla wrote: > Dne 13.10.2014 14:55, Miloslav Hůla napsal(a): >> >> I've written an RFC which proposes to expose a namespace aliases/imports >> for user-land code. > > > Good morning internals, > > it has been two weeks since I announced this RFC in this li

[PHP-DEV] Re: phpdbg situation in PHP-5.6

> Am 30.10.2014 um 13:06 schrieb Ferenc Kovacs : > On Thu, Oct 30, 2014 at 11:59 AM, Bob Weinand > wrote: > Hey, I can accept that. > > But it’d be great if you could only revert now in the 5.6.3 release branch, > not in the 5.6 development branch, so that this gives

[PHP-DEV] Re: phpdbg situation in PHP-5.6

On Thu, 2014-10-30 at 13:06 +0100, Ferenc Kovacs wrote: > > > On Thu, Oct 30, 2014 at 11:59 AM, Bob Weinand > wrote: > Hey, I can accept that. > > > But it’d be great if you could only revert now in the 5.6.3 > release branch, not in the 5.6 development

Re: [PHP-DEV] Re: phpdbg situation in PHP-5.6

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Le 30/10/2014 11:59, Bob Weinand a écrit : > Also, just to point it out: Windows allows extensions to be in a > random directory, *nix does not. I’d rather change the > /acinclude.m4 to not be bound to the /ext directory, so that it > just works like

[PHP-DEV] Re: phpdbg situation in PHP-5.6

On Thu, Oct 30, 2014 at 11:59 AM, Bob Weinand wrote: > Hey, I can accept that. > > But it’d be great if you could only revert now in the 5.6.3 release > branch, not in the 5.6 development branch, so that this gives us now still > some time to see what exactly we want to revert or not and for some

Re: [PHP-DEV] [PR] DateTime RFC7231 constant

On 30 October 2014 11:26, Andrea Faulds wrote: > > > On 30 Oct 2014, at 07:03, Trevor Suarez wrote: > > > > Good early morning (late night for me) internals! > > > > I would like to propose a small addition be made to the DateTime date > > format constant definitions. > > > > https://github.com/

Re: [PHP-DEV] [PR] DateTime RFC7231 constant

Hi, On 30/10/2014 08:03, Trevor Suarez wrote: > Good early morning (late night for me) internals! > > I would like to propose a small addition be made to the DateTime date > format constant definitions. > > https://github.com/php/php-src/pull/882 Thanks for the PR. However, I'm afraid the comm

Re: [PHP-DEV] [PR] DateTime RFC7231 constant

> On 30 Oct 2014, at 07:03, Trevor Suarez wrote: > > Good early morning (late night for me) internals! > > I would like to propose a small addition be made to the DateTime date > format constant definitions. > > https://github.com/php/php-src/pull/882 Looks simple and unobjectionable. :) > T

[PHP-DEV] Re: phpdbg situation in PHP-5.6

Hey, I can accept that. But it’d be great if you could only revert now in the 5.6.3 release branch, not in the 5.6 development branch, so that this gives us now still some time to see what exactly we want to revert or not and for some eventual RFC? To add for 3.: Issues where with what I really

Re: [PHP-DEV] [RFC] Using objects as keys

On 30/10/14 07:19, Will Fitch wrote: > The magic method is more of a PHP approach while an interface would be more > appropriate. That said, this RFC is a true representation of a hash vs > something like spl_object_hash. That’s what causes user confusion. > spl_object_hash would’ve been bett

[PHP-DEV] phpdbg situation in PHP-5.6

Hi, Julien an me came to an agreement to revert the recent(the remote debugging stuff not part of any official release yet) phpdbg changes after a discussion with Stas and David. We do understand that this feature is considered a pretty important and requested feature, but we think that there are

[PHP-DEV] Re: [RFC] Access to aliases definition by reflection

Dne 13.10.2014 14:55, Miloslav Hůla napsal(a): I've written an RFC which proposes to expose a namespace aliases/imports for user-land code. Good morning internals, it has been two weeks since I announced this RFC in this list. I hope all the questions and remarks have been answered. If so, I

Re: [PHP-DEV] PHPDBG nonsense (Was: Re: [PHP-CVS] com php-src: Made phpdbg compatible with new engine: ...)

On Thu, 2014-10-30 at 14:56 +0700, Pierre Joye wrote: > > This is new information to me, I was lead to believe that phpstorm > > were > > happy to invest time in it. > > > > I asked bob for the xml stuff to be reverted from 5.6 and master > > yesterday and be developed elsewhere. >

Re: [PHP-DEV] PHPDBG nonsense (Was: Re: [PHP-CVS] com php-src: Made phpdbg compatible with new engine: ...)

> This is new information to me, I was lead to believe that phpstorm > were > happy to invest time in it. > > I asked bob for the xml stuff to be reverted from 5.6 and master > yesterday and be developed elsewhere. > > This now *must* happen, it doesn't belong in php-src at

Re: [PHP-DEV] PHPDBG nonsense (Was: Re: [PHP-CVS] com php-src: Made phpdbg compatible with new engine: ...)

On Wed, 2014-10-29 at 17:08 -0700, Derick Rethans wrote: > On Sun, 26 Oct 2014, Bob Weinand wrote: > > > > > > Am 26.10.2014 um 16:09 schrieb Derick Rethans : > > > > > > On Sat, 25 Oct 2014, Joe Watkins wrote: > > > > > >> On Fri, 2014-10-24 at 23:06 -0400, Derick Rethans wrote: > > >>> On Fri

Re: [PHP-DEV] [RFC] Using objects as keys

> On Oct 30, 2014, at 2:13 AM, Christian Stoller wrote: > > > From: Alexander Lisachenko [mailto:lisachenko...@gmail.com], Sent: Monday, > October 27, 2014 11:18 AM > >> Hello, internals! >> >>> The name __hash is not final, I am open to using __toKey instead or any >>> reasonable alternativ

RE: [PHP-DEV] [RFC] Using objects as keys

From: Alexander Lisachenko [mailto:lisachenko...@gmail.com], Sent: Monday, October 27, 2014 11:18 AM > Hello, internals! > >> The name __hash is not final, I am open to using __toKey instead or any >> reasonable alternative, we may also include a couple of options in the >> vote if that will be

[PHP-DEV] [PR] DateTime RFC7231 constant

Good early morning (late night for me) internals! I would like to propose a small addition be made to the DateTime date format constant definitions. https://github.com/php/php-src/pull/882 This is my first contribution to PHP's core. I wasn't sure if something of this nature would require an RFC