[PHP-DEV] Null bytes in anonymous class names

2015-11-05 Thread Niklas Keller
Hello, I discovered today that anonymous class names contain a null byte right after "class@anonymous". I don't think class names should contain non-printable characters. How about removing that null byte? https://3v4l.org/QUKpV

[PHP-DEV] Benchmark Results for PHP Master 2015-11-05

2015-11-05 Thread lp_benchmark_robot
Results for project PHP master, build date 2015-11-05 05:27:19+02:00 commit: d598e1bc6c55f831f3ffb556084266dccb875512 revision date: 2015-11-04 06:44:48-08:00 environment:Haswell-EP cpu:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB

Re: [PHP-DEV] [RFC][DISCUSSION] Trailing commas in all list syntax

2015-11-05 Thread Peter Petermann
Hi Sammy, > https://wiki.php.net/rfc/list-syntax-trailing-commas my thoughts on this: 1) having list separators (commas) signals "there is one more item" (thats the semantic meaning of a comma in a list, right?) 2) you are right, arrays vs. other lists behave inconsistent however, if i take

Re: [PHP-DEV] Re: Small regression in PHP-LDAP

2015-11-05 Thread Ferenc Kovacs
On Wed, Nov 4, 2015 at 4:28 AM, Côme Chilliet wrote: > Le mardi 3 novembre 2015, 18:59:42 Andrea Faulds a écrit : > > I'd argue this is a regression, documented feature or not. Supporting > > 'host:port' is not a bug, and this has broken existing code, which micro > > (x.y.Z)

[PHP-DEV] Re: [RFC][DISCUSSION] Trailing commas in all list syntax

2015-11-05 Thread Andrea Faulds
Hi Sammy, Sammy Kaye Powers wrote: The RFC to allow trailing commas to function calls & declarations has been withdrawn in favor of the a RFC that broadens the scope to all list syntax. https://wiki.php.net/rfc/list-syntax-trailing-commas My thoughts on this are much the same as my

Re: [PHP-DEV] Re: Small regression in PHP-LDAP

2015-11-05 Thread Bishop Bettini
On Thu, Nov 5, 2015 at 8:56 AM, Ferenc Kovacs wrote: > On Thu, Nov 5, 2015 at 2:26 PM, Andreas Heigl wrote: > > > Am 05.11.15 um 14:14 schrieb Ferenc Kovacs: > > [...] > > > I would keep the old behavior for 5.6, even if that was unintended > nobody > > >

Re: [PHP-DEV] Re: Small regression in PHP-LDAP

2015-11-05 Thread Ferenc Kovacs
On Thu, Nov 5, 2015 at 5:38 PM, Bishop Bettini wrote: > On Thu, Nov 5, 2015 at 8:56 AM, Ferenc Kovacs wrote: > >> On Thu, Nov 5, 2015 at 2:26 PM, Andreas Heigl wrote: >> >> > Am 05.11.15 um 14:14 schrieb Ferenc Kovacs: >> > [...] >> > > I

Re: [PHP-DEV] [RFC][DISCUSSION] Trailing commas in all list syntax

2015-11-05 Thread Marcio Almada
Hi, 2015-11-03 16:22 GMT-03:00 Sammy Kaye Powers : > Hey internals! > > The RFC to allow trailing commas to function calls & declarations has been > withdrawn in favor of the a RFC that broadens the scope to all list syntax. > > https://wiki.php.net/rfc/list-syntax-trailing-commas

Re: [PHP-DEV] Re: Small regression in PHP-LDAP

2015-11-05 Thread Ferenc Kovacs
On Thu, Nov 5, 2015 at 9:53 PM, Adam Howard wrote: > I don't think it is possible to make everyone happy all the time. I think > this should be kept for a user code fix. > > please don't top post on the php.net mailing lists. on one hand this change doesn't really make

[PHP-DEV] PHP 7 : Cannot use stream wrappers during MINIT

2015-11-05 Thread François Laupretre
Hi, First, I don't know if this must be considered as a bug, because a lot of features are not available during MINIT but it seems quite inconsistent. I precise I'm using the 7.x master branch (I don't know if it works on 5.x or not). I am writing an extension where I need to read a file

[PHP-DEV] [Patch] Extension tests fail on dynamic ext dependency

2015-11-05 Thread François Laupretre
Hi, could someone validate and, if considered OK, merge the following PR: https://github.com/php/php-src/pull/1602 This is a follow-up to a previous patch by Derick to enable testing extensions with a dependency to another (dynamic) extension. More details in the corresponding bug report :

Re: [PHP-DEV] Re: Small regression in PHP-LDAP

2015-11-05 Thread Adam Howard
I don't think it is possible to make everyone happy all the time. I think this should be kept for a user code fix. On Thu, Nov 5, 2015 at 2:37 PM, Ferenc Kovacs wrote: > On Thu, Nov 5, 2015 at 5:38 PM, Bishop Bettini wrote: > > > On Thu, Nov 5, 2015 at 8:56

[PHP-DEV] Re: Friend class/function

2015-11-05 Thread Stephen Coakley
On 11/01/2015 10:04 AM, georges wrote: ​Hi php internals, I recently discovered ​the "friendship concept" in c++ and i really love the concept. And i wonder if the php internals would be interested to implements it in the next 7.x major version. ​The concept is simple: It would allow

Re: [PHP-DEV] [VOTE] Void Return Type RFC

2015-11-05 Thread Stephen Coakley
On 10/29/2015 07:44 AM, Dan Ackroyd wrote: Hi Internals, Stanislav Malyshev wrote: every PHP function actually returns something (at least null). So this type would not actually be right and would not reflect what actually is happening. Well obviously we would need to have a followup RFC to

Re: [PHP-DEV] Null bytes in anonymous class names

2015-11-05 Thread Leigh
On 5 November 2015 at 14:21, Niklas Keller wrote: > Hello, > > I discovered today that anonymous class names contain a null byte right > after "class@anonymous". I don't think class names should contain > non-printable characters. > > How about removing that null byte? > >

Re: [PHP-DEV] Null bytes in anonymous class names

2015-11-05 Thread Rowan Collins
On 05/11/2015 14:21, Niklas Keller wrote: Hello, I discovered today that anonymous class names contain a null byte right after "class@anonymous". I don't think class names should contain non-printable characters. How about removing that null byte? https://3v4l.org/QUKpV

Re: [PHP-DEV] Null bytes in anonymous class names

2015-11-05 Thread Leigh
On 5 November 2015 at 14:59, Rowan Collins wrote: > > PHP uses null bytes quite a lot to produce deliberately illegal > identifiers. For instance the old eval-like create_function() [e.g. > https://3v4l.org/hqHjh] and the serialization of private members [e.g. >

Re: [PHP-DEV] Re: Small regression in PHP-LDAP

2015-11-05 Thread Ferenc Kovacs
On Thu, Nov 5, 2015 at 2:26 PM, Andreas Heigl wrote: > Am 05.11.15 um 14:14 schrieb Ferenc Kovacs: > [...] > > I would keep the old behavior for 5.6, even if that was unintended nobody > > complained about it(so removing it isn't a bugfix per se), so I see no > > reason to

Re: [PHP-DEV] Re: Small regression in PHP-LDAP

2015-11-05 Thread Andreas Heigl
Am 05.11.15 um 14:14 schrieb Ferenc Kovacs: [...] > I would keep the old behavior for 5.6, even if that was unintended nobody > complained about it(so removing it isn't a bugfix per se), so I see no > reason to break userland code working before in a micro version. > for PHP-7.0 we can remove the