Re: [PHP-DEV] Lift ICU requirements

2018-09-04 Thread Andrey Andreev
Hi, On Tue, Sep 4, 2018 at 7:22 PM, Sara Golemon wrote: > On Tue, Sep 4, 2018 at 6:44 AM, Andrey Andreev wrote: >> On Mon, Sep 3, 2018 at 6:13 PM, Christoph M. Becker >> wrote: >>> On 03.09.2018 at 17:02, Andrey Andreev wrote: >>> I raised this issue back in January[1], but then got

[PHP-DEV] Mysterious (to me) Xdebug issue with PHP 7.3

2018-09-04 Thread Derick Rethans
Hi, I'm finalizing Xdebug support for PHP 7.3, and although I have fixed many things, there is one thing that is (currently) eluding me. The branch I'm working on is https://github.com/derickr/xdebug/tree/PHP-7.3-support With Xdebug (just) loaded, the following script: $ cat

Re: [PHP-DEV] Lift ICU requirements

2018-09-04 Thread Sara Golemon
On Tue, Sep 4, 2018 at 6:44 AM, Andrey Andreev wrote: > On Mon, Sep 3, 2018 at 6:13 PM, Christoph M. Becker wrote: >> On 03.09.2018 at 17:02, Andrey Andreev wrote: >> >>> I raised this issue back in January[1], but then got distracted and >>> completely forgot about it ... sorry about that. >>

Re: [PHP-DEV] RFC Proposal: Make the hash extension always available

2018-09-04 Thread Sara Golemon
On Tue, Sep 4, 2018 at 4:11 AM, Kalle Sommer Nielsen wrote: > I just posted an RFC and set it up for discussion[1], this proposes to > make the ext/hash extension always enabled, similar to that for date, > spl & pcre. > > Comments are welcome. I intend to start voting in 2-3 weeks time, > should

[PHP-DEV] ICONV_SUPPORTS_ERRNO

2018-09-04 Thread Christoph M. Becker
Hi! ext/iconv is full of nasty fallbacks for !ICONV_SUPPORTS_ERRNO. I wonder whether there are (still) known iconv implementations which do not support errno, and even if there are some, whether we should stop supporting these. Thoughts? -- Christoph M. Becker -- PHP Internals - PHP Runtime

Re: [PHP-DEV] Lift ICU requirements

2018-09-04 Thread Christoph M. Becker
On 04.09.2018 at 13:44, Andrey Andreev wrote: > On Mon, Sep 3, 2018 at 6:13 PM, Christoph M. Becker wrote: > >> On 03.09.2018 at 17:02, Andrey Andreev wrote: >> >>> I raised this issue back in January[1], but then got distracted and >>> completely forgot about it ... sorry about that. >> >>

Re: [PHP-DEV] Lift ICU requirements

2018-09-04 Thread Andrey Andreev
Hi, On Mon, Sep 3, 2018 at 6:13 PM, Christoph M. Becker wrote: > On 03.09.2018 at 17:02, Andrey Andreev wrote: > >> I raised this issue back in January[1], but then got distracted and >> completely forgot about it ... sorry about that. > > Thanks for having raised the issue. :) > >> Would the

[PHP-DEV] Re: RFC Proposal: Make the hash extension always available

2018-09-04 Thread Kalle Sommer Nielsen
Den tir. 4. sep. 2018 kl. 12.20 skrev Christoph M. Becker : > That appears to be sensible. Anyhow, *if* we do this, we also should > move the MD5, SHA1 and CRC32 code from ext/standard to ext/hash (MD5 and > SHA1 is currently dead code in ext/hash, and the CRC32 implementation > seems to be

[PHP-DEV] Re: RFC Proposal: Make the hash extension always available

2018-09-04 Thread Christoph M. Becker
On 04.09.2018 at 11:11, Kalle Sommer Nielsen wrote: > I just posted an RFC and set it up for discussion[1], this proposes to > make the ext/hash extension always enabled, similar to that for date, > spl & pcre. > > Comments are welcome. I intend to start voting in 2-3 weeks time, > should there

[PHP-DEV] RFC Proposal: Make the hash extension always available

2018-09-04 Thread Kalle Sommer Nielsen
Gday fellow hackers I just posted an RFC and set it up for discussion[1], this proposes to make the ext/hash extension always enabled, similar to that for date, spl & pcre. Comments are welcome. I intend to start voting in 2-3 weeks time, should there be no critical issues in regards to this