Re: [PHP-DEV] gcov cron/tags.inc

2017-07-18 Thread Nuno Lopes
Done; thanks for the ping! cc'ing Nuno, our GCOV guy! 2017-07-18 21:32 GMT+02:00 Sara Golemon : Looks like I don't have karma to add PHP_7_2 to gcov runs, could someone do that for me? Thanks. -- regards, Kalle Sommer Nielsen ka...@php.net -- PHP Internals - PHP Runtime Development Maili

[PHP-DEV] PHP HEAD and gcov.php.net

2014-08-31 Thread Nuno Lopes
Hi, I've disabled the following extensions from the build of PHP_HEAD at the gcov.php.net server: - oci8 - pdo_oci - sybase_ct - litespeed SAPI These extensions don't seem to have been upgraded to the new APIs. Therefore I've disabled them so that we can test the other (majority) extensions.

[PHP-DEV] Re: LCOV 1.11

2014-07-11 Thread Nuno Lopes
Yes, please! Just make sure the old versions are blacklisted (anything older than the first white-listed version). Thanks, Nuno - Original Message - Hi! LTP's lcov 1.11 seems to work fine here. Can we make this a blacklist instead of an annoying whitelist, too, just like the bison c

Re: [PHP-DEV] Concurrency support for run-tests

2014-07-09 Thread Nuno Lopes
On Mon, Jul 7, 2014 at 6:53 AM, Michael Wallner wrote: I also have a patch for run-tests sitting around for quite some time, which adds concurrent test execution support. I already fixed a lot of non re-entrant tests in the past, but there might still be quite some of them. HHVM uses PHP's

[PHP-DEV] Re: [PHP-QA] Parallel run-tests

2012-10-14 Thread Nuno Lopes
A] Parallel run-tests On 21/05/2012 06:45, Nuno Lopes wrote: Hi Zoe, Thanks for undertaking this project! I just have a few concerns about this: - The speedup seems a bit low to me. Maybe with a higher number of extensions enabled it will improve?.. I don't think it will improve with a higher

[PHP-DEV] Re: [PHP-QA] Parallel run-tests

2012-05-21 Thread Nuno Lopes
Alright, thanks for the reply! I'll try to have a look at the code and give it a try next weekend. Nuno -Original Message- From: zoe slattery Sent: Monday, May 21, 2012 8:26 AM Subject: Re: [PHP-QA] Parallel run-tests On 21/05/2012 06:45, Nuno Lopes wrote: Hi Zoe, Thank

[PHP-DEV] Re: [PHP-QA] Parallel run-tests

2012-05-20 Thread Nuno Lopes
Hi Zoe, Thanks for undertaking this project! I just have a few concerns about this: - The speedup seems a bit low to me. Maybe with a higher number of extensions enabled it will improve?.. - Is there any developer documentation available? If I wanted to do a change or a bug fix today, how cou

[PHP-DEV] Re: [PHP-QA] run-tests.php - GZIP_POST and DEFLATE_POST question

2012-05-08 Thread Nuno Lopes
I have no clue what those 2 sections do either. But if the number of affected tests is small, then feel free to patch the tests and/or run-tests.php. Nuno -Original Message- From: zoe slattery Sent: Tuesday, May 08, 2012 2:06 PM Subject: [PHP-QA] run-tests.php - GZIP_POST and DEFLAT

[PHP-DEV] Re: [PHP-QA] running tests in parallel?

2012-05-03 Thread Nuno Lopes
It's very important! Take a look at http://gcov.php.net A single build takes almost 2 days with most extensions enabled plus valgrind testing. So, yes, parallel testing would be highly appreciated (but do not forget my initial requirements, such as e.g. mysql and mysqli tests cannot run at the

[PHP-DEV] new gcov.php.net machine is up

2011-07-23 Thread Nuno Lopes
Hi, Thanks to Nexcess, we have a new wonderful machine for http://gcov.php.net up and running. This new machine is running linux 64 bits, so expect a few differences in the test results. I believe most things are ported from the old machine, including all daemon's configurations. I fired an

Re: [PHP-DEV] is gcov.php.net still useful?

2011-07-19 Thread Nuno Lopes
The gcov.php.net machine is about to die. Nexcess (the owner) already offered us the possibility to get a replacement. However, before accepting their offer I would like to know if someone is still using the gcov.php.net service. Is it still useful for anyone? I think test coverage, valgrind and

[PHP-DEV] is gcov.php.net still useful?

2011-07-18 Thread Nuno Lopes
Hi, The gcov.php.net machine is about to die. Nexcess (the owner) already offered us the possibility to get a replacement. However, before accepting their offer I would like to know if someone is still using the gcov.php.net service. Is it still useful for anyone? A new machine means installi

Re: [PHP-DEV] A patch for HEAD

2009-07-19 Thread Nuno Lopes
uch better than allocating a few extra pointers or calling perealloc() a few times?), the fix for it isn't trivial, so I left it alone. The updated patch is (again) posted at: http://darkrainfall.org/php-5.3-shellbypass.patch On Jul 15, 2009, at 4:20 PM, Nuno Lopes wrote: Hi, So the p

Re: [PHP-DEV] A patch for HEAD

2009-07-15 Thread Nuno Lopes
Hi, So the patch looks generally good. Here are some minor comments about it: - I believe _php_array_to_argv() doesn't need TSRMLS_DC. If that's the case, please remove it. - in _php_array_to_argv() you modify the input array destructively (when calling convert_to_string_ex). You should not mo

Re: [PHP-DEV] A patch for HEAD

2009-07-08 Thread Nuno Lopes
The idea is great. In fact this was in my todo list for php 5.3.. Please give me a few more days to review the patch. Nuno P.S.: you can add on more point to your list: you get to know the PID of the exec'ed process instead of the PID of the shell. - Original Message - I've just finis

Re: [PHP-DEV] PHP LLVM JIT-Compiler

2009-07-07 Thread Nuno Lopes
Hi, So there is some information about the project in the CVS repository. Let me first say that the project is not mature enough to run your favorite app. It is capable of executing some small tests, but not complex apps. You can use either clang or llvm-gcc to compile the stuff, although the la

Re: [PHP-DEV] Re: PHC Dataflow

2009-06-25 Thread Nuno Lopes
On Thu, Jun 25, 2009 at 9:08 PM, Nuno Lopes wrote: So we do whole program analysis. We start at the first statement in global scope, model it, then add all its successor to a queue, and keep modelling until we get to the end of the program. When we get to a method call, we start modelling the

Re: [PHP-DEV] Re: PHC Dataflow

2009-06-25 Thread Nuno Lopes
So we do whole program analysis. We start at the first statement in global scope, model it, then add all its successor to a queue, and keep modelling until we get to the end of the program. When we get to a method call, we start modelling the execution of the method. At the end of the method, we p

Re: [PHP-DEV] Last steps towards 5.3.0

2009-06-11 Thread Nuno Lopes
On Wed, Jun 10, 2009 at 9:38 PM, Nuno Lopes wrote: PS: If someone wants to give a hand to find the regression... I can explain how to reproduce. The easiest way is to use a tool to help reducing the test case automatically. I don't know about any specific tool for reducing PHP files, b

Re: [PHP-DEV] Standards for developers

2009-06-11 Thread Nuno Lopes
Bottom line - rather than reinventing the wheel - is anybody else actually using Eclipse and has a simple set-up guide for how they have configured things? Ideally for windows, but I'd like to pull this up on the Linux boxes as well. If I'm going to have to start working on extension code it's

Re: [PHP-DEV] Last steps towards 5.3.0

2009-06-10 Thread Nuno Lopes
PS: If someone wants to give a hand to find the regression... I can explain how to reproduce. The easiest way is to use a tool to help reducing the test case automatically. I don't know about any specific tool for reducing PHP files, but in the past I've used delta (http://delta.tigris.org/),

Re: [PHP-DEV] RE: Optimizer discussion

2009-06-05 Thread Nuno Lopes
Hi, I'm happy there's some interest in a PHP optimizer :) I agree with Paul that PECL's optimizer duplicates way too much stuff from the Zend engine, which is not practic nor maintainable. (compare for example with the simple constant folder I implemented some years ago: http://web.ist.utl.pt/

Re: [PHP-DEV] [PATCH] Scanner "diet" with fixes, etc.

2009-04-30 Thread Nuno Lopes
The patch looks generally ok. However I'll need a few more days to review it carefully and throughly. (you can merge it in the meantime if you want). I'm just slighty concern with the amount of parsing we are now doing by hand, and with the possible (local) security bugs we might be introduci

Re: [PHP-DEV] [PATCH] Scanner "diet" with fixes, etc.

2009-04-30 Thread Nuno Lopes
The patch looks generally ok. However I'll need a few more days to review it carefully and throughly. (you can merge it in the meantime if you want). I'm just slighty concern with the amount of parsing we are now doing by hand, and with the possible (local) security bugs we might be introducing..

Re: [PHP-DEV] GCC 4.4.0

2009-04-25 Thread Nuno Lopes
Nuno Lopes schrieb: Do you where it's crashing so that I can take a look? http://pastebin.com/m78a01116 This particular problem should be fixed now. Let me know if PHP still crashes for you. Nuno -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit:

Re: [PHP-DEV] CVS Account Request: hjalle

2009-04-25 Thread Nuno Lopes
He's the SoC student working on the bechmarking project. Can someone please approve his account and give him karma to 'php-benchmarks'. Thanks, Nuno - Original Message - From: "Alexander Hjalmarsson" To: Sent: Saturday, April 25, 2009 11:38 AM Subject: [PHP-DEV] CVS Account Reques

Re: [PHP-DEV] GCC 4.4.0

2009-04-25 Thread Nuno Lopes
Scott MacVicar schrieb: Can you set your cflags to -fno-strict-aliasing and try again. This resolved the issue with the previous report. Adding -fno-strict-aliasing to CFLAGS works around the issue, yes. Wow, this is terrible news, as -fno-strict-aliasing usually degrades performance by a co

Re: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_3) / zend_language_scanner.c zend_language_scanner.l

2009-04-18 Thread Nuno Lopes
The original code actually can be found inside php_cli.c and there it only checked the 1st line for '#'. if you create a file such as: #1 #2 The issue here is that the old code only looked at the main script, now included files ar affected, too. So either we check in the scanner whether this is

Re: [PHP-DEV] CVS Account Request: olafurw

2009-04-07 Thread Nuno Lopes
vouched! He will be contributing to the benchmark creation project. Can someone please take care of his account + karma for the 'php-benchmarks' module? Done Thank you Derick! Nuno -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] CVS Account Request: olafurw

2009-04-07 Thread Nuno Lopes
vouched! He will be contributing to the benchmark creation project. Can someone please take care of his account + karma for the 'php-benchmarks' module? Thanks, Nuno - Original Message - Contributing benchmarks -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, v

Re: [PHP-DEV] RFC: Removing the Zend API

2009-03-31 Thread Nuno Lopes
Hi Paul et all, I fully understand (and even share) your motivations and goals. However it seems to me that describing an extension in PHP will lead to loss of performance, as you cannot capture certain C features in PHP. For example, there are some internal functions that rely on pointer arit

[PHP-DEV] Re: [PHP-QA] [RFC] Better benchmarks for PHP

2009-02-20 Thread Nuno Lopes
On Sat, 2009-02-14 at 23:06 +, Nuno Lopes wrote: Currently PHP's benchmarks are very poor. The PHP interpreter is only timed against bench.php. Sadly, this doesn't make use of the majority of PHP's IS that something where some GSoC student might help? If yes, please

[PHP-DEV] [RFC] Better benchmarks for PHP

2009-02-14 Thread Nuno Lopes
nchmarks to PHP. Based on that experience, we can go about the larger and more difficult task of porting some web-apps to make representative benchmarks. Comments, criticisms and volunteers especially welcome, Nuno Lopes & Paul Biggar -- PHP Internals - PHP Runtime Development Mailin

Re: [PHP-DEV] PCRE symbol visibility bug

2008-12-10 Thread Nuno Lopes
I've commited a fix. I didn't patch the pcre_internal.h file directly, otherwise the patch would be reverted on the next upgrade of the pcre lib. Thanks, Nuno - Original Message - From: "shire" <[EMAIL PROTECTED]> To: "PHP Internals List" Sent: Tuesday, December 09, 2008 10:09 PM Sub

Re: [PHP-DEV] turn off gcov for php 4.4?

2008-10-12 Thread Nuno Lopes
I'll drop it soon from gcov. Nuno Sounds good, we should also stop building snapshots and change the other branches to be built more often. Scott On 12 Oct 2008, at 07:59, Gregory Beaver <[EMAIL PROTECTED]> wrote: Hi all, Isn't it time to retire PHP 4.4 in gcov.php.net? It's just wasted

Re: [PHP-DEV] Howto build statically linked PHP CGI (without shared libs)

2008-09-10 Thread Nuno Lopes
> statifier'd version of the CGI works fine.. but we're looking a better > method to directly built the CGI. you can always use llvm and compile all libraries you need to bitcode and then link them with PHP. that way will enable more optimizations and will also reduce the binary size, since llvm w

Re: [PHP-DEV] TracingPHP

2008-09-02 Thread Nuno Lopes
On Mon Aug 25 06:28 PM, steve wrote: Has anyone had success compiling PHP with LLVM? I haven't tried it, here is a good summary: http://llvm.org/devmtg/2008-08/Lopes_PHP-JIT-InTwoDays.pdf In short, it is 'slower' but that seems to be without any caching of the "bytecode" So yes, we were abl

Re: [PHP-DEV] pspell tweak.

2008-08-13 Thread Nuno Lopes
C++ is a superset of C thus any C code can be complied as C++ as long as it doesn't use any C++ reserved words. That is not true at all, although it's a common misconception. Just try the following in C and in C++: printf("sizeof('x') == %d\n", (int)sizeof('x')); (hint: they will give you diff

Re: [PHP-DEV] pspell tweak.

2008-08-13 Thread Nuno Lopes
Antony Dovgal wrote: On 13.08.2008 01:31, Phil Oleson wrote: Thus the diff -u I sent in.. which resolves the above compiler failure with g++. Committed, thanks! Btw, how and why did you manage to get g++ compiling plain C code? umm.. how? cd ext/pspell /usr/local/php5/bin/phpize env CC=g++

Re: [PHP-DEV] PCRE and recursion: NO_RECURSE flag

2008-08-07 Thread Nuno Lopes
No! Last time I benchmark it, it has about 100x slower, so I don't think so.. If you need to match large amounts of data, just increase the stack size. ulimit is your friend :) Nuno - Original Message - From: "Arnaud Le Blanc" <[EMAIL PROTECTED]> To: Sent: Thursday, August 07, 200

Re: [PHP-DEV] [Fwd: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_strtod.c]

2008-07-28 Thread Nuno Lopes
I already expressed my opinion.. If you know what's the buggy gcc version, just fail at configure time if it's present. Nuno On Mon, Jul 28, 2008 at 20:38, Stanislav Malyshev <[EMAIL PROTECTED]> wrote: > Hi! > > I wanted to ask people here about this patch. See history in > http://bugs.php.net/b

Re: [PHP-DEV] New optimization idea; was: No runtime fetching of built-in global constants

2008-07-27 Thread Nuno Lopes
I'm not Matt, but I'll try to answer :) Actually the new re2c scanner already handles the shebang thing, so I think you can safely remove the explicit support for it in CGI. We had to had that because CLI doesn't explicitly support the shebang line. Nuno P.S.: now it makes sense why we never fou

Re: [PHP-DEV] [PATCH] Some string changes/optimizations

2008-07-10 Thread Nuno Lopes
Ah, nowdocs is php >= 5.3 only. it has been such a long time since last release that I didn't even remember that.. So, forget my previous comment. Nuno - Original Message - There hasn't been an official release with the NOWDOCS token though. Scott Nuno Lopes wrote: Patc

Re: [PHP-DEV] [PATCH] Some string changes/optimizations

2008-07-10 Thread Nuno Lopes
; <[EMAIL PROTECTED]> To: Cc: "Dmitry Stogov" <[EMAIL PROTECTED]>; "Nuno Lopes" <[EMAIL PROTECTED]> Sent: Thursday, July 10, 2008 1:45 PM Subject: Re: [PHP-DEV] [PATCH] Some string changes/optimizations Hi all, I had been meaning to update this patch for a w

Re: [PHP-DEV] re2c issues? (Was Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_3) / zend_language_scanner.l)

2008-07-09 Thread Nuno Lopes
I didn't test it, but yeah that should fix the # problem. :-) BTW, I also had other ideas about checking for , etc. tags in the inline HTML scanning part, so the largest chunk of HTML is always grabbed (I'll send the patch in the future; didn't modify anything yet, and it's not related to the s

Re: [PHP-DEV] Algorithm Optimizations - string search

2008-06-20 Thread Nuno Lopes
Hi, Both patches seem ok to me. Please ask for a CVS account and prepare yourself to commit (when your mentor says so) :) In the second patch maybe you could use zend_memrchr() as well, but you should get the same results. Also I think that bundling the backwards KMP would be a nice addition.

Re: [PHP-DEV] [PATCH] make it possible to skip very slow tests

2008-06-19 Thread Nuno Lopes
Yes, it is. Check the system_with_timeout() function in the run-tests.php script. There you've the timeout hardcoded ('$leak_check ? 300 : 60'). You would just need to make it configurable by some environment var. I already tried hard-coding both tv_sec and tv_usec to 0 and it makes no differe

Re: [PHP-DEV] [PATCH] make it possible to skip very slow tests

2008-06-19 Thread Nuno Lopes
I'd prefer a run-tests.php option that sets the timeout limit in seconds. Nice idea, but I'm not sure it's achievable under CLI. Yes, it is. Check the system_with_timeout() function in the run-tests.php script. There you've the timeout hardcoded ('$leak_check ? 300 : 60'). You would just nee

Re: [PHP-DEV] Algorithm Optimizations - string search

2008-06-17 Thread Nuno Lopes
Hi, Sorry for taking so long to answer, but I'm trying to catch up last stuff. It's known that usually to optimize things for longer inputs you usually end up making things for short inputs worst. So IMHO, I think you should have the len==1 optimization and then use the KMP algorithm. Your impl

Re: [PHP-DEV] extensions status, to move to pecl or to drop

2008-06-17 Thread Nuno Lopes
>> What would rock is to have it supported by gcov (by us or >> somewhere else with a public report), would it be possible? > > How can I get this done? I'm adding Nuno to the loop, he is the one leading the gcov initiative and will surely explain the setup in a better way than me :) I can add

Re: [PHP-DEV] [PATCH] Executor improvements

2008-06-10 Thread Nuno Lopes
Nuno Lopes wrote: Out of curiosity, what's the slowdown without fastcall? fastcall calling convention assumes passing parameters in registers instead of pushing them on stack. yeah, I know. I was asking what's the slowdown that this patch introduces without the fastcall bits.

Re: [PHP-DEV] [PATCH] Executor improvements

2008-06-10 Thread Nuno Lopes
Out of curiosity, what's the slowdown without fastcall? Despite the potential slowdown, I still think this is the way to go. The engine isn't supposed to crash! Nuno - Original Message - From: "Dmitry Stogov" <[EMAIL PROTECTED]> To: "PHP Internals List" Cc: "Andi Gutmans" <[EMAIL PRO

Re: [PHP-DEV] Algorithm Optimizations - string search

2008-06-09 Thread Nuno Lopes
Hi, So some comments: - you have some problems with the indentation. We only use tabs, so please stick to that. Also, there are some lines that are not indented correctly - Have you considered the Boyer-Moore algorithm? I think it's a little faster than KMP (take a look at e.g. http://www.cs.u

Re: [PHP-DEV] [HEADS UP] pecl/phar is now ext/phar

2008-05-12 Thread Nuno Lopes
It's time for helly's birthday present from me (and indirectly, Derick, who did the cp -r) :). Happy Birthday! I suspect there may need to be some changes at gcov.php.net to keep things running smoothly, so this is a heads up message. OK, done. Nuno -- PHP Internals - PHP Runtime Developm

Re: [PHP-DEV] [PATCH] Some string changes/optimizations

2008-05-05 Thread Nuno Lopes
Thanks Matt for the nice work :) Also removed the ST_START_[HEREDOC|NOWDOC] states in the scanner, by doing their work (to catch immediate ending label) in the initial heredoc rule. This one was in my todo list as well. I think there might be other places where a similar optimization can be

Re: [PHP-DEV] [PATCH] Scanner fixes and tweaks

2008-04-10 Thread Nuno Lopes
Patch applied, thanks! I haven't merged my other patch to HEAD yet, but I'll do so ASAP. Thanks, Nuno - Original Message - Hi Scott, I noticed that Nuno changed yyless() to be like flex after your commit (not in HEAD? I considered that, but figured you guys wanted it different :-))

Re: [PHP-DEV] Small test case fixes / observations (php-5.2.6_rc4)

2008-04-10 Thread Nuno Lopes
Commited, thanks! Nuno On 2008-04-06 23:44, Christian Hoffmann wrote: > Heya, > > while building and testing a minimal version of PHP and as such > disabling the session extension, I discovered that > ext/standard/tests/general_functions/bug44394_2.phpt fails without the > session extension bei

Re: [PHP-DEV] new version of check_parameters.php

2008-03-12 Thread Nuno Lopes
Yes, i understand. It was interesting for me - how i can decrease false positive and others by improvings on current script. If there will be not GSoC participant for this project, possibly i can do it. OK, great! :) Also base questions, which will be asked in any case, are still alive:

Re: [PHP-DEV] new version of check_parameters.php

2008-03-11 Thread Nuno Lopes
Hi, Thanks for working on this. However I don't think more effort should be wasted with this script. It's a bogus approach to the problem and it will always generate many false-positives (disclaimer: I'm the author of the original script and it was like a POC). Thus my idea is to move along to

Re: [PHP-DEV] substr & substr_compare fix

2008-02-12 Thread Nuno Lopes
I like the patches. If noone complains please go ahead and commit them. Thanks, Nuno - Original Message - From: "Etienne Kneuss" <[EMAIL PROTECTED]> To: "php-dev" Sent: Monday, February 11, 2008 6:07 PM Subject: [PHP-DEV] substr & substr_compare fix Hi, please consider the follow

Re: [PHP-DEV] Segmented argument_stack

2008-01-23 Thread Nuno Lopes
As a side note, I think the following code could be optimized: Probably it could, but note that the code not just moves the stack pointer, but also destroys arguments there (zval_ptr_dtor). + while (zend_vm_stack_top(TSRMLS_C) != stack_frame) { + zval *stack_zval_p = zend_vm_stack_pop(TSRMLS

Re: [PHP-DEV] Segmented argument_stack

2008-01-21 Thread Nuno Lopes
Hi Dmitry, The patch looks fine. Although it wastes a bit more memory than the current implementation, I think it's ok. It also has some memory fragmentation, which shouldn't be an issue (we don't have functions with 100 arguments :P). As a side note, I think the following code could be optim

Re: [PHP-DEV] [PATCH] date/timelib: use system timezone database

2008-01-09 Thread Nuno Lopes
Definitely a great idea, since most linux distributions already bundle this information and update it frequently. BTW, your implementation seems to require some security checks for timezone names like "../../../etc/passwd". Nuno - Original Message - From: "Joe Orton" <[EMAIL PROTECTE

Re: [PHP-DEV] constant folding optimization

2007-12-07 Thread Nuno Lopes
Abstaract Syntax Tree, that should be evaluated at run-time > by > zval_update_constant(). > Thanks. Dmitry. >> -Original Message- >> From: Nuno Lopes [mailto:[EMAIL PROTECTED] >> Sent: Saturday, September 08, 2007 10:50 PM >> To: Stanislav Malyshev >> Cc: i

Re: [PHP-DEV] web applications architectures comparison

2007-11-21 Thread Nuno Lopes
Hi, I was assigned a class work in the university to compare web applications architectures, mainly PHP vs Java+Hibernate+Struts/Stripes. I'll need to provide some benchmarks for some typical web apps. Well, I'm a bit afraid that Java may win, because of the usage of Hibernate, which caches sql

[PHP-DEV] web applications architectures comparison

2007-11-21 Thread Nuno Lopes
Hi, I was assigned a class work in the university to compare web applications architectures, mainly PHP vs Java+Hibernate+Struts/Stripes. I'll need to provide some benchmarks for some typical web apps. Well, I'm a bit afraid that Java may win, because of the usage of Hibernate, which caches sql s

Re: [PHP-DEV] Tainted Mode Decision

2007-11-18 Thread Nuno Lopes
The other difference is that Venema's implementation assumes that functions exist that make a variable safe for usage in SQL, HTML, ... When such a function is used the variable is marked as not tainted... In the previous mail I showed examples why this is not secure. GRASP on the other hand hook

Re: [PHP-DEV] Tainted Mode Decision

2007-11-18 Thread Nuno Lopes
I just wanted to ask if there was ever a decision made that said tainted mode will go into PHP mainstream. no, there was no decision yet. It is no secret that I don't like the idea of a taint mode in PHP because it cannot be made secure and fast at the same time. /me too. Although I can't a

Re: [PHP-DEV] pdo_firebird: "RETURNING" queries/closeCursor (#43246/43271)

2007-11-14 Thread Nuno Lopes
Hello Hans-Peter, not that I am aware of. EXTENSIONS file doesn't list any and Ard who is listed in CREDITS didn't show up in the last couple of months. Read this: php.net/cvs-php.php and be also prepared to be asked to take care of firebird installation on http://gcov.php.net :-) Ah, sure! La

Re: [PHP-DEV] preg_match and shared libpcre3 bug

2007-11-10 Thread Nuno Lopes
With installing a security update for the pcre3 library on Debian (http://lists.debian.org/debian-security-announce/debian-security-announ ce-2007/msg00177.html), preg_match('|^\(|', 'xxx') suddenly returns 1 instead of 0 using PHP 5.1.6. the correct value is 0, yes. The thing is - I have bui

Re: [PHP-DEV] Preliminary PHP taint support available

2007-11-02 Thread Nuno Lopes
Hi, It sounds cool, indeed. The obvious question now is: how it performs with real-world applications? Have you been able to identify security bugs (either new or already known)? I don't have time to perform these tests myself, but I would love to see some results. Regards, Nuno - Origi

Re: [PHP-DEV] php 5.2.4 test results reference

2007-10-18 Thread Nuno Lopes
I know, I know.. It is on my TODO list for a loong time. I have the program on my head, I just need to get some time to sit and code it.. BTW: Jean, would Sun be interested in setting up a build machine to run the PHP test suite and post the results to a central build DB? Nuno - Origina

Re: [PHP-DEV] My musings on... a Solaris test platform

2007-10-17 Thread Nuno Lopes
It would be interesting, yes. My university has been discontinuing the Solaris servers and now I only have access to an ancient Solaris 7 server. Even more interesting would be to get your patches to fix those bugs :) Thanks, Nuno - Original Message - From: "Rob Thompson" <[EMAIL PROT

Re: [PHP-DEV] php 5.2.4 test results reference

2007-10-17 Thread Nuno Lopes
we would like to know whether at php org level there are any test results available / published / shared per OS (like Solaris, RH in particular) Not grouped, but we do have all the test results here: http://news.php.net/php.qa In addition to what Derick said, there is a "reference" build and t

Re: [PHP-DEV] PHP 5.3 todo wiki update

2007-10-05 Thread Nuno Lopes
No, no and no! The gcc 4 -fvisibility patch wasn't rejected. It's a no-op and although it is only useful for gcc 4 users, it brings many benefits for them! So please keep that in the PHP 5.3 TODO. Nuno - Original Message - Hi, I updated the 5.3 todo list [1] yesterday evening. I al

Re: [PHP-DEV] VS 2005 Support for 5.3?

2007-10-03 Thread Nuno Lopes
I already use 2k3 to compile my binaries or to develop, it works pretty well. The 2k5 brings more change and require a couple of important changes in our build (like the manifest support or what other describe in this thread). Uhm I use VS 2005 to build PHP (vanila) for quite some time and it wo

Re: [PHP-DEV] Re: cvs: php-src(PHP_5_2) / run-tests.php /ext/bz2/tests 005.phpt /ext/standard/tests/general_functions phpcredits.phpt phpinfo.phpt /ext/standard/tests/strings sha1.phpt /ext/zlib/t

2007-09-28 Thread Nuno Lopes
nlopess Fri Sep 14 15:28:04 2007 UTC Log: changes to run-tests.php: - change %s to %a - make %s = [^\r\n]+ - fix tests accordingly I think this is a very bad change. While tests of bundled extensions can be updated accordingly, pecl extension tests have no way to be version agnostic

Re: [PHP-DEV] RFC: mark functions as const for possible optimizations

2007-09-17 Thread Nuno Lopes
I had a quick question about this. When would strlen('abcd') be execuated? Say I had the code: $a = false; // This set by external input if ( $a ) $b = strlen('abcd'); Would the optimizer work out the length before the program starts to run? Or would the optimizer wait until it knows the strl

Re: [PHP-DEV] Re: RFC: mark functions as const for possibleoptimizations

2007-09-17 Thread Nuno Lopes
On Sun, 2007-09-16 at 20:02 +0100, Nuno Lopes wrote: > >My proposal is the following: > >some functions when fed with constant arguments always return a > >constant > >value, too. e.g.: > >strlen('abcd') === 4. > > I like the general idea. > &

Re: [PHP-DEV] Re: RFC: mark functions as const for possible optimizations

2007-09-16 Thread Nuno Lopes
>My proposal is the following: >some functions when fed with constant arguments always return a constant >value, too. e.g.: >strlen('abcd') === 4. I like the general idea. Would there be some caveats with stuff like this if it is possible to change the charset at runtime? I guess it is importan

Re: [PHP-DEV] PHP 5.3 Suggested Feature List (Summary)

2007-09-16 Thread Nuno Lopes
Mmm... but that means dictating which features can or can't go into an extension or a specific build system purely on the level of outside interest in them. Steph, isn't the goal of "core" to contain things that are of common use and are not for niche uses and wouldn't lack of interest impl

Re: [PHP-DEV] RFC: mark functions as const for possible optimizations

2007-09-14 Thread Nuno Lopes
Nuno Lopes wrote: > My proposal is the following: > some functions when fed with constant arguments always return a constant > value, too. e.g.: > strlen('abcd') === 4. wouldn't that be called "deterministic" and not "const"? yeah, exactly. I w

[PHP-DEV] RFC: mark functions as const for possible optimizations

2007-09-14 Thread Nuno Lopes
Hi, Following my last post on bytecode optimization (http://news.php.net/php.internals/32113), I would like to discuss a few more things. The patch in that e-mail allowed the engine itself to do transformations like, e.g.: $a = 1*2*3*4*5+1-0; --> $a = 121; However the patch is now a bit d

Re: [PHP-DEV] Re: [PHP-QA] run-tests.php

2007-09-14 Thread Nuno Lopes
It is a nice patch - but I'm seeing some errors that I don't understand yet when I use it - like this: Warning: preg_match(): Compilation failed: missing terminating ] for character class at offset 5 in /home/zoe/BUILDS/php52/run-tests.php on line 1609 I'm not having the best afternoon :-( -

Re: [PHP-DEV] Re: [PHP-QA] run-tests.php

2007-09-14 Thread Nuno Lopes
OK, so basically it is impossible to fix the current regex to match what we want (I had a quick chat with the PCRE author and he thinks the same). I propose the following patch: http://web.ist.utl.pt/nuno.lopes/php_run_tests_%s.txt The main changes are: '%s' => '[^\r\n]+' Nice patch! The onl

Re: [PHP-DEV] Re: [PHP-QA] run-tests.php

2007-09-13 Thread Nuno Lopes
now i get the issue. It grabbs more than one line! This means run-tests.php has to be fixed. The whole thing is designed under the assumption that %s catches no new lines and hence only one line. That would be the best answer but I think it's a difficult fix and whatever it was might break ot

Re: [PHP-DEV] Re: PHP 5.3 Suggested Feature List

2007-09-11 Thread Nuno Lopes
12) Merge the GCC 4 -fvisibility patch -1 (eventually make it a configure option first? PHP is a API mess) The patch is safe because otherwise PHP wouldn't work on windows (as windows doesn't export the symbols by default). Nuno -- PHP Internals - PHP Runtime Development Mailing List To uns

Re: [PHP-DEV] PHP 5.3 Suggested Feature List

2007-09-11 Thread Nuno Lopes
That patch is a very good idea, but it does not work there are symbols that are no lomger exported on libxml extension , and although everything compiles, I ended with a broken PHP. Can you give a bit more details on what is broken? Does it mean there's a problem on Windows too, since Windows d

Re: Re: [PHP-DEV] constant folding optimization

2007-09-09 Thread Nuno Lopes
Well we don't support that syntax at this moment. If you are saying that we could add support for such syntax.. it does seem a good idea, but in that case we would need to modify a few rules of the grammar (like adding a const_expr production, and allow static_scalar derive it, etc..). Ri

Re: [PHP-DEV] PHP 5.3 Suggested Feature List

2007-09-09 Thread Nuno Lopes
1) Backport the namespaces patch for PHP 6 2) Symlink the intl extension from PECL, but leave it disabled by default as is the case with all extensions dependent on external libs I haven't looked at it yet. 3) Apply the Late Static Binding Patch +0 4) Implement David's Circular Garbage

Re: Re: [PHP-DEV] constant folding optimization

2007-09-08 Thread Nuno Lopes
I made a patch to implement constant folding optimization in the Zend engine. The patch is available at: http://web.ist.utl.pt/nuno.lopes/zend_constant_folding.txt I like the idea a lot, however I think this patch has one significant downside - as far as I understand, it doesn't enable co

[PHP-DEV] constant folding optimization

2007-09-08 Thread Nuno Lopes
Hi, I made a patch to implement constant folding optimization in the Zend engine. The patch is available at: http://web.ist.utl.pt/nuno.lopes/zend_constant_folding.txt Please review & commit. Regards, Nuno P.S.: 'make test' shows 2 regressions with this patch (tests/run-test/test005.phpt

Re: Re: [PHP-DEV] Patch for macros for tracking refcount and is_ref

2007-09-04 Thread Nuno Lopes
Off the shelf garbage collectors such as BDW would be inappropriate because we use some weird kinds of "pointers" (such as object handles) stored in weird kinds of ways (such as a zend_hash object). I think it would be pretty inefficient, since those implementations just scan the stack, registers

Re: Re: [PHP-DEV] buildconf and the generated configure script for PHP6 is faulty [the fix].

2007-09-04 Thread Nuno Lopes
I'm not interested in filing a minimum of 100 bug reports when you don't have the manpower to process them, I've resolved most of them already (at least the ones related to the php base) and any that I haven't I've noted as "Broken - DNU" so I don't pass anything unstable on to my clients.

Re: Re: [PHP-DEV] Patch for macros for tracking refcount and is_ref

2007-09-04 Thread Nuno Lopes
About the patch, the zval_*_p() functions don't really need to exist.. they can be macros as well. As I said, if those were macros, it would be very difficult to squeeze more than one statement into them. Having multiple statements in Z_DELREF_P will also break that code. It seems to me inline

Re: [PHP-DEV] Patch for macros for tracking refcount and is_ref

2007-09-04 Thread Nuno Lopes
I think this is a pretty good idea. It can also have some use if we decide to investigate the usage of an off-the-shelf (conservative) garbage collector such as Boehm's (maybe in next year's SoC). About the patch, the zval_*_p() functions don't really need to exist.. they can be macros as w

Re: [PHP-DEV] Getting Windows exec to work better.

2007-08-09 Thread Nuno Lopes
Things are not that simple. I would advise you to read a more than one year thread about the very same subject: http://marc.info/?l=php-dev&m=113919491216978 Nuno - Original Message - From: "Richard Quadling" <[EMAIL PROTECTED]> To: "PHP Developers Mailing List" Sent: Thursday, Aug

[PHP-DEV] Re: multi-threaded run-tests.php

2007-07-25 Thread Nuno Lopes
t run-tests.php should be rewritten :P ""Nuno Lopes"" <[EMAIL PROTECTED]> wrote: > Hi, > > Recently we have moved http://gcov.php.net to a new (and much faster) > server. This allowed us to reduce the time to build all branches to "just" > 2 days (

[PHP-DEV] multi-threaded run-tests.php

2007-07-24 Thread Nuno Lopes
Hi, Recently we have moved http://gcov.php.net to a new (and much faster) server. This allowed us to reduce the time to build all branches to "just" 2 days (compared with almost one week that would take previously). However I'm still not happy :P The server has 2x2 CPU cores and I would like t

Re: [PHP-DEV] buildconf hell

2007-07-19 Thread Nuno Lopes
On Thu, July 19, 2007 12:45 am, Rasmus Lerdorf wrote: Richard Lynch wrote: What is the status of bringing PHP build process up to current automake/autoconf/libtool versions?... Or you could try simply using the current versions. They work fine. Yes, they all fail equally well. :-) I also

  1   2   3   4   >