Hi Sara,
On 07/31/2013 12:55 AM, Sara Golemon wrote:
At a glance, this looks awesome. There are a few changes where you
introduced #ifdef WIN32 checks that I want to spend a little more time
looking at...
In the WIN32 code there was an additional variable, declared always, but
switched from
Ah, yeah, I can see that clearly now. Looks universally cool to me. Do
you just need someone with engine karma to push it?
On Wed, Jul 31, 2013 at 1:35 AM, Andrey Hristov p...@hristov.com wrote:
Hi Sara,
On 07/31/2013 12:55 AM, Sara Golemon wrote:
At a glance, this looks awesome. There
On 07/31/2013 04:56 PM, Sara Golemon wrote:
Ah, yeah, I can see that clearly now. Looks universally cool to me. Do
you just need someone with engine karma to push it?
right. I have no Zend karma, or at least didn't have at CVS/SVN times.
On Wed, Jul 31, 2013 at 1:35 AM, Andrey Hristov
At a glance, this looks awesome. There are a few changes where you
introduced #ifdef WIN32 checks that I want to spend a little more time
looking at...
-Sara
P.S. - Could I convince you to put it on a github fork to make it easier to
read? No big deal if not... I just like that web view. :)
On Mon, Jul 29, 2013 at 12:01 PM, Andrey Hristov p...@hristov.com wrote:
Hi,
after experiencing again warnings about conversion from const char * to
char * when calling some PHP API functions I decided to spend some time and
constify a few of these. The result is a patch that constifies the
