Re: [PHP-DEV] [RFC][Vote] Covariant Returns and Contravariant Parameters

2018-12-27 Thread Levi Morrison
> 2. But this test misses warning > > > $q = 1; > if ($q) { > class C {} > class D {} > } > > class A { > function bar(C $c) {} > } > class B extends A { > function bar(D $D) { > echo "ok\n"; > } > } > ?> The code detects this as an error

Re: [PHP-DEV] [RFC][Vote] Covariant Returns and Contravariant Parameters

2018-12-24 Thread Dmitry Stogov
, December 21, 2018 10:28:05 AM To: Levi Morrison Cc: internals Subject: Re: [PHP-DEV] [RFC][Vote] Covariant Returns and Contravariant Parameters On 12/21/18 3:12 AM, Levi Morrison wrote: > On Thu, Dec 20, 2018 at 3:35 PM Dmitry Stogov wrote: >> >> Hi Levi, >> >> >&

Re: [PHP-DEV] [RFC][Vote] Covariant Returns and Contravariant Parameters

2018-12-20 Thread Dmitry Stogov
On 12/21/18 3:12 AM, Levi Morrison wrote: > On Thu, Dec 20, 2018 at 3:35 PM Dmitry Stogov wrote: >> >> Hi Levi, >> >> >> It looks like the patch broke something related to opcache. >> >> It crashes at least on Wordpress and Drupal. >> >> The backtrace >>

Re: [PHP-DEV] [RFC][Vote] Covariant Returns and Contravariant Parameters

2018-12-20 Thread Levi Morrison
On Thu, Dec 20, 2018 at 3:35 PM Dmitry Stogov wrote: > > Hi Levi, > > > It looks like the patch broke something related to opcache. > > It crashes at least on Wordpress and Drupal. > > The backtrace > https://gist.github.com/dstogov/a2305381a5c9982cceca9e4e252d26c7 shows > use-after-free in

Re: [PHP-DEV] [RFC][Vote] Covariant Returns and Contravariant Parameters

2018-12-20 Thread Dmitry Stogov
ks. Dmitry. From: Dmitry Stogov Sent: Thursday, December 20, 2018 6:26:10 PM To: Levi Morrison; internals Subject: Re: [PHP-DEV] [RFC][Vote] Covariant Returns and Contravariant Parameters Hi Levi, Please, create a Pull Request, to keep inline comments on github. Than

Re: [PHP-DEV] [RFC][Vote] Covariant Returns and Contravariant Parameters

2018-12-20 Thread Dmitry Stogov
Hi Levi, Please, create a Pull Request, to keep inline comments on github. Thanks. Dmitry. From: Levi Morrison Sent: Thursday, December 20, 2018 2:10:57 AM To: internals Subject: [PHP-DEV] [RFC][Vote] Covariant Returns and Contravariant Parameters Thank you

[PHP-DEV] [RFC][Vote] Covariant Returns and Contravariant Parameters

2018-12-19 Thread Levi Morrison
Thank you for the feedback and discussion on the [Covariant Returns and Contravariant Parameters RFC][1]. I have opened [voting on this RFC][2]. Given that this is a common time for holidays for many people around the world it will be open until at least January 2nd. Happy holidays! [1]: