Re: [PHP-DEV] 5.4a2 trait attribute name conflict resolution

2011-07-23 Thread Stefan Marr
Hi: On Fri, Jul 22, 2011 at 5:17 PM, Alex Howansky alex.howan...@gmail.com wrote: Hello folks, I've just grabbed 5.4a2 to play with traits. I've found some behaviour which I'm not sure is a bug, an inconsistency, or a design decision. Consider a trait and a class that implements it but

Re: [PHP-DEV] 5.4a2 trait attribute name conflict resolution

2011-07-23 Thread Stefan Marr
Hi Alex: On Fri, Jul 22, 2011 at 7:46 PM, Alex Howansky alex.howan...@gmail.com wrote: Best practice, always choose trait property names carefully/~unique so that you don't run into conflicts. Sure, but in this case, I created the conflict intentionally because I *want* to override it, and

Re: [PHP-DEV] 5.4a2 trait attribute name conflict resolution

2011-07-23 Thread Stefan Marr
On Fri, Jul 22, 2011 at 8:41 PM, Jonathan Bond-Caron jbo...@openmv.com wrote: On Fri Jul 22 01:46 PM, Alex Howansky wrote: Sure, but in this case, I created the conflict intentionally because I *want* to override it, and I'm not allowed to like I am with methods. Don't you think that's

Re: [PHP-DEV] 5.4a2 trait attribute name conflict resolution

2011-07-23 Thread Mike Stowe
So am I understanding correctly that the initial properties must be identical both in type and value, otherwise it would throw an error. To me that would make the most sense as they could be overridden in a construct or other method. If they are allowed to be different with one overriding the

Re: [PHP-DEV] 5.4a2 trait attribute name conflict resolution

2011-07-23 Thread Stefan Marr
Hi Mike: On Sat, Jul 23, 2011 at 6:49 PM, Mike Stowe mikegst...@gmail.com wrote: So am I understanding correctly that the initial properties must be identical both in type and value, otherwise it would throw an error. To me that would make the most sense as they could be overridden in a

[PHP-DEV] 5.4a2 trait attribute name conflict resolution

2011-07-22 Thread Alex Howansky
Hello folks, I've just grabbed 5.4a2 to play with traits. I've found some behaviour which I'm not sure is a bug, an inconsistency, or a design decision. Consider a trait and a class that implements it but also overrides both a trait method and a trait attribute: trait foo { public

Re: [PHP-DEV] 5.4a2 trait attribute name conflict resolution

2011-07-22 Thread Anthony Ferrara
I was under the impression that traits were not supposed to have properties at all: From the RFC: Since Traits do not contain any state/properties, there is a need to describe the requirements a Trait will rely on. In PHP it would be possible to utilize the dynamic language features, but it is a

Re: [PHP-DEV] 5.4a2 trait attribute name conflict resolution

2011-07-22 Thread Richard Quadling
On 22 July 2011 16:17, Alex Howansky alex.howan...@gmail.com wrote: Hello folks, I've just grabbed 5.4a2 to play with traits. I've found some behaviour which I'm not sure is a bug, an inconsistency, or a design decision. Consider a trait and a class that implements it but also overrides

Re: [PHP-DEV] 5.4a2 trait attribute name conflict resolution

2011-07-22 Thread Alex Howansky
That makes sense if it would overwrite the methods as well, but otherwise it seems like it provides inconsistent functionality. Exactly. At the least, it's inconsistent. If it's a bug, then it seems the question becomes: Is the bug this: Properties defined in a trait should be overridden

Re: [PHP-DEV] 5.4a2 trait attribute name conflict resolution

2011-07-22 Thread Adam Harvey
On 22 July 2011 09:12, Alex Howansky alex.howan...@gmail.com wrote: That makes sense if it would overwrite the methods as well, but otherwise it seems like it provides inconsistent functionality. Exactly. At the least, it's inconsistent. If it's a bug, then it seems the question becomes:

Re: [PHP-DEV] 5.4a2 trait attribute name conflict resolution

2011-07-22 Thread Michael Stowe
I agree with Adam, I think it would be nice to let the trait contain its own properties which can then be overwritten by the class properties. This way we could include default properties that the trait may be dependent on, while providing the opportunity to override individual properties to

Re: [PHP-DEV] 5.4a2 trait attribute name conflict resolution

2011-07-22 Thread Anthony Ferrara
Traits definitely need to be able to support properties, IMO Well, if traits support properties, they stop being traits and become mixins. A trait is nothing more than a mixin that does not have a state (so no properties). I'm not saying that it wouldn't be useful to contain properties (and

Re: [PHP-DEV] 5.4a2 trait attribute name conflict resolution

2011-07-22 Thread Michael Stowe
Didn't send to list the first time, please accept my apologies if you received this twice - Thanks That makes sense if it would overwrite the methods as well, but otherwise it seems like it provides inconsistent functionality. Perhaps I'm wrong as likewise I have a very limited understanding

Re: [PHP-DEV] 5.4a2 trait attribute name conflict resolution

2011-07-22 Thread Alex Howansky
Just curious, if the trait property is set to private what happens? Ooh, good question. PHP Fatal error: baz and foo define the same property ($zoo) in the composition of baz. However, the definition differs and is considered incompatible. -- Alex Howansky smime.p7s Description:

RE: [PHP-DEV] 5.4a2 trait attribute name conflict resolution

2011-07-22 Thread Jonathan Bond-Caron
On Fri Jul 22 11:17 AM, Alex Howansky wrote: trait foo { public $zoo = 'foo::zoo'; public function bar() { echo in foo::bar\n; } } class baz { use foo; public $zoo = 'baz::zoo'; public function bar() { echo in

Re: [PHP-DEV] 5.4a2 trait attribute name conflict resolution

2011-07-22 Thread Philip Olson
On Jul 22, 2011, at 9:32 AM, Alex Howansky wrote: Just curious, if the trait property is set to private what happens? Ooh, good question. PHP Fatal error: baz and foo define the same property ($zoo) in the composition of baz. However, the definition differs and is considered

Re: [PHP-DEV] 5.4a2 trait attribute name conflict resolution

2011-07-22 Thread Alex Howansky
Best practice, always choose trait property names carefully/~unique so that you don't run into conflicts. Sure, but in this case, I created the conflict intentionally because I *want* to override it, and I'm not allowed to like I am with methods. Don't you think that's inconsistent? The

RE: [PHP-DEV] 5.4a2 trait attribute name conflict resolution

2011-07-22 Thread Jonathan Bond-Caron
On Fri Jul 22 01:46 PM, Alex Howansky wrote: Sure, but in this case, I created the conflict intentionally because I *want* to override it, and I'm not allowed to like I am with methods. Don't you think that's inconsistent? Agree The short answer is it's not a bug but maybe an