Re: [PHP-DEV] Q: ZEND_HANDLE_STREAM and wincache extension on PHP 5.4

2012-03-21 Thread Dmitry Stogov
Hi Eric, Sorry, I don't read @internals every day. Please CC me if you need quick answer. Really I don't see the reason why wincache stores the PHP file source. Storing compiled opcodes must be enough. To avoid re-reading of already cached file. opcode cache should override

Re: [PHP-DEV] Q: ZEND_HANDLE_STREAM and wincache extension on PHP 5.4

2012-03-21 Thread Gustavo Lopes
On Wed, 21 Mar 2012 07:46:31 +0100, Dmitry Stogov dmi...@zend.com wrote: Anyway, I don't see a way to fix PHP to support custom streams without BC break, because zend_streams doesn't provide handlers for seeking. Couldn't you at least check whether e.g. the closer function pointer is

Re: [PHP-DEV] Q: ZEND_HANDLE_STREAM and wincache extension on PHP 5.4

2012-03-17 Thread Pierre Joye
hi, On Fri, Mar 16, 2012 at 7:49 PM, Gustavo Lopes glo...@nebm.ist.utl.pt wrote: It's best you send him an e-mail to dmi...@zend.com No, it is best to send a mail to internals and cc him. I was talking with Pierre yesterday, and there was some question about whether there was some

RE: [PHP-DEV] Q: ZEND_HANDLE_STREAM and wincache extension on PHP 5.4

2012-03-16 Thread Eric Stenson
-Original Message- From: Gustavo Lopes [mailto:glo...@nebm.ist.utl.pt] [...] For instance, see http://lxr.php.net/opengrok/xref/PHP_TRUNK/ext/phar/phar.c#3364 which has: file_handle-handle.stream.handle = phar; and *phar is of type phar_archive_data, which is not a

Re: [PHP-DEV] Q: ZEND_HANDLE_STREAM and wincache extension on PHP 5.4

2012-03-16 Thread Pierre Joye
On Fri, Mar 16, 2012 at 4:52 PM, Eric Stenson erics...@microsoft.com wrote: Does the phar extension make any distinction between when streams are opened?  Or, is it by virtue of only handling files that only end with extensions that aren't compiled that it's skipping the code in

Re: [PHP-DEV] Q: ZEND_HANDLE_STREAM and wincache extension on PHP 5.4

2012-03-16 Thread Gustavo Lopes
On Fri, 16 Mar 2012 16:52:39 +0100, Eric Stenson erics...@microsoft.com wrote: Thank you, Gustavo! Is Dmitry on the internals mailing list? It's best you send him an e-mail to dmi...@zend.com I was talking with Pierre yesterday, and there was some question about whether there was some

[PHP-DEV] Q: ZEND_HANDLE_STREAM and wincache extension on PHP 5.4

2012-03-15 Thread Eric Stenson
PHP Internals folks-- My name is Eric Stenson, and I'm a developer at Microsoft working on IIS. I've been given the task of upgrading our php_wincache extension to work on PHP5.4, and I've run into a problem. The problem I'm running into is the php_cgi!main() on PHP5.4 has changed behavior. 

Re: [PHP-DEV] Q: ZEND_HANDLE_STREAM and wincache extension on PHP 5.4

2012-03-15 Thread Gustavo Lopes
On Thu, 15 Mar 2012 19:56:11 +0100, Eric Stenson erics...@microsoft.com wrote: The problem I'm running into is the php_cgi!main() on PHP5.4 has changed behavior. The php_cgi!main() function is seeing us return a ZEND_HANDLE_STREAM, and it's assuming that the