Re: [PHP-DEV] [RFC] [VOTE] Implement missing SQLite feature "openBlob" in PDO

2017-11-01 Thread Rowan Collins
On 1 November 2017 17:47:55 GMT+00:00, BohwaZ wrote: >I can't find the place where we can see the voting history? Last time I >checked the page last week it was 6 to 5 or something like that. See my email in this thread from a couple of days ago. Last vote was a yes, but

Re: [PHP-DEV] [RFC] [VOTE] Implement missing SQLite feature "openBlob" in PDO

2017-11-01 Thread BohwaZ
On Mon, 30 Oct 2017 20:11:18 + / Rowan Collins said : > On 30/10/2017 03:14, Dan Ackroyd wrote: > > The vote for this should have ended..3 days ago. > > > > At which point I believe the vote was actually passing. > > > Hm, that's awkward! > > For the record: >

Re: [PHP-DEV] [RFC] [VOTE] Implement missing SQLite feature "openBlob" in PDO

2017-11-01 Thread BohwaZ
On Wed, 01 Nov 2017 19:08:56 + / Rowan Collins said : > On 1 November 2017 17:47:55 GMT+00:00, BohwaZ wrote: > >I can't find the place where we can see the voting history? Last > >time I checked the page last week it was 6 to 5 or something like >

Re: [PHP-DEV] [RFC] [VOTE] Implement missing SQLite feature "openBlob" in PDO

2017-11-01 Thread Rowan Collins
Just for the record, this question: Don't know where that 9th is from? I posted my email around 11 am on Tusday October 10th Is answered by this sentence: Ah yeah didn't thought of that, but I'm in NZ, so the dates I talked about were UTC+13. I'm in Europe/London time, so 11am for you

Re: [PHP-DEV] [RFC][VOTE] Flexible Heredoc and Nowdoc Syntaxes

2017-11-01 Thread Stanislav Malyshev
Hi! > Voting has now started on the flexible heredoc and nowdoc syntaxes RFC[1]. > > > Voting will be open for 2 weeks (until November 15th). Something I am missing here. RFC is talking about removing indents from heredoc text, but the vote says "Allow for the closing marker to be indented?"

Re: [PHP-DEV] [RFC][VOTE] Flexible Heredoc and Nowdoc Syntaxes

2017-11-01 Thread Dan Ackroyd
Stanislav Malyshev wrote: > > Something I am missing here. RFC is talking about removing indents from > heredoc text, but the vote says "Allow for the closing marker to be > indented?" and does not mention that indenting closing marker also > changes how the rest of the

Re: [PHP-DEV] [RFC][VOTE] Flexible Heredoc and Nowdoc Syntaxes

2017-11-01 Thread Christopher Jones
On 2/11/17 8:58 am, Stanislav Malyshev wrote: Hi! Voting has now started on the flexible heredoc and nowdoc syntaxes RFC[1]. Voting will be open for 2 weeks (until November 15th). Something I am missing here. RFC is talking about removing indents from heredoc text, but the vote says

[PHP-DEV] [RFC][VOTE] Flexible Heredoc and Nowdoc Syntaxes

2017-11-01 Thread Thomas Punt
Hi internals! Voting has now started on the flexible heredoc and nowdoc syntaxes RFC[1]. Voting will be open for 2 weeks (until November 15th). Thanks, Tom [1]: https://wiki.php.net/rfc/flexible_heredoc_nowdoc_syntaxes

Re: [PHP-DEV] RFC - Zend VM Pause API

2017-11-01 Thread Dmitry Stogov
or just change execute_data->opline... From: Dmitry Stogov Sent: Wednesday, November 1, 2017 12:14:22 PM To: Haitao Lv Cc: PHP Internals Subject: Re: [PHP-DEV] RFC - Zend VM Pause API after zend_interrupt_function() callback VM continues execution using

Re: [PHP-DEV] RFC - Zend VM Pause API

2017-11-01 Thread Haitao Lv
To make the discussion more detailed, please allow me to offer my implementation of use land coroutine(Fiber). https://github.com/php/php-src/compare/master...fiberphp:fiber-ext?expand=1 > On 1 Nov 2017, at 17:32, Haitao Lv wrote: > > Suppose we have a internal Coroutine class

Re: [PHP-DEV] [RFC] [VOTE] Implement missing SQLite feature "openBlob" in PDO

2017-11-01 Thread Derick Rethans
On Mon, 30 Oct 2017, Rowan Collins wrote: > On 30/10/2017 03:14, Dan Ackroyd wrote: > > The vote for this should have ended..3 days ago. > > > > At which point I believe the vote was actually passing. > > > Hm, that's awkward! > > For the record: > > - voting was announced on the evening

Re: [PHP-DEV] RFC - Zend VM Pause API

2017-11-01 Thread Dmitry Stogov
Hi, It should be possible do similar things using EG(vm_interrupt) and zend_interrupt_function() callback (introduced in php-7.1) ext/pcntl implements asynchronous signal handling using this. Thanks. Dmitry. From: Haitao Lv Sent: Wednesday,

Re: [PHP-DEV] RFC - Zend VM Pause API

2017-11-01 Thread Haitao Lv
Suppose we have a internal Coroutine class and it has a resume() method. In order to resume the coroutine, we have to call the resume() function. As the resume function is a internal method defined in c, we need call zend_execute_ex(backuped_execute_data) to resume the zend execution. If we

Re: [PHP-DEV] RFC - Zend VM Pause API

2017-11-01 Thread Dmitry Stogov
I'm not sure, why do you need to exit from the current VM instance. It should be possible to perform fiber scheduling and VM context switch directly in interrupt handler (like in real OS). VM should handle this out of the box (at least VM interrupts were designed with context switch in mind).

Re: [PHP-DEV] RFC - Zend VM Pause API

2017-11-01 Thread Haitao Lv
It seems that set EG(vm_interrupt) to 1 could not stop the vm execution but only execute the interrupt_function and continue the current execution. However, my RFC propose to stop the current execution. > On 1 Nov 2017, at 16:07, Dmitry Stogov wrote: > > Hi, > > It should be

Re: [PHP-DEV] RFC - Zend VM Pause API

2017-11-01 Thread Haitao Lv
Would it proper to introduce the following path? diff --git a/Zend/zend_vm_def.h b/Zend/zend_vm_def.h index 9bed9f86bb..cf0935df74 100644 --- a/Zend/zend_vm_def.h +++ b/Zend/zend_vm_def.h @@ -8920,13 +8920,19 @@ ZEND_VM_DEFINE_OP(137, ZEND_OP_DATA); ZEND_VM_HELPER(zend_interrupt_helper, ANY,

Re: [PHP-DEV] RFC - Zend VM Pause API

2017-11-01 Thread Dmitry Stogov
after zend_interrupt_function() callback VM continues execution using EG(current_execute_data). callback may modify it in any way (e.g. unwind stack, or switch to another co-routine or continuation). Thanks. Dmitry. From: Haitao Lv Sent:

Re: [PHP-DEV] RFC - Array Of for PHP 7

2017-11-01 Thread Michael Morris
Drupal 8 accomplishes this through assert() and a helper class. function foo ( array $a ) { assert( Inspector::assertAllStrings( $a )); } This could be improved by having an collectionof operator similar to the instanceof operator. function ( array $a ) { assert( $a collectionof string ); }

Re: [PHP-DEV] [RFC][VOTE] Flexible Heredoc and Nowdoc Syntaxes

2017-11-01 Thread Stanislav Malyshev
Hi! > From the body of the RFC: > > "To enable for the closing marker to be indented, ... The indentation > of the closing marker dictates the amount of whitespace to strip from > each line within the heredoc/nowdoc" Yes, that's what the RFC says. But the voting question only mentions indenting

Re: [PHP-DEV] RFC - Array Of for PHP 7

2017-11-01 Thread Rowan Collins
On 31 October 2017 17:37:17 GMT+00:00, Levi Morrison wrote: > - Our current infrastructure requires us to check every element of >the array for conformance. While undesirable I believe this can be >optimized away in the future if we care enough, and therefore not a >show-stopper.

Re: [PHP-DEV] [RFC] [VOTE] Implement missing SQLite feature "openBlob" in PDO

2017-11-01 Thread BohwaZ
Sorry I thought the vote would automatically close, but apparently it doesn't work like that. I was away from the internet so couldn't edit the wiki page. I can't find the place where we can see the voting history? Last time I checked the page last week it was 6 to 5 or something like that. On