[PHP-DEV] Fix for bug #63437

2013-03-05 Thread Anatol Belski
Hi, I've reworked the patch from http://nebm.ist.utl.pt/~glopes/misc/date_period_interval_ser.diff (mentioned by tony2001) for bug #63437, that seems to fix the issue. That patch was ported back to 5.3 and adapted to the current 5.4+. Both variants are posted to the ticket. Also the test for bug

Re: [PHP-DEV] Fix for bug #63437

2013-03-05 Thread Anatol Belski
Sorry, the correct one is bug #53437 ... On Tue, March 5, 2013 12:42, Anatol Belski wrote: Hi, I've reworked the patch from http://nebm.ist.utl.pt/~glopes/misc/date_period_interval_ser.diff (mentioned by tony2001) for bug #63437, that seems to fix the issue. That patch was ported back

Re: [PHP-DEV] (corrected) Fix for bug #53437

2013-03-08 Thread Anatol Belski
Hi, I wanted just remind about that bug and the patches hanging there. If there are no objections, I'd commit first to 5.5+ next week. 5.3/5.4 were also debatable. Regards Anatol On Tue, March 5, 2013 12:46, Anatol Belski wrote: Sorry, the correct one is bug #53437 ... On Tue, March 5

Re: [PHP-DEV] Fix for bug #63437

2013-03-09 Thread Anatol Belski
Hi, On Sat, 2013-03-09 at 21:57 +0100, Gustavo Lopes wrote: On Sat, 09 Mar 2013 21:36:41 +0100, Derick Rethans der...@php.net wrote: On Tue, 5 Mar 2013, Anatol Belski wrote: I've reworked the patch from http://nebm.ist.utl.pt/~glopes/misc/date_period_interval_ser.diff (mentioned

Re: [PHP-DEV] Fix for bug #63437

2013-03-11 Thread Anatol Belski
, Anatol Belski wrote: On Sat, 2013-03-09 at 21:57 +0100, Gustavo Lopes wrote: On Sat, 09 Mar 2013 21:36:41 +0100, Derick Rethans der...@php.net wrote: On Tue, 5 Mar 2013, Anatol Belski wrote: I've reworked the patch from http://nebm.ist.utl.pt/~glopes/misc/date_period_interval_ser.diff

Re: [PHP-DEV] Fix for bug #63437

2013-03-13 Thread Anatol Belski
On Mon, 2013-03-11 at 11:42 +, Derick Rethans wrote: Please, no top posting! On Mon, 11 Mar 2013, Anatol Belski wrote: On Sun, March 10, 2013 23:11, Derick Rethans wrote: On Sat, 9 Mar 2013, Anatol Belski wrote: On Sat, 2013-03-09 at 21:57 +0100, Gustavo Lopes wrote: I

Re: [PHP-DEV] Fix for bug #63437

2013-03-14 Thread Anatol Belski
On Thu, March 14, 2013 12:42, Derick Rethans wrote: On Wed, 13 Mar 2013, Anatol Belski wrote: On Mon, 2013-03-11 at 11:42 +, Derick Rethans wrote: On Mon, 11 Mar 2013, Anatol Belski wrote: What is the way you had in the mind to achieve the string-integer conversions? atoll

Re: [PHP-DEV] Fix for bug #63437

2013-03-14 Thread Anatol Belski
On Thu, March 14, 2013 14:14, Anatol Belski wrote: On Thu, March 14, 2013 12:42, Derick Rethans wrote: On Wed, 13 Mar 2013, Anatol Belski wrote: On Mon, 2013-03-11 at 11:42 +, Derick Rethans wrote: On Mon, 11 Mar 2013, Anatol Belski wrote: What is the way you had in the mind

[PHP-DEV] Merge #62852 and #53437 into 5.3 and 5.4

2013-03-18 Thread Anatol Belski
Hi, #62852 and #53437 introduced fixes for the date extension crashing when unserializing objects. They was applied to 5.5. If there are no objections, I would backport those to 5.3 and 5.4. Regards Anatol -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit:

Re: [PHP-DEV] Merge #62852 and #53437 into 5.3 and 5.4

2013-03-18 Thread Anatol Belski
E_RECOVERABLE or even just E_WARNING. johannes Anatol Belski a...@php.net wrote: Hi, #62852 and #53437 introduced fixes for the date extension crashing when unserializing objects. They was applied to 5.5. If there are no objections, I would backport those to 5.3 and 5.4. Regards

[PHP-DEV] Re: [PHP-CVS] com php-src: Backported fix for bug #62852: NEWS ext/date/php_date.c ext/date/tests/bug62852.phpt ext/date/tests/bug62852_var2.phpt ext/date/tests/bug62852_var3.phpt

2013-03-20 Thread Anatol Belski
On Wed, March 20, 2013 09:05, Stas Malyshev wrote: Hi! The issue is that a warning wouldn't destroy that object. That object will occasionally segfault PHP. E_ERROR is the simplest solution which doesn't change the behavior of the normal operations. Can't we just reset the object data to

[PHP-DEV] Fix for #64450

2013-03-21 Thread Anatol Belski
Hi Dmitry, I developed a patch for this one https://bugs.php.net/bug.php?id=64450 . It's regarding to the long overflow in mt_rand(). The main idea is to work with the args as double internally and then return php float if it exceeds the LONG_MAX. I strived to let the old behavior to be

[PHP-DEV] Re: Fix for #64450

2013-03-22 Thread Anatol Belski
it's disallowed, but you may get arguments as longs and then convert them to double. Will it work? Thanks. Dmitry. On Thu, Mar 21, 2013 at 9:26 PM, Dmitry Stogov dmi...@zend.com wrote: I'll able to look only tomorrow morning. Thanks. Dmitry. On Thu, Mar 21, 2013 at 8:46 PM, Anatol

Re: [PHP-DEV] Re: Fix for #64450

2013-03-22 Thread Anatol Belski
that issue and that could indeed be made better, that's my motivation. Thanks for the tips. Anatol Thanks. Dmitry. On Fri, Mar 22, 2013 at 12:08 PM, Anatol Belski a...@php.net wrote: Dmitry, first of all thanks for taking a look :) The issue in a few words - mt_rand reads arguments

Re: [PHP-DEV] Re: Fix for #64450

2013-03-25 Thread Anatol Belski
variation, effectively double or long. That might coexist in pecl or in core. Any other intrusion would change the core significantly. Thanks for your support! Anatol On Fri, 2013-03-22 at 11:34 +0100, Anatol Belski wrote: On Fri, March 22, 2013 10:08, Dmitry Stogov wrote: Thanks, now I

[PHP-DEV] libmagic 5.14 upgrade

2013-03-26 Thread Anatol Belski
Hi, I've developed a patch for libmagic 5.14 which is available under http://belski.net/phpz/finfo/finfo_5.14_5.patch.gz . For those willing to test please overwrite ext/fileinfo/tests/magic with http://belski.net/phpz/finfo/magic.mgc.gz (not contained in the patch). I've tested it on Linux and

Re: [PHP-DEV] Re: libmagic 5.14 upgrade

2013-04-01 Thread Anatol Belski
Stas, I've invested more time and here's almost cleaned up patch http://belski.net/phpz/finfo/finfo_5.14_10.patch.gz The tests pass, valgrind is happy, as well Windows. I've noticed no behaviour change, except - as the data is updated and one might see different (eventually better) results.

Re: [PHP-DEV] Re: libmagic 5.14 upgrade

2013-04-05 Thread Anatol Belski
Stas, how does it look with this one? Please let me know whether it's ok for 5.4. I would go with master otherwise. Thanks Anatol On Mon, 2013-04-01 at 19:13 +0200, Anatol Belski wrote: Stas, I've invested more time and here's almost cleaned up patch http://belski.net/phpz/finfo

[PHP-DEV] DateTime for #53437 5.3/5.4

2013-04-09 Thread Anatol Belski
Hi, I just wanted to address again these two patches to be applied in 5.3/5.4 http://git.php.net/?p=php-src.git;a=commitdiff;h=0ee71557ffd285552659b6aa37ea236e3bad493f http://git.php.net/?p=php-src.git;a=commitdiff;h=fa3fc711d3fb54bf1746138ffcf7f46426921204 Both are in 5.5 already for some

Re: [PHP-DEV] Re: PHP 5.5 beta4 available

2013-04-25 Thread Anatol Belski
Jan, On Thu, April 25, 2013 16:21, Jan Ehrhardt wrote: Remi pointed me in the right direction. I discovered the new packages at /qa just before I read your replies. It now builds fine with the exception of php_ssh2.dll. I used these dependencies:

Re: [PHP-DEV] Re: PHP 5.5 beta4 available

2013-04-25 Thread Anatol Belski
Jan, On Thu, April 25, 2013 19:10, Jan Ehrhardt wrote: That was exectly the version: SSH2 support enabled extension version 0.12 libssh2 version1.4.2 (or 1.4.3) banner SSH-2.0-libssh2_1.4.2/3 With the libssh2* files from

Re: [PHP-DEV] Re: PHP 5.5 beta4 available

2013-04-25 Thread Anatol Belski
Jan, On Thu, April 25, 2013 21:46, Jan Ehrhardt wrote: Anatol Belski in php.internals (Thu, 25 Apr 2013 20:12:11 +0200): Ok, so we must have built some different ways. Anyway that builds I've mentioned should work and I'll recheck next time I do the ssh2 ext. The difference probably

[PHP-DEV] Re: About fileinfo test.mp3

2013-05-24 Thread Anatol Belski
Hi David, On Fri, 2013-05-24 at 23:28 +0200, David Soria Parra wrote: Hi Anatol, I saw your commit 74555e7c26b2c61bb8e67b7d6a6f4d2b8eb3a5f3 added a 4mb mp3 file. Is it possible to create a much smaller mp3 that helps to reproduce the same bug? The file blows up the taball file for the

Re: [PHP-DEV] Re: #53437

2013-06-07 Thread Anatol Belski
Hi Derick, On Fri, June 7, 2013 12:45, Derick Rethans wrote: On Thu, 6 Jun 2013, Pierre Joye wrote: On Jun 6, 2013 6:03 PM, Derick Rethans der...@php.net wrote: On Thu, 6 Jun 2013, Pierre Joye wrote: The fix for #53437 is around for some time now. It full fills the requirements

Re: [PHP-DEV] Re: #53437

2013-06-07 Thread Anatol Belski
Hi Derick, On Fri, June 7, 2013 14:06, Derick Rethans wrote: On Fri, 7 Jun 2013, Anatol Belski wrote: On Fri, June 7, 2013 12:45, Derick Rethans wrote: On Thu, 6 Jun 2013, Pierre Joye wrote: On Jun 6, 2013 6:03 PM, Derick Rethans der...@php.net wrote: On Thu, 6 Jun 2013, Pierre Joye

Re: [PHP-DEV] Re: #53437

2013-06-10 Thread Anatol Belski
Hi Etienne, On Mon, June 10, 2013 13:24, Etienne Kneuss wrote: On Fri, Jun 7, 2013 at 9:27 PM, Gustavo Lopes glo...@nebm.ist.utl.ptwrote: On Fri, 07 Jun 2013 14:06:11 +0200, Derick Rethans der...@php.net wrote: That's the one where conversion int string for serialization was

Re: [PHP-DEV] Re: #53437

2013-06-10 Thread Anatol Belski
On Mon, June 10, 2013 14:04, Etienne Kneuss wrote: On Mon, Jun 10, 2013 at 1:56 PM, Anatol Belski a...@php.net wrote: Hi Etienne, On Mon, June 10, 2013 13:24, Etienne Kneuss wrote: On Fri, Jun 7, 2013 at 9:27 PM, Gustavo Lopes glo...@nebm.ist.utl.ptwrote: On Fri, 07 Jun 2013 14:06:11

Re: [PHP-DEV] Re: #53437

2013-06-10 Thread Anatol Belski
Hi Stas, On Mon, 2013-06-10 at 10:54 -0700, Stas Malyshev wrote: Hi! Stas, Johannes? We have to fix this crash, in one way or another. The current patch is good imo. I'm ok with this in 5.4 but I'd really like to fix the var_dump issue if possible. I've reworked the patch before

Re: [PHP-DEV] String Size Refactor Progress

2013-07-10 Thread Anatol Belski
Hi, On Wed, July 10, 2013 07:51, Pierre Joye wrote: Substr needs to be refactored to use size_t. Right now, I just raise an error if Z_STRSIZE INT_MAX (or an overflow would happen). I'd love to see that cleaned up more. We should consider moving to int64_t too as well while being at it.

Re: [PHP-DEV] Re: PHP 5.5.1 released

2013-07-19 Thread Anatol Belski
Hi Jan, I've just tried to make a snapshot build and it's worked. Please give the exact way you do it from the start. Regards Anatol On Fri, July 19, 2013 12:44, Jan Ehrhardt wrote: Julien Pauli in php.internals (Fri, 19 Jul 2013 10:26:54 +0200): We just released PHP 5.5.1. This release

Re: [PHP-DEV] Re: PHP 5.5.1 released

2013-07-19 Thread Anatol Belski
On Fri, July 19, 2013 14:17, Jan Ehrhardt wrote: Jan Ehrhardt in php.internals (Fri, 19 Jul 2013 14:03:51 +0200): http://windows.php.net/downloads/releases/php-5.5.1-src.zip does not contain a zend_language_parser.c. The php-5.5.1.tar.xz does...

Re: [PHP-DEV] Re: PHP 5.5.1 released

2013-07-21 Thread Anatol Belski
Jan, On Fri, 2013-07-19 at 23:25 +0200, Jan Ehrhardt wrote: Sometimes you run into weird things. Today I learned that upgrading to ICU51 works perfectly under x64, but x86 stumbles over it and fails to compile php_intl.dll. No wonder the official builds still stick to 50.1.2. There was

Re: [PHP-DEV] Always set return_value_ptr?

2013-08-03 Thread Anatol Belski
Hi Nikita, On Sat, 2013-08-03 at 20:16 +0200, Nikita Popov wrote: Why can't we always provide the retval ptr, even for functions that don't return by reference? This would allow returning zvals without having to copy them first (what RETVAL_ZVAL does). were it not possible to zval_add_ref()

Re: [PHP-DEV] git branches 5.3/ 5.4 / 5.5

2013-08-15 Thread Anatol Belski
On Thu, August 15, 2013 20:45, Johannes Schlüter wrote: On Thu, 2013-08-15 at 20:19 +0200, Jordi Boggiano wrote: And to ensure you never push garbage by accident, run this to tell git to always only push the branch you're on when you run `git push`: git config --global push.default current

[PHP-DEV] Windows builds PECL site integration

2013-10-07 Thread Anatol Belski
Hi, as one could already have seen, the links to the extension DLLs has been integrated into the PECL website. Basically the builds done until now are shown. Together with the automatic builds this brings automatic updates for every new release built for windows. A couple of notes I'd like to

[PHP-DEV] PECL site improvements

2013-10-14 Thread Anatol Belski
Hi, there are two improvements just implemented to the PECL website. I Every package is required to have LICENSE or COPYING to be present in the root of the package. The goal is to enforce the conformance with at least PHP and BSD licenses. Where by no explicit check for exact license type is

Re: [PHP-DEV] Re: Fix for bug #50333

2013-10-23 Thread Anatol Belski
. Dmitry. On Fri, Oct 18, 2013 at 7:33 PM, Anatol Belski a...@php.net wrote: Hi, the pull request https://github.com/php/php-src/pull/500 fixing the bug #50333 is ready to review. Manual tests done so far on linux and windows in TS and NTS mode with CLI and Apache show no regression

Re: [PHP-DEV] Implemented fallocate() syscall in streams

2014-07-08 Thread Anatol Belski
Hi Julien, On Fri, June 13, 2014 16:20, Julien Pauli wrote: Hi, I just wrote a patch to add fallocate() syscall support for streams. It relies on posix_fallocate(), so that it should support many Unixes. Linux's got a specification with a fallocate() function, more powerful than the posix

Re: [PHP-DEV] 64-bit integers and 64-bit string length patch is ready to be merged

2014-08-22 Thread Anatol Belski
Moin, On Thu, August 21, 2014 19:23, Dmitry Stogov wrote: Hi, Thanks to Anatol and Pierre the 64-bit patch is ready https://github.com/weltling/php-src I made quick code review and don't see any technical problems now. The performance and memory consumption difference is negligible.

[PHP-DEV] Merges between PHP5 and PHP7

2014-08-22 Thread Anatol Belski
Hi, as there are many data type changes, here's an idea on how to simplify the merges. Git supports custom merge drivers which attracted my attention, so I've ended up with the following trick: === Add to .git/config === [merge 7] name = Compatibility merge between PHP5 and PHP7 driver

Re: [PHP-DEV] [RFC] Better type names for int64 RFC

2014-08-22 Thread Anatol Belski
Hi Nikita, On Fri, August 22, 2014 13:16, Nikita Popov wrote: Hi internals! Today the int64 RFC has been merged, despite objections regarding the naming changes it introduces. As we were not given a chance to resolve this issue before the merge, a short proposal has been created, which

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: fixes to date: ext/date/lib/timelib.c ext/date/lib/timelib.h ext/date/php_date.c ext/date/php_date.h

2014-08-22 Thread Anatol Belski
On Fri, August 22, 2014 14:15, Pierre Joye wrote: On Fri, Aug 22, 2014 at 2:01 PM, Derick Rethans der...@php.net wrote: On Mon, 18 Aug 2014, Anatol Belski wrote: Commit:e49e163a9ed7d4e38f9ab724003c46c9f1ea2cb4 Author:Anatol Belski a...@php.net Mon, 18 Aug 2014 18:57:55

[PHP-DEV] Re: [PHP-CVS] com php-src: fixes to date: ext/date/lib/timelib.c ext/date/lib/timelib.h ext/date/php_date.c ext/date/php_date.h

2014-08-22 Thread Anatol Belski
On Fri, August 22, 2014 14:54, Derick Rethans wrote: On Fri, 22 Aug 2014, Anatol Belski wrote: On Fri, August 22, 2014 14:01, Derick Rethans wrote: On Mon, 18 Aug 2014, Anatol Belski wrote: Commit:e49e163a9ed7d4e38f9ab724003c46c9f1ea2cb4 Author:Anatol Belski a...@php.net

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: fixes to date: ext/date/lib/timelib.c ext/date/lib/timelib.h ext/date/php_date.c ext/date/php_date.h

2014-08-22 Thread Anatol Belski
On Fri, August 22, 2014 17:17, Derick Rethans wrote: On Fri, 22 Aug 2014, Anatol Belski wrote: On Fri, August 22, 2014 14:54, Derick Rethans wrote: Yeah, those datatypes should already be there. What needs fixing to make it work? I think now that it's unavoidable to create an arch

[PHP-DEV] Re: date extension broken tests

2014-08-25 Thread Anatol Belski
Hi Lior, On Mon, August 25, 2014 11:09, Lior Kaplan wrote: Hi Anatol, It seems you've done some changes to the date extension recently, could you take a look at these two failures. Dmitry - FYI in case it's phpng related. Bug #67118 crashes in DateTime when this used after failed

[PHP-DEV] Re: [PHP-CVS] com php-src: fixes to string functions: ext/standard/php_string.h ext/standard/string.c

2014-08-27 Thread Anatol Belski
On Wed, August 27, 2014 01:32, Nikita Popov wrote: On Mon, Aug 18, 2014 at 3:39 PM, Anatol Belski a...@php.net wrote: Commit:97e9d058f09c12161863e5c3832552eb5da3f3c6 Author:Anatol Belski a...@php.net Mon, 18 Aug 2014 15:39:38 +0200 Parents

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: fixes to date: ext/date/lib/timelib.c ext/date/lib/timelib.h ext/date/php_date.c ext/date/php_date.h

2014-08-27 Thread Anatol Belski
Hi Derick, On Tue, August 26, 2014 10:49, Derick Rethans wrote: On Fri, 22 Aug 2014, Anatol Belski wrote: On Fri, August 22, 2014 17:17, Derick Rethans wrote: On Fri, 22 Aug 2014, Anatol Belski wrote: On Fri, August 22, 2014 14:54, Derick Rethans wrote: Yeah, those datatypes should

Re: [PHP-DEV] Re: zpp and zend_string

2014-08-27 Thread Anatol Belski
Hi Tjerk, On Wed, August 27, 2014 07:34, Tjerk Meesters wrote: Hi internals, With the recent merge of int64 the `zend_string` type now uses `size_t` to store its length, but ZPP (and friends) still use `int *` to store the parsed string lengths.

Re: [PHP-DEV] Merges between PHP5 and PHP7

2014-08-28 Thread Anatol Belski
Hi Derick, On Thu, August 28, 2014 17:23, Derick Rethans wrote: On Fri, 22 Aug 2014, Derick Rethans wrote: On Fri, 22 Aug 2014, Anatol Belski wrote: as there are many data type changes, here's an idea on how to simplify the merges. Git supports custom merge drivers which attracted my

[PHP-DEV] 64 bit string offsets

2014-08-29 Thread Anatol Belski
Hi, while refining the big string support, it turned out that we've an issue. The syntax like $s[42] = 'x'; is currently inconsistend, because we have uint32 for string offsets. This actually means, the behaviour is currently only available in the old style and can handle not more than 2gb big

Re: [PHP-DEV] 64 bit string offsets

2014-08-29 Thread Anatol Belski
On Fri, August 29, 2014 19:41, Andrea Faulds wrote: On 29 Aug 2014, at 17:39, Anatol Belski anatol@belski.net wrote: On Fri, August 29, 2014 17:54, Andrea Faulds wrote: I’d just leave things as they are… though I suppose there might be some benefit to switching to size_t for string

Re: [PHP-DEV] Re: 64 bit string offsets

2014-08-29 Thread Anatol Belski
On Fri, August 29, 2014 18:34, Xinchen Hui wrote: On Fri, Aug 29, 2014 at 11:49 PM, Anatol Belski anatol@belski.net wrote: Hi, while refining the big string support, it turned out that we've an issue. The syntax like $s[42] = 'x'; is currently inconsistend, because we have uint32

Re: [PHP-DEV] Re: 64 bit string offsets

2014-08-31 Thread Anatol Belski
On Fri, August 29, 2014 18:34, Xinchen Hui wrote: On Fri, Aug 29, 2014 at 11:49 PM, Anatol Belski anatol@belski.net wrote: Hi, while refining the big string support, it turned out that we've an issue. The syntax like $s[42] = 'x'; is currently inconsistend, because we have uint32

Re: [PHP-DEV] Re: 64 bit string offsets

2014-08-31 Thread Anatol Belski
Hi Pierre, On Sun, August 31, 2014 14:12, Pierre Joye wrote: Hi Anatol, Thanks! For what I see it should have no impact, either mem usage or perf but when such offset is used, in 64bit. However some numbers are better, could you provide some using exclusively this syntax and using

Re: [PHP-DEV] Re: 64 bit string offsets

2014-09-01 Thread Anatol Belski
On Sun, August 31, 2014 22:31, Anatol Belski wrote: Hi Pierre, On Sun, August 31, 2014 14:12, Pierre Joye wrote: Hi Anatol, Thanks! For what I see it should have no impact, either mem usage or perf but when such offset is used, in 64bit. However some numbers are better, could you

Re: [PHP-DEV] Re: 64 bit string offsets

2014-09-01 Thread Anatol Belski
Hi Dmitry, On Mon, September 1, 2014 16:17, Dmitry Stogov wrote: Hi Anatol, what do you mean? heap allocated structure? I think, it's not a good option :( I didn't have time to think about this yet. I thought about creating an extended zend_string struct with an appended offset member.

[PHP-DEV] Re: [PATCH] Microsecond resolution and accuracy on Windows

2014-09-02 Thread Anatol Belski
Hi Matt, On Mon, September 1, 2014 20:36, Matt Wilmas wrote: Hi all! I'm back after several years, and will have a few more changes for Windows, at least. (It was CVS back then, so I still have to figure some things out... Just had to edit files on Github site. :-/) Anyway, this patch

[PHP-DEV] Re: [INTERNALS-WIN] [PATCH] Microsecond resolution and accuracy on Windows

2014-09-02 Thread Anatol Belski
On Mon, September 1, 2014 22:49, Stas Malyshev wrote: Hi! It's much more optimized than what's there now, and slightly over the old implementation. Not sure if I should give the saved patch link, or the live compare (?) on Github, so I'll do both for now:

Re: [PHP-DEV] Re: [INTERNALS-WIN] [PATCH] Microsecond resolution and accuracy on Windows

2014-09-02 Thread Anatol Belski
On Mon, September 1, 2014 23:45, Matt Wilmas wrote: Hi Stas, - Original Message - From: Stas Malyshev Sent: Monday, September 01, 2014 Hi! It's much more optimized than what's there now, and slightly over the old implementation. Not sure if I should give the saved patch

Re: [PHP-DEV] Re: 64 bit string offsets

2014-09-03 Thread Anatol Belski
On Mon, September 1, 2014 19:07, Anatol Belski wrote: Hi Dmitry, On Mon, September 1, 2014 16:17, Dmitry Stogov wrote: Hi Anatol, what do you mean? heap allocated structure? I think, it's not a good option :( I didn't have time to think about this yet. I thought about creating

Re: [PHP-DEV] Re: [INTERNALS-WIN] [PATCH] Microsecond resolution and accuracy on Windows

2014-09-09 Thread Anatol Belski
Hi Matt, On Fri, September 5, 2014 20:05, Matt Wilmas wrote: Hi Anatol, - Original Message - From: Anatol Belski Sent: Tuesday, September 02, 2014 Unfortunately that's not a PR so I cannot comment there directly, so I'd leave a couple of the comments to the code here

Re: [PHP-DEV] Re: [INTERNALS-WIN] [PATCH] Microsecond resolution and accuracy on Windows

2014-09-10 Thread Anatol Belski
the idea, in principle, of it working at all like the old way (in a good way)? :-/ The patch doesn't make all these new problems like you are suggesting. More below... - Original Message - From: Anatol Belski Sent: Tuesday, September 09, 2014 Hi Matt, [...] coming

[PHP-DEV] Re: [PHP-CVS] com php-src: check emalloc() result: ext/standard/http_fopen_wrapper.c

2014-09-13 Thread Anatol Belski
Hi Nikita, On Sat, September 13, 2014 23:35, Nikita Popov wrote: On Sat, Sep 13, 2014 at 11:21 PM, Anatol Belski a...@php.net wrote: Commit:bce562b75efcdacc762a3b94915cdf02056b22dc Author:Anatol Belski a...@php.net Sat, 13 Sep 2014 20:20:17 +0200 Parents

[PHP-DEV] Re: [PHP-CVS] com php-src: fix int overflow preserving the old behavior: ext/standard/strnatcmp.c

2014-09-15 Thread Anatol Belski
Moin, On Mon, September 15, 2014 01:01, Nikita Popov wrote: On Sun, Sep 14, 2014 at 4:39 PM, Anatol Belski a...@php.net wrote: Commit:29f8b21cd71bc4af1ead7b8a93cfe09338d2eff5 Author:Anatol Belski a...@php.net Sun, 14 Sep 2014 16:37:38 +0200 Parents

[PHP-DEV] Re: [PHP-CVS] com php-src: fix signed/unsigned mismatch: Zend/zend_execute.c

2014-09-15 Thread Anatol Belski
On Mon, September 15, 2014 13:13, Nikita Popov wrote: On Mon, Sep 15, 2014 at 12:58 PM, Anatol Belski a...@php.net wrote: Commit:836fd73cce8d0550baf5477bfb0ea0edbfae455a Author:Anatol Belski a...@php.net Mon, 15 Sep 2014 12:12:18 +0200 Parents

[PHP-DEV] Re: [PHP-CVS] com php-src: fix signed/unsigned mismatch: Zend/zend_execute.c

2014-09-15 Thread Anatol Belski
On Mon, September 15, 2014 13:38, Anatol Belski wrote: On Mon, September 15, 2014 13:13, Nikita Popov wrote: On Mon, Sep 15, 2014 at 12:58 PM, Anatol Belski a...@php.net wrote: Commit:836fd73cce8d0550baf5477bfb0ea0edbfae455a Author:Anatol Belski a...@php.net Mon, 15 Sep

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: fix signed/unsigned mismatch: Zend/zend_execute.c

2014-09-15 Thread Anatol Belski
On Mon, September 15, 2014 13:38, Anatol Belski wrote: On Mon, September 15, 2014 13:13, Nikita Popov wrote: On Mon, Sep 15, 2014 at 12:58 PM, Anatol Belski a...@php.net wrote: Commit:836fd73cce8d0550baf5477bfb0ea0edbfae455a Author:Anatol Belski a...@php.net Mon, 15 Sep

Re: [PHP-DEV] Re: When, When, When???

2014-09-16 Thread Anatol Belski
Hi Jorge, On Mon, September 15, 2014 22:25, Jorge F. Hernandez wrote: Stephen asked me to check in your list, but I don't see anything new, so does anybody have any idea? Signature On 9/15/2014 3:32 PM, Stephen Zarkos wrote: Hi, -Original Message- From: Jorge F. Hernandez

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: fix signed/unsigned mismatch: Zend/zend_execute.c

2014-09-16 Thread Anatol Belski
On Tue, September 16, 2014 12:03, Nikita Popov wrote: On Tue, Sep 16, 2014 at 9:43 AM, Anatol Belski a...@php.net mailto:a...@php.net wrote: Hi Nikita, Are you sure about this? I can set memory_limit to -1, which is then cast to size_t, resulting in a limit ZEND_LONG_MAX. I tried

Re: [PHP-DEV] Re: When, When, When???

2014-09-16 Thread Anatol Belski
Hi, On Tue, September 16, 2014 15:54, Christoph Becker wrote: Jorge F. Hernandez wrote: I am running PHP 5.6.0 x64 on my Windows Server 2008 R2 with Apache 2.4 x64, I just tried to put a memory_limit higher than 3584M and I got a white screen when trying to access phpinfo() to check, I

Re: [PHP-DEV] Re: When, When, When???

2014-09-16 Thread Anatol Belski
Hi Jorge, On Tue, September 16, 2014 18:11, Jorge F. Hernandez wrote: On 9/16/2014 11:14 AM, Anatol Belski wrote: Hi, On Tue, September 16, 2014 15:54, Christoph Becker wrote: Jorge F. Hernandez wrote: I am running PHP 5.6.0 x64 on my Windows Server 2008 R2 with Apache 2.4 x64, I

Re: [PHP-DEV] Re: When, When, When???

2014-09-16 Thread Anatol Belski
On Tue, September 16, 2014 18:25, Leigh wrote: On 16 September 2014 16:14, Anatol Belski anatol@belski.net wrote: I made a build from the current revision http://windows.php.net/downloads/snaps/ostc/master-f469dc74/ so anyone curious can easy snuffle :) It contains all the currently

Re: [PHP-DEV] RFC: Removal of dead SAPIs

2014-09-18 Thread Anatol Belski
Hi Marius, On Thu, September 18, 2014 11:08, marius adrian popa wrote: Maybe is time to vote and implement it in php 7 with a pull request for each sapi https://wiki.php.net/rfc/removal_of_dead_sapis tux is dead for almost 10 years thttpd does have a fork that seems maintained from git

[PHP-DEV] Re: [PHP-CVS] com php-src: fix CG(empty_string) init in ZTS: Zend/zend.c

2014-09-18 Thread Anatol Belski
Hi Nikita, On Thu, September 18, 2014 22:34, Nikita Popov wrote: On Thu, Sep 18, 2014 at 5:14 PM, Anatol Belski a...@php.net wrote: Commit:e8b497ad8eb74273f7f44ae7e515e7a5e95b50f7 Author:Anatol Belski a...@php.net Thu, 18 Sep 2014 16:45:50 +0200 Parents

[PHP-DEV] Re: [PHP-CVS] com php-src: avoid multiple strlen calls for the same buffer: Zend/zend_virtual_cwd.c

2014-09-19 Thread Anatol Belski
On Fri, September 19, 2014 12:57, Nikita Popov wrote: On Fri, Sep 19, 2014 at 12:39 PM, Anatol Belski a...@php.net wrote: Commit:6bbebc60ea0de6ce09ea45094b3bed1823d96cec Author:Anatol Belski a...@php.net Fri, 19 Sep 2014 12:39:17 +0200 Parents

[PHP-DEV] Re: [PHP-CVS] com php-src: avoid multiple strlen calls for the same buffer: Zend/zend_virtual_cwd.c

2014-09-19 Thread Anatol Belski
On Fri, September 19, 2014 14:56, Anatol Belski wrote: On Fri, September 19, 2014 12:57, Nikita Popov wrote: On Fri, Sep 19, 2014 at 12:39 PM, Anatol Belski a...@php.net wrote: Commit:6bbebc60ea0de6ce09ea45094b3bed1823d96cec Author:Anatol Belski a...@php.net Fri, 19 Sep

[PHP-DEV] Removing *.dsw *dsp files from php-src

2014-09-20 Thread Anatol Belski
Hi, this was already suggested at least once last year. But now with master this is pretty justified. In the light of the PdbProject presense, removing the *.dsw *.dsp files will simplify things negating the need to update those on every change. Also, those files are in VS2005 format, but master

[PHP-DEV] Re: [PHP-CVS] com php-src: fix CG(empty_string) init in ZTS: Zend/zend.c

2014-09-20 Thread Anatol Belski
Hi Dmitry, On Fri, September 19, 2014 12:43, Dmitry Stogov wrote: I know :) Interned strings in PHP5 were implemented as characters allocated in one single buffer. Adding new strings into this buffer from different threads would require synchronization (locks). In PHP7 this implementation

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: fix CG(empty_string) init in ZTS: Zend/zend.c

2014-09-21 Thread Anatol Belski
Hi Dmitry, On Sat, September 20, 2014 09:58, Anatol Belski wrote: Hi Dmitry, On Fri, September 19, 2014 12:43, Dmitry Stogov wrote: I know :) Interned strings in PHP5 were implemented as characters allocated in one single buffer. Adding new strings into this buffer from different

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: fix CG(empty_string) init in ZTS: Zend/zend.c

2014-09-26 Thread Anatol Belski
Hi Dmitry, On Mon, September 22, 2014 08:43, Dmitry Stogov wrote: Hi Anatol, I didn't completely get your ideas, but if tsrm_ls_cache can't be exported on Windows directly, can we have a copy of tsrm_ls_cache in each DLL/EXE and initialize it once? Thanks. Dmitry. Joe and me was working

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: fix CG(empty_string) init in ZTS: Zend/zend.c

2014-09-30 Thread Anatol Belski
Hi Dmtry, thanks for taking a look at this. On Wed, October 1, 2014 00:09, Dmitry Stogov wrote: Hi, I took a quick look over the patch. I didn't get why it's named native_tls now, because it doesn't use __thread variables anymore. I was wondering myself but now I see (intentionally taking

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: fix CG(empty_string) init in ZTS: Zend/zend.c

2014-10-05 Thread Anatol Belski
Hi Dmitry, On Wed, October 1, 2014 08:01, Dmitry Stogov wrote: Hi Anatol, I know, TSRM uses TLS APIs internally. In my opinion, the simplest (and probably efficient) way to get rid of TSRMLS_DC arguments and TSRMLS_FETCH calls, would be introducing a global thread specific variable.

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: fix CG(empty_string) init in ZTS: Zend/zend.c

2014-10-06 Thread Anatol Belski
On Sun, October 5, 2014 21:32, Anatol Belski wrote: Hi Dmitry, On Wed, October 1, 2014 08:01, Dmitry Stogov wrote: Hi Anatol, I know, TSRM uses TLS APIs internally. In my opinion, the simplest (and probably efficient) way to get rid of TSRMLS_DC arguments and TSRMLS_FETCH calls

[PHP-DEV] Re: [PHP-CVS] com php-src: that's not char * but zend_string *: Zend/zend.c Zend/zend_string.c

2014-10-06 Thread Anatol Belski
Hi Nikita, On Sun, October 5, 2014 23:18, Nikita Popov wrote: On Thu, Sep 18, 2014 at 5:14 PM, Anatol Belski a...@php.net wrote: Commit:761e347b7526b18b9901ebf3d906b52a21fc9c4b Author:Anatol Belski a...@php.net Thu, 18 Sep 2014 17:11:48 +0200 Parents

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: fix CG(empty_string) init in ZTS: Zend/zend.c

2014-10-08 Thread Anatol Belski
Moin Dmitry, On Mon, October 6, 2014 09:01, Anatol Belski wrote: On Sun, October 5, 2014 21:32, Anatol Belski wrote: Hi Dmitry, On Wed, October 1, 2014 08:01, Dmitry Stogov wrote: Hi Anatol, I know, TSRM uses TLS APIs internally. In my opinion, the simplest (and probably

Re: [PHP-DEV] Fixes for Visual Studio 2014

2014-10-15 Thread Anatol Belski
Hi Chris, On Tue, October 14, 2014 15:35, Chris Tankersley wrote: Hello all. Partially fueled by a joke to get PHP to compile on Windows 10, and partially fueled by starting to look more into core, I found some issues with the javascript-based configuration under Windows 10 and Visual

[PHP-DEV] Re: [PHP-CVS] com php-src: fix several datatype mismatches: Zend/zend_API.h ext/standard/basic_functions.c ext/standard/basic_functions.h

2014-10-22 Thread Anatol Belski
Hi Nikita, On Wed, October 22, 2014 19:44, Nikita Popov wrote: On Wed, Oct 22, 2014 at 5:56 PM, Anatol Belski a...@php.net wrote: Commit:a5e4f1f598f3a53e5793d290619806b41f1f1380 Author:Anatol Belski a...@php.net Wed, 22 Oct 2014 17:27:33 +0200 Parents

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: fix several datatype mismatches: Zend/zend_API.h ext/standard/basic_functions.c ext/standard/basic_functions.h

2014-10-22 Thread Anatol Belski
On Wed, October 22, 2014 21:15, Nikita Popov wrote: On Wed, Oct 22, 2014 at 9:13 PM, Anatol Belski a...@php.net wrote: Hi Nikita, On Wed, October 22, 2014 19:44, Nikita Popov wrote: On Wed, Oct 22, 2014 at 5:56 PM, Anatol Belski a...@php.net wrote: Commit

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: fix several datatype mismatches: Zend/zend_API.h ext/standard/basic_functions.c ext/standard/basic_functions.h

2014-10-22 Thread Anatol Belski
On Wed, October 22, 2014 21:18, Daniel Zulla wrote: What happens if you exceed uint32? Just curious, security-wise, because AFAIR exceeding uint32 would be possible through superglobals only, which a potential attacker could abuse. param=foo

Re: [PHP-DEV] [RFC] Safe Casting Functions

2014-11-19 Thread Anatol Belski
Hi Andrea, On Wed, November 19, 2014 04:07, Andrea Faulds wrote: On 19 Nov 2014, at 03:02, Yasuo Ohgaki yohg...@ohgaki.net wrote: I would like to have DbC to harden app security as well. I'm looking for something like D language. http://dlang.org/contracts.html With DbC, checking

Re: [PHP-DEV] [RFC] Safe Casting Functions

2014-11-19 Thread Anatol Belski
On Wed, November 19, 2014 15:49, Andrea Faulds wrote: On 19 Nov 2014, at 08:33, Anatol Belski anatol@belski.net wrote: while briefly looking through the conversion examples, i see some weird results string(5) “31e+7” - shouldn't this be valid for int? The trend seems

Re: [PHP-DEV] [RFC] Safe Casting Functions

2014-11-19 Thread Anatol Belski
On Wed, November 19, 2014 19:47, Andrea Faulds wrote: __toString() always errors if it doesn’t return a string, I see no reason to change that. But in the other cases it converts strings to numbers. I mean like class A {function __toString(){return '10';}} $a = (string) (new A); //numeric

[PHP-DEV] Popups in the cgi win binaries

2014-11-26 Thread Anatol Belski
Hi, while investigating on https://bugs.php.net/bug.php?id=68297 it turned out, the MessageBox'es we have on several places lead to issues. This particular ticket describes firstly an insufficient error message, but secondly - it goes into a popup which is then automatically logged to the event

Re: [PHP-DEV] Popups in the cgi win binaries

2014-11-26 Thread Anatol Belski
On Wed, November 26, 2014 14:38, Rowan Collins wrote: Anatol Belski wrote on 26/11/2014 11:34: While it might look short cut and too late for 5.5, there's indeed no scenario imaginable where such graphical elements could be used even as a feature. Neither on console nor as a server module

Re: [PHP-DEV] Popups in the cgi win binaries

2014-11-27 Thread Anatol Belski
On Thu, November 27, 2014 13:24, Pierre Joye wrote: On Thu, Nov 27, 2014 at 3:12 AM, Anatol Belski anatol@belski.net wrote: On Wed, November 26, 2014 14:38, Rowan Collins wrote: Anatol Belski wrote on 26/11/2014 11:34: While it might look short cut and too late for 5.5, there's

[PHP-DEV] [RFC] Native TLS

2014-11-27 Thread Anatol Belski
Hi, this is a long spoken topic which is now embodied in https://wiki.php.net/rfc/native-tls . A preliminary implementation is there as well, thus we can discuss it. Regards Anatol -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [RFC] Native TLS

2014-11-27 Thread Anatol Belski
On Thu, November 27, 2014 18:03, Andrea Faulds wrote: On 27 Nov 2014, at 17:01, Joe Watkins pthre...@pthreads.org wrote: On Thu, 2014-11-27 at 16:44 +, Andrea Faulds wrote: On 27 Nov 2014, at 16:44, Andrea Faulds a...@ajf.me wrote: Hey! Would this mean we could eventually get rid

Re: [PHP-DEV] [RFC] Native TLS

2014-11-29 Thread Anatol Belski
Hi Stas, On Sat, November 29, 2014 00:05, Stanislav Malyshev wrote: Hi! this is a long spoken topic which is now embodied in https://wiki.php.net/rfc/native-tls . A preliminary implementation is there as well, thus we can discuss it. This sounds great! \o/ I understand there's no

Re: [PHP-DEV] [RFC] Native TLS

2014-12-03 Thread Anatol Belski
Hi Pierre, On Wed, December 3, 2014 02:36, Pierre Joye wrote: hi Anatol! On Fri, Nov 28, 2014 at 2:54 AM, Anatol Belski anatol@belski.net wrote: Hi, this is a long spoken topic which is now embodied in https://wiki.php.net/rfc/native-tls . A preliminary implementation

Re: [PHP-DEV] [RFC] Native TLS

2014-12-09 Thread Anatol Belski
Hi, On Mon, December 8, 2014 20:42, Ángel González wrote: On 03/12/14 10:22, Anatol Belski wrote: I meant that as well, to the time it's merged all the TSRMLS_* thingies should be removed. I kept them only while developed and now for the RFC so the diff shows the only change done

  1   2   3   4   5   6   7   >