Re: [PHP-DEV] Re: [VOTE] Deprecate dynamic properties

2022-01-09 Thread Christoph M. Becker
On 09.01.2022 at 14:15, Sebastian Bergmann wrote: > Am 26.11.2021 um 10:06 schrieb Nikita Popov: >> The RFC has been accepted with 52 votes in favor and 25 against. > > Has this been merged yet? Thanks! Yes, it has been merged on Nov 26th, 2021[1]. FWIW, it's already available on ev4l.org[2].

Re: [PHP-DEV] Re: [VOTE] Deprecate dynamic properties

2022-01-09 Thread Sebastian Bergmann
Am 26.11.2021 um 10:06 schrieb Nikita Popov: The RFC has been accepted with 52 votes in favor and 25 against. Has this been merged yet? Thanks! -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php

Re: [PHP-DEV] Re: [VOTE] Deprecate dynamic properties

2021-12-01 Thread Brady Wetherington via internals
On Wed, Dec 1, 2021 at 9:16 PM Sara Golemon wrote: > > On Tue, Nov 30, 2021 at 10:18 PM Brady Wetherington > wrote: >> >> >>> …It's been merged to master, so you could stand up a build now and point >> >>> to the many deprecation warnings you're expecting. I'm not saying send >> >>> PRs to

Re: [PHP-DEV] Re: [VOTE] Deprecate dynamic properties

2021-12-01 Thread Sara Golemon
On Tue, Nov 30, 2021 at 10:18 PM Brady Wetherington < bwethering...@grokability.com> wrote: > >>> …It's been merged to master, so you could stand up a build now and > point to the many deprecation warnings you're expecting. I'm not saying > send PRs to fix them all, just show real impact rather

Re: [PHP-DEV] Re: [VOTE] Deprecate dynamic properties

2021-12-01 Thread Larry Garfield
On Tue, Nov 30, 2021, at 10:17 PM, Brady Wetherington via internals wrote: …It's been merged to master, so you could stand up a build now and point to the many deprecation warnings you're expecting. I'm not saying send PRs to fix them all, just show real impact rather than

Re: [PHP-DEV] Re: [VOTE] Deprecate dynamic properties

2021-11-30 Thread Brady Wetherington via internals
>>> …It's been merged to master, so you could stand up a build now and point to >>> the many deprecation warnings you're expecting. I'm not saying send PRs to >>> fix them all, just show real impact rather than theoretical guessing. … > > > That’s a totally fair ask, and I’ll try and get that

Re: [PHP-DEV] Re: [VOTE] Deprecate dynamic properties

2021-11-26 Thread Brady Wetherington via internals
> > …It's been merged to master, so you could stand up a build now and point >> to the many deprecation warnings you're expecting. I'm not saying send PRs >> to fix them all, just show real impact rather than theoretical guessing. … > > That’s a totally fair ask, and I’ll try and get that done

Re: [PHP-DEV] Re: [VOTE] Deprecate dynamic properties

2021-11-26 Thread Sara Golemon
On Fri, Nov 26, 2021 at 12:16 AM Brady Wetherington via internals < internals@lists.php.net> wrote: > > > That's 1.5 million hours, which is 171 developer-years. > > > > If we're going to imagine numbers; there are 6 million PHP developers > > in the world*. If on average they each lose just 1

[PHP-DEV] Re: [VOTE] Deprecate dynamic properties

2021-11-26 Thread Nikita Popov
On Fri, Nov 12, 2021 at 2:07 PM Nikita Popov wrote: > Hi internals, > > I've opened the vote on > https://wiki.php.net/rfc/deprecate_dynamic_properties. Voting will close > 2021-11-26. > The RFC has been accepted with 52 votes in favor and 25 against. Regards, Nikita

Re: [PHP-DEV] Re: [VOTE] Deprecate dynamic properties

2021-11-25 Thread Brady Wetherington via internals
> > That's 1.5 million hours, which is 171 developer-years. > > If we're going to imagine numbers; there are 6 million PHP developers > in the world*. If on average they each lose just 1 hour per year by > making typos and accidentally creating a properties dynamically, > that's 6 million hours,

Re: [PHP-DEV] Re: [VOTE] Deprecate dynamic properties

2021-11-25 Thread Dan Ackroyd
On Fri, 26 Nov 2021 at 00:55, Brady Wetherington via internals wrote: > > That's 1.5 million hours, which is 171 developer-years. If we're going to imagine numbers; there are 6 million PHP developers in the world*. If on average they each lose just 1 hour per year by making typos and

Re: [PHP-DEV] Re: [VOTE] Deprecate dynamic properties

2021-11-25 Thread Brady Wetherington via internals
> This is a little bit overly dramatic. This isn't such a huge change that > would affect 50% of existing projects. It's likely to affect a small number > of projects in a very limited way. > It's also not true that developers will slap #[AllowDynamicProperties] on > every class. That would

Re: [PHP-DEV] Re: [VOTE] Deprecate dynamic properties

2021-11-25 Thread Kamil Tekiela
Hi Brady, This is a little bit overly dramatic. This isn't such a huge change that would affect 50% of existing projects. It's likely to affect a small number of projects in a very limited way. It's also not true that developers will slap #[AllowDynamicProperties] on every class. That would imply

[PHP-DEV] Re: [VOTE] Deprecate dynamic properties

2021-11-25 Thread Brady Wetherington via internals
Sorry for the 11th hour chime-in, but I wanted to add some context about this proposed change, and how it would likely affect our project and many others. I know the prospect of opt-in was already addressed, but I wanted to talk about what our experience would be here. (We make Snipe-IT, which is

[PHP-DEV] Re: [VOTE] Deprecate dynamic properties

2021-11-25 Thread Nikita Popov
On Fri, Nov 12, 2021 at 2:07 PM Nikita Popov wrote: > Hi internals, > > I've opened the vote on > https://wiki.php.net/rfc/deprecate_dynamic_properties. Voting will close > 2021-11-26. > > Regards, > Nikita > As a reminder, voting on this RFC closes tomorrow. I usually don't specify an exact