Re: [PHP-DEV] [RFC] Switch from json extension to jsonc [Discussion]

2013-08-30 Thread Levi Morrison
I definitely do not want a NON_STRICT mode for interpreting JSON. A NON_STRICT mode is a very bad idea, no matter how well intentioned.

Re: [PHP-DEV] [RFC] Switch from json extension to jsonc [Discussion]

2013-08-30 Thread Remi Collet
Le 30/08/2013 10:56, Jordi Boggiano a écrit : > I think it'd be best to resolve this in PHP because otherwise it means > Debian (& Fedora?) users will have the bad surprise of a quirky Debian, Fedora, Mageia, Mandriva, Ubuntu, etc. > implementation when deploying to prod, and I can imagine the >

Re: [PHP-DEV] [RFC] Switch from json extension to jsonc [Discussion]

2013-08-30 Thread Julien Pauli
On Fri, Aug 30, 2013 at 10:56 AM, Jordi Boggiano wrote: > On 29.08.2013 09:52, Zeev Suraski wrote: > > I have to say that I'm not wildly enthusiastic about making this change > over > > what appears to be a fairly minor comment in the license, and without > even > > going into the discussion as t

Re: [PHP-DEV] [RFC] Switch from json extension to jsonc [Discussion]

2013-08-30 Thread Jordi Boggiano
On 29.08.2013 09:52, Zeev Suraski wrote: > I have to say that I'm not wildly enthusiastic about making this change over > what appears to be a fairly minor comment in the license, and without even > going into the discussion as to why we want to promote Evil :) > > The main concerns I have are: >

RE: [PHP-DEV] [RFC] Switch from json extension to jsonc [Discussion]

2013-08-29 Thread Zeev Suraski
I have to say that I'm not wildly enthusiastic about making this change over what appears to be a fairly minor comment in the license, and without even going into the discussion as to why we want to promote Evil :) The main concerns I have are: * Downwards compatibility. We've found one potential

Re: [PHP-DEV] [RFC] Switch from json extension to jsonc [Discussion]

2013-08-29 Thread Remi Collet
Le 29/08/2013 09:04, Stas Malyshev a écrit : > Hi! > >> From my analysis (profiling), most of the time is spent in memory >> allocation calls. >> >> As we used a parser from a library, we do >> 1- parse in library space >> 2- object tree allocation of the result >> 3- copy result from library spac

Re: [PHP-DEV] [RFC] Switch from json extension to jsonc [Discussion]

2013-08-28 Thread Remi Collet
Le 29/08/2013 08:25, Stas Malyshev a écrit : > Also, I see the sizes of the encode results is different from ext/json. > Why is that? Stupid bench... data include some values from microtime()... Fixed. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php

Re: [PHP-DEV] [RFC] Switch from json extension to jsonc [Discussion]

2013-08-28 Thread Remi Collet
Le 29/08/2013 08:25, Stas Malyshev a écrit : > Hi! > >> Subject: Switch from json extension which have a problematic (non-free) >> license to jsonc dropin free alternative. >> >> RFC: https://wiki.php.net/rfc/free-json-parser > >>From what I see in the benchmarks, while encoding is on par with c

Re: [PHP-DEV] [RFC] Switch from json extension to jsonc [Discussion]

2013-08-28 Thread Stas Malyshev
Hi! > Subject: Switch from json extension which have a problematic (non-free) > license to jsonc dropin free alternative. > > RFC: https://wiki.php.net/rfc/free-json-parser >From what I see in the benchmarks, while encoding is on par with current implementation, decoding is more than 2x slower.