Re: [PHP-DEV] [VOTE] Deprecate autovivification on false

2021-06-23 Thread Kamil Tekiela
Hi All, The voting on https://wiki.php.net/rfc/autovivification_false has been closed. The RFC is accepted with score 34:2 (94%) Thanks, Kamil

Re: [PHP-DEV] [VOTE] Deprecate autovivification on false

2021-06-15 Thread Dmitry Stogov
Hi Kamil, PHP warnings are tricky, error handlers may cause side effects, throw exceptions, etc. Especially, for this deprecation you'll have to handle a new "slow" path (in VM and JIT) that should return back to the main path. Thanks. Dmitry. On Fri, Jun 11, 2021 at 3:13 PM Kamil Tekiela

Re: [PHP-DEV] [VOTE] Deprecate autovivification on false

2021-06-11 Thread Kamil Tekiela
Hi Dmitry, Thanks for voicing your concerns. I have started writing implementation and it is definitely challenging for me, because I am not that experienced with PHP internals yet. https://github.com/php/php-src/pull/7131 Almost every implementation requires some amount of work. I would like to

Re: [PHP-DEV] [VOTE] Deprecate autovivification on false

2021-06-11 Thread Dmitry Stogov
On Fri, Jun 11, 2021 at 12:19 PM Claude Pache wrote: > > > > > I wouldn't care about disabling autovivification on false, but I vote > "No", > > because I'm against the deprecation. > > > Do you mean, you wouldn’t care if it went directly from “working without > notice” in PHP 8.0 to “fatal

Re: [PHP-DEV] [VOTE] Deprecate autovivification on false

2021-06-11 Thread Claude Pache
> > I wouldn't care about disabling autovivification on false, but I vote "No", > because I'm against the deprecation. Do you mean, you wouldn’t care if it went directly from “working without notice” in PHP 8.0 to “fatal error” in PHP 8.1? That would be extremely hostile for large code

Re: [PHP-DEV] [VOTE] Deprecate autovivification on false

2021-06-11 Thread Dmitry Stogov
hi, I wouldn't care about disabling autovivification on false, but I vote "No", because I'm against the deprecation. Thanks. Dmitry. On Wed, Jun 9, 2021 at 11:24 PM Kamil Tekiela wrote: > Hi Internals, > > I have limited the RFC to disabling autovivification on false only, which > was the