Re: [PHP-DEV] Potential adoption of run-tests.php replacement

2018-02-05 Thread Johannes Schlüter
On So, 2018-02-04 at 01:53 -0800, Stanislav Malyshev wrote: > - Section support - I think besides TEST, the following will be > needed: > * XFAIL: unfortunately, those are still needed > * ENV: there are a lot of environment-dependent tests as it seems > * FILE_EXTERNAL: is pretty widely used > * T

Re: [PHP-DEV] Potential adoption of run-tests.php replacement

2018-02-04 Thread Stanislav Malyshev
Hi! > There is a project I've created a long time ago and still maintaining > (https://github.com/nazar-pc/phpt-tests-runner) that should be able to run > most of the tests without changes already with colored output and the whole > thing is a fraction of run-tests.php's size. Some notes: - I

Re: [PHP-DEV] Potential adoption of run-tests.php replacement

2018-02-01 Thread Stanislav Malyshev
Hi! On 1/31/18 2:50 AM, Nazar Mokrynskyi wrote: > The idea is to make filenames more descriptive and sufficient for > displaying in test results. Descriptive - sure, that'd be great, why not. Sufficient - won't happen. Filenames are not meant to describe complex things, are not suitable for it a

Re: [PHP-DEV] Potential adoption of run-tests.php replacement

2018-01-31 Thread Rowan Collins
On 31 January 2018 at 10:50, Nazar Mokrynskyi wrote: > The idea is to make filenames more descriptive and sufficient for > displaying in test results. This doesn't prevent or discourage anyone from > including description in test file itself when more details need to be > included. > Would you

Re: [PHP-DEV] Potential adoption of run-tests.php replacement

2018-01-31 Thread Nazar Mokrynskyi
The idea is to make filenames more descriptive and sufficient for displaying in test results. This doesn't prevent or discourage anyone from including description in test file itself when more details need to be included. Moreover, all of the characters from mentioned title are allowed for use i

Re: [PHP-DEV] Potential adoption of run-tests.php replacement

2018-01-30 Thread Stanislav Malyshev
Hi! > For instance, it is painful to work with tests in PHP source tree when they > are called 001.phpt, 002.phpt and so on - you need to open each file and read > it to see what it intends to test. My tool uses file names instead, which > makes browsing source tree with tests more productive a

Re: [PHP-DEV] Potential adoption of run-tests.php replacement

2018-01-29 Thread Nazar Mokrynskyi
It was never intended to be a wrapper or to be 100% compatible. It was created as a simpler and modern replacement with additional features like colored output (tried to add this to run-tests.php initially, even submitted PR with some fixes and refactoring, but found it too complex to deal with)

Re: [PHP-DEV] Potential adoption of run-tests.php replacement

2018-01-29 Thread Matt Ficken
This is a reimplementation of run-test.php, not just a wrapper (so its another parser for the PHPT file format). However, its missing support for many PHPT sections (ie its PHPT format support is incomplete). See: https://github.com/nazar-pc/phpt-tests-runner/blob/master/bin/phpt-tests-runner#L117