Re: [PHP-DEV] Small annoyances of PHP: Simple fixes would make tests fail

2021-03-05 Thread Guilliam Xavier
On Fri, Mar 5, 2021 at 4:56 PM Nikita Popov wrote: > On Fri, Mar 5, 2021 at 1:36 PM Christian Schneider > wrote: > > > There is a PR fixing both the indentation and removing the trailing > > spaces: https://github.com/php/php-src/pull/6724 > > > > Do you think this needs an RFC? > > > > Well

Re: [PHP-DEV] Small annoyances of PHP: Simple fixes would make tests fail

2021-03-05 Thread Nikita Popov
On Fri, Mar 5, 2021 at 1:36 PM Christian Schneider wrote: > Am 19.02.2021 um 16:21 schrieb Sara Golemon : > > On Fri, Feb 19, 2021 at 8:04 AM Christian Schneider < > cschn...@cschneid.com > wrote: > > Indentation in var_export: > > > > The

Re: [PHP-DEV] Small annoyances of PHP: Simple fixes would make tests fail

2021-03-05 Thread Christian Schneider
Am 19.02.2021 um 16:21 schrieb Sara Golemon : > On Fri, Feb 19, 2021 at 8:04 AM Christian Schneider > wrote: > Indentation in var_export: > > The indentation for > var_export((object)[(object)[]]); > is off by one for nested structures: >

Re: [PHP-DEV] Small annoyances of PHP: Simple fixes would make tests fail

2021-02-22 Thread Rowan Tommins
On 22/02/2021 10:14, Christian Schneider wrote: Side-note: Maybe we should recommend a function to be used for tests. At my work we used to use var_export(), some of our newer tests are using json_encode() but neither is really guaranteed to be stable, right? Well, the obvious choice to me

Re: [PHP-DEV] Small annoyances of PHP: Simple fixes would make tests fail

2021-02-22 Thread Christian Schneider
Am 19.02.2021 um 16:21 schrieb Sara Golemon : > On Fri, Feb 19, 2021 at 8:04 AM Christian Schneider > wrote: > Stack traces: > == > > What version are you testing with. I know Niki killed some unnecessary frames > in 8.0's stacktrace output. (A whole repro

Re: [PHP-DEV] Small annoyances of PHP: Simple fixes would make tests fail

2021-02-19 Thread Sara Golemon
On Fri, Feb 19, 2021 at 8:04 AM Christian Schneider wrote: > Hi there, > we encountered small annoyances over time which could be easy to fix but > would break tests. > Why does this matter? While it is easy to fix the PHP test suite they > could potentially affect other projects' code, most