Re: [PATCH] iommu/dma: Map MSI doorbell with iommu_map_atomic()

2019-12-09 Thread Jean-Philippe Brucker
On Mon, Dec 09, 2019 at 12:55:22PM +, Robin Murphy wrote: > On 09/12/2019 12:38 pm, Jean-Philippe Brucker wrote: > > Since commit 781ca2de89ba ("iommu: Add gfp parameter to > > iommu_ops::map"), iommu_map() might sleep. iommu_dma_get_msi_page() runs > > in atomic context and thus should call io

Re: [PATCH] iommu/dma: Map MSI doorbell with iommu_map_atomic()

2019-12-09 Thread Robin Murphy
On 09/12/2019 12:38 pm, Jean-Philippe Brucker wrote: Since commit 781ca2de89ba ("iommu: Add gfp parameter to iommu_ops::map"), iommu_map() might sleep. iommu_dma_get_msi_page() runs in atomic context and thus should call iommu_map_atomic() instead. Spooky... I'm rebasing my local branches and t

[PATCH] iommu/dma: Map MSI doorbell with iommu_map_atomic()

2019-12-09 Thread Jean-Philippe Brucker
Since commit 781ca2de89ba ("iommu: Add gfp parameter to iommu_ops::map"), iommu_map() might sleep. iommu_dma_get_msi_page() runs in atomic context and thus should call iommu_map_atomic() instead. Fixes: 781ca2de89ba ("iommu: Add gfp parameter to iommu_ops::map") Signed-off-by: Jean-Philippe Brucke