Re: [PATCH 1/1] iommu: Delete a duplicate check in iommu_change_dev_def_domain()

2021-06-09 Thread Joerg Roedel
On Thu, May 13, 2021 at 03:58:15PM +0800, Zhen Lei wrote: > Function iommu_group_store_type() is the only caller of the static > function iommu_change_dev_def_domain() and has performed > "if (WARN_ON(!group))" detection before calling it. So the one here is > redundant. > > Signed-off-by: Zhen Le

Re: [PATCH 1/1] iommu: Delete a duplicate check in iommu_change_dev_def_domain()

2021-06-08 Thread Will Deacon
On Thu, May 13, 2021 at 03:58:15PM +0800, Zhen Lei wrote: > Function iommu_group_store_type() is the only caller of the static > function iommu_change_dev_def_domain() and has performed > "if (WARN_ON(!group))" detection before calling it. So the one here is > redundant. > > Signed-off-by: Zhen Le

[PATCH 1/1] iommu: Delete a duplicate check in iommu_change_dev_def_domain()

2021-05-13 Thread Zhen Lei
Function iommu_group_store_type() is the only caller of the static function iommu_change_dev_def_domain() and has performed "if (WARN_ON(!group))" detection before calling it. So the one here is redundant. Signed-off-by: Zhen Lei --- drivers/iommu/iommu.c | 3 --- 1 file changed, 3 deletions(-)