Re: [PATCH v2 2/4] iommu: Add Allwinner H6 IOMMU driver

2020-04-20 Thread Robin Murphy
On 2020-04-20 3:39 pm, Maxime Ripard wrote: Hi, On Wed, Apr 08, 2020 at 04:06:49PM +0200, Joerg Roedel wrote: On Wed, Apr 01, 2020 at 01:47:10PM +0200, Maxime Ripard wrote: As far as I understand it, the page table can be accessed concurrently since the framework doesn't seem to provide any

Re: [PATCH v2 2/4] iommu: Add Allwinner H6 IOMMU driver

2020-04-20 Thread Maxime Ripard
Hi, On Wed, Apr 08, 2020 at 04:06:49PM +0200, Joerg Roedel wrote: > On Wed, Apr 01, 2020 at 01:47:10PM +0200, Maxime Ripard wrote: > > As far as I understand it, the page table can be accessed concurrently > > since the framework doesn't seem to provide any serialization / > > locking, shouldn't

Re: [PATCH v2 2/4] iommu: Add Allwinner H6 IOMMU driver

2020-04-08 Thread Joerg Roedel
Hi Maxime, On Wed, Apr 01, 2020 at 01:47:10PM +0200, Maxime Ripard wrote: > As far as I understand it, the page table can be accessed concurrently > since the framework doesn't seem to provide any serialization / > locking, shouldn't we have some locks to prevent concurrent access? The dma-iommu

Re: [PATCH v2 2/4] iommu: Add Allwinner H6 IOMMU driver

2020-04-01 Thread Maxime Ripard
Hi Jörg, Thanks for your review, I'll fix the issues you pointed out and I left out. On Mon, Mar 02, 2020 at 04:36:06PM +0100, Joerg Roedel wrote: > On Thu, Feb 20, 2020 at 07:15:14PM +0100, Maxime Ripard wrote: > > +struct sun50i_iommu_domain { > > + struct iommu_domain domain; > > + > > +

Re: [PATCH v2 2/4] iommu: Add Allwinner H6 IOMMU driver

2020-03-02 Thread Joerg Roedel
Hi Maxime, On Thu, Feb 20, 2020 at 07:15:14PM +0100, Maxime Ripard wrote: > +struct sun50i_iommu_domain { > + struct iommu_domain domain; > + > + /* Number of devices attached to the domain */ > + refcount_t refcnt; > + > + /* Lock to modify the Directory Table */ > +