Re: [PATCH 1/2 V2] iommu/amd: Add workaround for ERBT1312

2013-04-18 Thread Joerg Roedel
On Thu, Apr 18, 2013 at 01:56:42PM -0500, Suthikulpanit, Suravee wrote: > On 4/18/2013 1:35 PM, Joerg Roedel wrote: > According to the "kernel/irq/handle.c:irq_wake_thread()", I thought > that for the threaded IRQ, if the system getting a new interrupt > from the device while the thread is running

Re: [PATCH] documentation: iommu: add description of ARM System MMU binding

2013-04-18 Thread Will Deacon
Hi Olav, On Tue, Apr 16, 2013 at 07:18:42PM +0100, Olav Haugan wrote: > On 4/15/2013 6:13 AM, Will Deacon wrote: > > If so, doesn't that strongly tie your video driver to the SMMU? > > Isn't this more or less what you are doing in DT where you associate > specific devices with an IOMMU (mmu-maste

Re: [PATCH 1/2 V2] iommu/amd: Add workaround for ERBT1312

2013-04-18 Thread Suravee Suthikulpanit
On 4/18/2013 1:35 PM, Joerg Roedel wrote: On Thu, Apr 18, 2013 at 11:59:58AM -0500, Suthikulpanit, Suravee wrote: One last concern I have for this patch is the case when we re-enable the interrupt, then another interrupt happens while we processing the log and set the bit. If the interrupt thre

Re: [PATCH 1/2 V2] iommu/amd: Add workaround for ERBT1312

2013-04-18 Thread Joerg Roedel
On Thu, Apr 18, 2013 at 11:59:58AM -0500, Suthikulpanit, Suravee wrote: > One last concern I have for this patch is the case when we re-enable > the interrupt, then another interrupt happens while we processing > the log and set the bit. If the interrupt thread doesn't check this > right before th

Re: [PATCH 1/2 V2] iommu/amd: Add workaround for ERBT1312

2013-04-18 Thread Suravee Suthikulanit
Joerg, One last concern I have for this patch is the case when we re-enable the interrupt, then another interrupt happens while we processing the log and set the bit. If the interrupt thread doesn't check this right before the thread exits the handler. We could still end up leaving the inte

Re: [PATCH 2/2 V5] iommu/amd: Add logic to decode AMD IOMMU event flag

2013-04-18 Thread Suravee Suthikulanit
Joerg, Do you have any more concerns about this patch? Thank you, Suravee On 4/10/2013 10:57 AM, suravee.suthikulpa...@amd.com wrote: From: Suravee Suthikulpanit Add logic to decode AMD IOMMU event flag based on information from AMD IOMMU specification. This should simplify debugging IOMMU

Re: [PATCH 1/2 V2] iommu/amd: Add workaround for ERBT1312

2013-04-18 Thread Joerg Roedel
On Thu, Apr 18, 2013 at 11:13:19AM -0500, Suravee Suthikulanit wrote: > This workaround is required for both event log and ppr log. Your > patch is only taking care of the event log. Right, thanks for the notice. Here is the updated patch. >From cebe04596989c4b9001e2c1571c4fb219ea37b99 Mon Sep 1

Re: [PATCH 1/2 V2] iommu/amd: Add workaround for ERBT1312

2013-04-18 Thread Suravee Suthikulanit
Joerg, This workaround is required for both event log and ppr log. Your patch is only taking care of the event log. Suravee On 4/18/2013 11:02 AM, Joerg Roedel wrote: On Mon, Apr 15, 2013 at 02:07:46AM -0500, suravee.suthikulpa...@amd.com wrote: drivers/iommu/amd_iommu.c | 145 +

Re: [PATCH 1/2 V2] iommu/amd: Add workaround for ERBT1312

2013-04-18 Thread Joerg Roedel
On Mon, Apr 15, 2013 at 02:07:46AM -0500, suravee.suthikulpa...@amd.com wrote: > drivers/iommu/amd_iommu.c | 145 > + That is way too much for a simple erratum workaround, and too much for a stable backport. I queued the patch below instead, which has