Re: [PATCH 2/4] iommu: add ARM LPAE page table allocator

2014-12-05 Thread Will Deacon
On Tue, Dec 02, 2014 at 11:47:36AM +, Laurent Pinchart wrote: > On Tuesday 02 December 2014 09:41:56 Will Deacon wrote: > > On Mon, Dec 01, 2014 at 08:21:58PM +, Laurent Pinchart wrote: > > > On Monday 01 December 2014 17:23:15 Will Deacon wrote: > > > > On Sun, Nov 30, 2014 at 11:29:46PM +

Re: [PATCH 2/4] iommu: add ARM LPAE page table allocator

2014-12-05 Thread Will Deacon
On Fri, Dec 05, 2014 at 10:55:11AM +, Varun Sethi wrote: > Hi Will, Hi Varun, Thanks for the review! > +static int arm_lpae_init_pte(struct arm_lpae_io_pgtable *data, > +unsigned long iova, phys_addr_t paddr, > +arm_lpae_iopte prot, int

Re: [GIT PULL] Automatic DMA configuration for OF-based IOMMU masters

2014-12-05 Thread Arnd Bergmann
On Friday 05 December 2014 16:35:06 Will Deacon wrote: > Hi Olof, > > Please consider pulling the following series for 3.19. I appreciate that > this is late in the day, but the patches have been around for a while and > have collected all the Acks that they need. Marek has already been finding >

[GIT PULL] Automatic DMA configuration for OF-based IOMMU masters

2014-12-05 Thread Will Deacon
Hi Olof, Please consider pulling the following series for 3.19. I appreciate that this is late in the day, but the patches have been around for a while and have collected all the Acks that they need. Marek has already been finding the series useful with the Exynos IOMMU, so it seems a pity to hold

Re: [PATCH v6 1/8] iommu: provide early initialisation hook for IOMMU drivers

2014-12-05 Thread Marek Szyprowski
Hello, On 2014-12-05 14:18, Thierry Reding wrote: On Fri, Dec 05, 2014 at 01:06:52PM +, Grant Likely wrote: On Fri, Dec 5, 2014 at 12:35 PM, Robin Murphy wrote: Hi Will, On 05/12/14 12:10, Will Deacon wrote: [...] Do you expect drivers to modify that *priv pointer after the ops structur

Re: [PATCH v6 1/8] iommu: provide early initialisation hook for IOMMU drivers

2014-12-05 Thread Thierry Reding
On Fri, Dec 05, 2014 at 01:21:31PM +, Grant Likely wrote: > On Fri, Dec 5, 2014 at 1:18 PM, Thierry Reding > wrote: > > On Fri, Dec 05, 2014 at 01:06:52PM +, Grant Likely wrote: > >> On Fri, Dec 5, 2014 at 12:35 PM, Robin Murphy wrote: > >> > Hi Will, > >> > > >> > On 05/12/14 12:10, Wil

Re: [PATCH v6 1/8] iommu: provide early initialisation hook for IOMMU drivers

2014-12-05 Thread Grant Likely
On Fri, Dec 5, 2014 at 1:18 PM, Thierry Reding wrote: > On Fri, Dec 05, 2014 at 01:06:52PM +, Grant Likely wrote: >> On Fri, Dec 5, 2014 at 12:35 PM, Robin Murphy wrote: >> > Hi Will, >> > >> > On 05/12/14 12:10, Will Deacon wrote: >> > [...] >> >> Do you expect drivers to modify th

Re: [PATCH v6 1/8] iommu: provide early initialisation hook for IOMMU drivers

2014-12-05 Thread Thierry Reding
On Fri, Dec 05, 2014 at 01:06:52PM +, Grant Likely wrote: > On Fri, Dec 5, 2014 at 12:35 PM, Robin Murphy wrote: > > Hi Will, > > > > On 05/12/14 12:10, Will Deacon wrote: > > [...] > > Do you expect drivers to modify that *priv pointer after the ops > structure is registered? I

Re: [PATCH v6 1/8] iommu: provide early initialisation hook for IOMMU drivers

2014-12-05 Thread Grant Likely
On Fri, Dec 5, 2014 at 12:35 PM, Robin Murphy wrote: > Hi Will, > > On 05/12/14 12:10, Will Deacon wrote: > [...] Do you expect drivers to modify that *priv pointer after the ops structure is registered? I'd be very surprised if that was the use case. It's fine for the driver t

Re: [PATCH v6 1/8] iommu: provide early initialisation hook for IOMMU drivers

2014-12-05 Thread Robin Murphy
Hi Will, On 05/12/14 12:10, Will Deacon wrote: [...] Do you expect drivers to modify that *priv pointer after the ops structure is registered? I'd be very surprised if that was the use case. It's fine for the driver to register a non-const version, but once it is registered, the infrastructure c

Re: [PATCH v6 1/8] iommu: provide early initialisation hook for IOMMU drivers

2014-12-05 Thread Arnd Bergmann
On Friday 05 December 2014 12:10:37 Will Deacon wrote: > On Thu, Dec 04, 2014 at 07:42:28PM +, Robin Murphy wrote: > > On 04/12/14 17:58, Grant Likely wrote: > > [...] > > +struct of_iommu_node { > > + struct list_head list; > > + struct device_node *np; > > +

Re: [PATCH v6 0/8] Introduce automatic DMA configuration for IOMMU masters

2014-12-05 Thread Will Deacon
On Fri, Dec 05, 2014 at 07:12:24AM +, Olof Johansson wrote: > On Mon, Dec 1, 2014 at 8:57 AM, Will Deacon wrote: > > Hello again, > > > > This is version 6 of the patches previously posted here: > > > > RFCv1: > > http://lists.infradead.org/pipermail/linux-arm-kernel/2014-August/283023.html

Re: [PATCH v6 1/8] iommu: provide early initialisation hook for IOMMU drivers

2014-12-05 Thread Will Deacon
On Thu, Dec 04, 2014 at 07:42:28PM +, Robin Murphy wrote: > On 04/12/14 17:58, Grant Likely wrote: > [...] > +struct of_iommu_node { > + struct list_head list; > + struct device_node *np; > + struct iommu_ops *ops; > >>> > >>> > >>> Why can't this be const?

RE: [PATCH 2/4] iommu: add ARM LPAE page table allocator

2014-12-05 Thread Varun Sethi
Hi Will, Please find my comments inline. Search for "varun" -Original Message- From: Will Deacon [mailto:will.dea...@arm.com] Sent: Thursday, November 27, 2014 5:21 PM To: linux-arm-ker...@lists.infradead.org; iommu@lists.linux-foundation.org Cc: prem.malla...@broadcom.com; robin.mur...@a

Re: [PATCH v3 00/19] Exynos SYSMMU (IOMMU) integration with DT and DMA-mapping subsystem

2014-12-05 Thread Marek Szyprowski
Hello, On 2014-12-02 10:59, Sjoerd Simons wrote: Hey Marek, Inki, On Wed, 2014-11-19 at 12:15 +0100, Marek Szyprowski wrote: Hello Everyone, This is another attempt to finally make Exynos SYSMMU driver fully integrated with DMA-mapping subsystem. The main change from previous version is a reb