Re: [PATCH 1/2] mm/cma: remove unsupported gfp_mask parameter from cma_alloc()

2018-07-12 Thread Joonsoo Kim
2018-07-12 16:15 GMT+09:00 Christoph Hellwig : > On Thu, Jul 12, 2018 at 11:48:47AM +0900, Joonsoo Kim wrote: >> One of existing user is general DMA layer and it takes gfp flags that is >> provided by user. I don't check all the DMA allocation sites but how do >> you convince that none of them try

Re: [PATCH v4 9/9] iommu/vt-d: Remove the obsolete per iommu pasid tables

2018-07-12 Thread Peter Xu
On Fri, Jul 13, 2018 at 09:34:30AM +0800, Lu Baolu wrote: > Hi Peter, > > Do you have further comments for this series? I will work out a > new version if there are no ones. Not for now. Though since you mentioned about the work to remove the pasid state table, not sure whether it'll be nice to

Re: [PATCH 1/1] iommu/arm-smmu-v3: prevent any devices access to memory without registration

2018-07-12 Thread Hanjun Guo
On 2018/7/13 9:48, Leizhen (ThunderTown) wrote: > > > On 2018/7/13 1:01, Will Deacon wrote: >> On Thu, Jul 12, 2018 at 05:28:43PM +0800, Zhen Lei wrote: >>> Stream bypass is not security. A malicious device can be hot plugged >>> without match any drivers, but it can access to any memory. So chan

Re: [PATCH 1/1] iommu/arm-smmu-v3: prevent any devices access to memory without registration

2018-07-12 Thread Leizhen (ThunderTown)
On 2018/7/13 1:01, Will Deacon wrote: > On Thu, Jul 12, 2018 at 05:28:43PM +0800, Zhen Lei wrote: >> Stream bypass is not security. A malicious device can be hot plugged >> without match any drivers, but it can access to any memory. So change to >> disable bypass by default. >> >> Signed-off-by:

Re: [PATCH v4 9/9] iommu/vt-d: Remove the obsolete per iommu pasid tables

2018-07-12 Thread Lu Baolu
Hi Peter, Do you have further comments for this series? I will work out a new version if there are no ones. Thank you for reviewing my patches. Do you allow me to add your reviewed-by to the patches which you've reviewed? Best regards, Lu Baolu On 07/11/2018 10:45 AM, Peter Xu wrote: > On Mon,

Re: [PATCH 1/1] iommu/arm-smmu-v3: prevent any devices access to memory without registration

2018-07-12 Thread Will Deacon
On Thu, Jul 12, 2018 at 05:28:43PM +0800, Zhen Lei wrote: > Stream bypass is not security. A malicious device can be hot plugged > without match any drivers, but it can access to any memory. So change to > disable bypass by default. > > Signed-off-by: Zhen Lei > --- > drivers/iommu/arm-smmu-v3.c

Re: [PATCH v12 3/4] iommu/arm-smmu: Add the device_link between masters and smmu

2018-07-12 Thread Vivek Gautam
Hi Rafael, On Wed, Jul 11, 2018 at 4:06 PM, Vivek Gautam wrote: > Hi Rafael, > > > > On 7/11/2018 3:23 PM, Rafael J. Wysocki wrote: >> >> On Sunday, July 8, 2018 7:34:12 PM CEST Vivek Gautam wrote: >>> >>> From: Sricharan R >>> >>> Finally add the device link between the master device and >>> s

Re: [PATCH v12 1/4] iommu/arm-smmu: Add pm_runtime/sleep ops

2018-07-12 Thread Vivek Gautam
Hi, On Wed, Jul 11, 2018 at 6:21 PM, Tomasz Figa wrote: > On Wed, Jul 11, 2018 at 8:11 PM Rafael J. Wysocki wrote: >> >> On Wed, Jul 11, 2018 at 12:55 PM, Vivek Gautam >> wrote: >> > Hi Rafael, >> > >> > >> > On Wed, Jul 11, 2018 at 3:20 PM, Rafael J. Wysocki >> > wrote: >> >> On Sunday, Jul

[PATCH 1/1] iommu/arm-smmu-v3: prevent any devices access to memory without registration

2018-07-12 Thread Zhen Lei
Stream bypass is not security. A malicious device can be hot plugged without match any drivers, but it can access to any memory. So change to disable bypass by default. Signed-off-by: Zhen Lei --- drivers/iommu/arm-smmu-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dri

Re: [PATCH] iommu/iova: Update cached node pointer when current node fails to get any free IOVA

2018-07-12 Thread Ganapatrao Kulkarni
Hi Robin, On Mon, Jun 4, 2018 at 9:36 AM, Ganapatrao Kulkarni wrote: > ping?? > > On Mon, May 21, 2018 at 6:45 AM, Ganapatrao Kulkarni > wrote: >> On Thu, Apr 26, 2018 at 3:15 PM, Ganapatrao Kulkarni >> wrote: >>> Hi Robin, >>> >>> On Mon, Apr 23, 2018 at 11:11 PM, Ganapatrao Kulkarni >>> w

Re: [RFC PATCH 1/4] dma-mapping: Generalise dma_32bit_limit flag

2018-07-12 Thread Christoph Hellwig
On Wed, Jul 11, 2018 at 05:56:40PM +0100, Robin Murphy wrote: > Indeed, once we've found an approach that everyone's happy with we can have > a more thorough audit of exactly where else it needs to be applied. FWIW > I'm not aware of any 32-bit Arm systems affected by this*, but if they do > exi

Re: [PATCH 1/2] mm/cma: remove unsupported gfp_mask parameter from cma_alloc()

2018-07-12 Thread Christoph Hellwig
On Thu, Jul 12, 2018 at 11:48:47AM +0900, Joonsoo Kim wrote: > One of existing user is general DMA layer and it takes gfp flags that is > provided by user. I don't check all the DMA allocation sites but how do > you convince that none of them try to use anything other > than GFP_KERNEL [|__GFP_NOWA