[PATCH 1/5] iommu/arm-smmu: Make all valid stream mappings BYPASS

Turn all stream mappings marked as valid into BYPASS. This allows the platform specific implementation to configure stream mappings to match the boot loader's configuration for e.g. display to continue to function through the reset of the SMMU. Suggested-by: Robin Murphy Signed-off-by: Bjorn

[PATCH 2/5] iommu/arm-smmu: Emulate bypass by using context banks

translation. Signed-off-by: Bjorn Andersson --- drivers/iommu/arm-smmu-qcom.c | 21 + drivers/iommu/arm-smmu.c | 14 -- drivers/iommu/arm-smmu.h | 3 +++ 3 files changed, 36 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/arm-smmu-qcom.c b/drivers

[PATCH 0/5] iommu/arm-smmu: Support maintaining bootloader mappings

to allow booting SDM845, SDM850, SM8150, SM8250 with boot splash screen setup by the bootloader. Specifically it also allows the Lenovo Yoga C630 to boot with SMMU and efifb enabled. Bjorn Andersson (5): iommu/arm-smmu: Make all valid stream mappings BYPASS iommu/arm-smmu: Emulate bypass

[PATCH 5/5] iommu/arm-smmu: Setup identity domain for boot mappings

context bank is used and streams are diverted here during initialization. This also performs the readback of SMR registers for the Qualcomm platform, to trigger the mechanism. This is based on prior work by Thierry Reding and Laurentiu Tudor. Signed-off-by: Bjorn Andersson --- drivers/iommu/arm-smmu

Re: [PATCH v2 0/8] arm64: dts: qcom: smmu/USB nodes and HDK855/HDK865 dts

On Fri 03 Jul 05:31 PDT 2020, Will Deacon wrote: > On Tue, Jun 09, 2020 at 03:40:18PM -0400, Jonathan Marek wrote: > > Add dts nodes for apps_smmu and USB for both sm8150 and sm8250. > > > > Also add initial dts files for HDK855 and HDK865, based on mtp dts, with a > > few changes. Notably, the

Re: [PATCH v2 2/8] iommu: arm-smmu-impl: Use qcom impl for sm8150 and sm8250 compatibles

On Tue 09 Jun 12:40 PDT 2020, Jonathan Marek wrote: > Use the qcom implementation for IOMMU hardware on sm8150 and sm8250 SoCs. > > Signed-off-by: Jonathan Marek Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/iommu/arm-smmu-impl.c | 4 +++- > 1 file changed,

Re: [PATCH 1/1] iommu/arm-smmu: Implement qcom,skip-init

On Sat 04 Jul 06:09 PDT 2020, Will Deacon wrote: > [Adding Bjorn, Jordan and John because I really don't want a bunch of > different ways to tell the driver that the firmware is screwing things up] > Thanks Will. > On Sat, Jul 04, 2020 at 02:28:09PM +0200, Konrad Dybcio wrote: > > This adds

Re: [RFC 0/2] iommu: arm-smmu: Add support for early direct mappings

On Wed 03 Jun 04:00 PDT 2020, Robin Murphy wrote: > On 2020-06-02 07:32, Bjorn Andersson wrote: > > On Wed 27 May 04:03 PDT 2020, Will Deacon wrote: > > > > > Hi John, Bjorn, > > > > > > On Tue, May 26, 2020 at 01:34:45PM -0700, John Stultz wrote: >

Re: [RFC][PATCH 4/5] pinctrl: qcom: Allow pinctrl-msm code to be loadable as a module

SCM || QCOM_SCM=n" on all entries in the Kconfig that selects PINCTRL_MSM, or switch PINCTRL_MSM to be user selectable and make all the others depend on it. > Cc: Andy Gross > Cc: Bjorn Andersson > Cc: Joerg Roedel > Cc: Thomas Gleixner > Cc: Jason Cooper > Cc: Marc

Re: [RFC 0/2] iommu: arm-smmu: Add support for early direct mappings

On Wed 03 Jun 03:24 PDT 2020, Thierry Reding wrote: > On Tue, Jun 02, 2020 at 12:32:49PM -0700, Bjorn Andersson wrote: > > On Tue 02 Jun 04:02 PDT 2020, Thierry Reding wrote: > > > > > On Wed, May 27, 2020 at 12:03:44PM +0100, Will Deacon wrote: > > > > Hi

Re: [RFC 0/2] iommu: arm-smmu: Add support for early direct mappings

On Wed 03 Jun 04:11 PDT 2020, Will Deacon wrote: > On Mon, Jun 01, 2020 at 11:32:10PM -0700, Bjorn Andersson wrote: > > On Wed 27 May 04:03 PDT 2020, Will Deacon wrote: > > > > > Hi John, Bjorn, > > > > > > On Tue, May 26, 2020 at 01:34:45PM -0700,

Re: [RFC 0/2] iommu: arm-smmu: Add support for early direct mappings

> > > > > On Thu 27 Feb 18:57 PST 2020, Bjorn Andersson wrote: > > > > > > > > Rob, Will, we're reaching the point where upstream has enough > > > > functionality that this is becoming a critical issue for us. > > > > > > >

Re: [RFC 0/2] iommu: arm-smmu: Add support for early direct mappings

On Wed 27 May 04:03 PDT 2020, Will Deacon wrote: > Hi John, Bjorn, > > On Tue, May 26, 2020 at 01:34:45PM -0700, John Stultz wrote: > > On Thu, May 14, 2020 at 12:34 PM wrote: > > > > > > On Thu 27 Feb 18:57 PST 2020, Bjorn Andersson wrote: > > > >

Re: [PATCH v2] iommu/qcom: add optional 'tbu' clock for TLB invalidate

tional clock, so that platforms that have this > clock can pass it over DT. > > While adding the third clock, let's switch to bulk clk API to simplify > the enable/disable calls. clk_bulk_get() cannot used because the > existing two clocks are required while the new one is optio

Re: [RFC 0/2] iommu: arm-smmu: Add support for early direct mappings

On Thu 27 Feb 18:57 PST 2020, Bjorn Andersson wrote: Rob, Will, we're reaching the point where upstream has enough functionality that this is becoming a critical issue for us. E.g. Lenovo Yoga C630 is lacking this and a single dts patch to boot mainline with display, GPU, WiFi and audio working

Re: [PATCH] iommu/qcom: add optional clock for TLB invalidate

On Thu 14 May 07:39 PDT 2020, Shawn Guo wrote: > Hi Bjorn, > > On Mon, May 11, 2020 at 10:52:42PM -0700, Bjorn Andersson wrote: > > On Sat 09 May 06:08 PDT 2020, Shawn Guo wrote: > > > > > On some SoCs like MSM8939 with A405 adreno, there is a gfx_tbu clock > &

Re: [PATCH] iommu/qcom: add optional clock for TLB invalidate

On Sat 09 May 06:08 PDT 2020, Shawn Guo wrote: > On some SoCs like MSM8939 with A405 adreno, there is a gfx_tbu clock > needs to be on while doing TLB invalidate. Otherwise, TLBSYNC status > will not be correctly reflected, causing the system to go into a bad > state. Add it as an optional

Re: [PATCH -next] iommu/msm: Make msm_iommu_lock static

On Mon 11 May 19:17 PDT 2020, Samuel Zou wrote: > Fix the following sparse warning: > > drivers/iommu/msm_iommu.c:37:1: warning: symbol 'msm_iommu_lock' was not > declared. > > The msm_iommu_lock has only call site within msm_iommu.c > It should be static > Revi

Re: [PATCH v6] iommu/arm-smmu-qcom: Request direct mapping for modem device

programming the modem SIDs to the > kernel. Let's add compatibles here so that we can have the kernel > program the SIDs for the modem in these cases. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Sibi Sankar > --- > > V6 > * Rebased on Will's fo

Re: [PATCH v2]iommu/qcom:fix local_base status check

On Sat 18 Apr 06:47 PDT 2020, Tang Bin wrote: > The function qcom_iommu_device_probe() does not perform sufficient > error checking after executing devm_ioremap_resource(), which can > result in crashes if a critical error path is encountered. > Thanks, that's much better. Review

Re: [PATCH] iommu/qcom:fix local_base status check

On Wed 01 Apr 23:33 PDT 2020, Tang Bin wrote: > Release resources when exiting on error. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Tang Bin > --- > drivers/iommu/qcom_iommu.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > di

Re: [RFC 0/2] iommu: arm-smmu: Add support for early direct mappings

On Mon 09 Dec 07:07 PST 2019, Thierry Reding wrote: > From: Thierry Reding > Sorry for the slow response on this, finally got the time to go through this in detail and try it out on some Qualcomm boards. > On some platforms, the firmware will setup hardware to read from a given > region of

Re: [PATCH 1/2] iommu: arm-smmu-impl: Convert to a generic reset implementation

on. Also add SC7180 SMMU > compatible for calling into QCOM specific implementation. > > Signed-off-by: Sai Prakash Ranjan Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/iommu/arm-smmu-impl.c | 8 +--- > drivers/iommu/arm-smmu-qcom.c | 16 +--- >

Re: [RFC 0/2] iommu: arm-smmu: Add support for early direct mappings

On Mon 13 Jan 14:01 PST 2020, Saravana Kannan wrote: > I added everyone from the other thread, but somehow managed to miss > the Bjorn who sent the emails! Fixing that now. > Thanks for looping me in Saravana. > On Mon, Jan 13, 2020 at 6:07 AM Thierry Reding > wrote: > > > > On Fri, Jan 10,

[PATCH 2/3] iommu/arm-smmu: Expose s2cr and smr structs to impl

Move the arm_smmu_s2cr and arm_smmu_smr structs to the internal header file, in order to expose them to the platform specific arm-smmu implementations. Signed-off-by: Bjorn Andersson --- Changes since RFC: - New patch drivers/iommu/arm-smmu.c | 14 -- drivers/iommu/arm-smmu.h | 14

[PATCH 0/3] iommu/arm-smmu: Qualcomm bootsplash/efifb

then involves the rebase and migration of the read-back code to the Qualcomm specific implementation, the mapping is maintained indefinitely - to handle probe deferring clients - and rewritten commit messages. [1] https://lore.kernel.org/linux-arm-msm/20190605210856.20677-1-bjorn.anders...@linaro.org/ Bjorn

[PATCH 3/3] iommu/arm-smmu: Allow inherting stream mapping from bootloader

the code to the Qualcomm implementation for reading out the stream mapping from the bootloader, with the result of maintaining the display hardware's access to DDR until the context bank is enabled. Heavily based on downstream implementation by Patrick Daly . Signed-off-by: Bjorn Andersson --- Changes

[PATCH 1/3] iommu/arm-smmu: Don't blindly use first SMR to calculate mask

With the SMRs inherited from the bootloader the first SMR might actually be valid and in use. As such probing the SMR mask using the first SMR might break a stream in use. Search for an unused stream and use this to probe the SMR mask. Signed-off-by: Bjorn Andersson --- Changes since RFC

Re: [PATCHv7 0/3] QCOM smmu-500 wait-for-safe handling for sdm845

t; > > > comment > > > > on this. > > > > > > The rumors of my demise have been greatly exaggerated. All kidding > > > aside, I > > > ack'ed both. Bjorn will indeed be coming on as a co-maintener at some > > > point. > >

Re: [PATCHv7 3/3] iommu: arm-smmu-impl: Add sdm845 implementation hook

ime dd if=/dev/sda of=/dev/zero bs=1048576 count=300 conv=sync > 300+0 records in > 300+0 records out > 314572800 bytes (300.0MB) copied, 1.030541 seconds, 291.1MB/s > real 0m 1.03s > user0m 0.00s > sys 0m 0.54s > > Signed-off-by: Vivek Gautam > Reviewed-by: R

Re: [PATCH v4 0/7] Add support for QCOM IOMMU v2 and 500

On Tue 01 Oct 15:01 PDT 2019, khol...@gmail.com wrote: > From: AngeloGioacchino Del Regno > > Some Qualcomm Family-B SoCs have got a different version of the QCOM > IOMMU, specifically v2 and 500, which perfectly adhere to the current > qcom_iommu driver, but need some variations due to

Re: [PATCHv6 3/3] iommu: arm-smmu-impl: Add sdm845 implementation hook

On Tue 17 Sep 02:45 PDT 2019, Sai Prakash Ranjan wrote: > From: Vivek Gautam > > Add reset hook for sdm845 based platforms to turn off > the wait-for-safe sequence. > > Understanding how wait-for-safe logic affects USB and UFS performance > on MTP845 and DB845 boards: > > Qcom's

Re: [PATCH 3/4] remoteproc: don't allow modular build

; can remove the dma_declare_coherent_memory export and prevent other > drivers from "accidentally" using it like remoteproc. Note that the > driver would also leak the declared coherent memory on unload if it > actually was built as a module at the moment. > > Signed-off-by: C

Re: [PATCH v3 4/4] arm64: dts/sdm845: Enable FW implemented safe sequence handler on MTP

On Sun 11 Aug 09:08 PDT 2019, Vivek Gautam wrote: > On Tue, Aug 6, 2019 at 3:56 AM Bjorn Andersson > wrote: > > > > On Wed 12 Jun 00:15 PDT 2019, Vivek Gautam wrote: > > > > > Indicate on MTP SDM845 that firmware implements handler to > > > TLB inval

Re: [PATCH v3 1/4] firmware: qcom_scm-64: Add atomic version of qcom_scm_call

8191b38ef086274943f353ea7") > > > > > > Signed-off-by: Vivek Gautam > > > Reviewed-by: Bjorn Andersson > > > --- > > > drivers/firmware/qcom_scm-64.c | 136 > > > - > > > 1 file changed, 92

Re: [PATCH v3 4/4] arm64: dts/sdm845: Enable FW implemented safe sequence handler on MTP

On Wed 12 Jun 00:15 PDT 2019, Vivek Gautam wrote: > Indicate on MTP SDM845 that firmware implements handler to > TLB invalidate erratum SCM call where SAFE sequence is toggled > to achieve optimum performance on real-time clients, such as > display and camera. > > Signed-off-by: Vivek Gautam >

Re: [PATCH v2 1/2] arm64: dts: qcom: msm8998: Add ANOC1 SMMU node

On Mon 01 Apr 08:40 PDT 2019, Marc Gonzalez wrote: > The MSM8998 ANOC1(*) SMMU services BLSP2, PCIe, UFS, and USB. > (*) Aggregate Network-on-Chip #1 > > Based on the following DTS downstream: >

Re: [PATCH v3 4/4] arm64: dts/sdm845: Enable FW implemented safe sequence handler on MTP

f-by: Vivek Gautam Reviewed-by: Bjorn Andersson > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi > b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index 78ec373a2b18..6a73d9744a71 100644 >

Re: [PATCH v3 3/4] iommu/arm-smmu: Add support to handle Qcom's wait-for-safe logic

mu-500") > && > + smmu->options & ARM_SMMU_OPT_QCOM_FW_IMPL_SAFE_ERRATA) { > + err = qcom_scm_qsmmu500_wait_safe_toggle(0); > + if (err) > + dev_warn(dev, "Failed to turn off SAFE logic\n"); > +

Re: [RFC 1/2] iommu: arm-smmu: Handoff SMR registers and context banks

On Thu 13 Jun 04:23 PDT 2019, Robin Murphy wrote: > On 05/06/2019 22:08, Bjorn Andersson wrote: > > Boot splash screen or EFI framebuffer requires the display hardware to > > operate while the Linux iommu driver probes. Therefore, we cannot simply > > wipe out the SMR registe

Re: [RFC 1/2] iommu: arm-smmu: Handoff SMR registers and context banks

On Wed 12 Jun 11:07 PDT 2019, Jeffrey Hugo wrote: > On Wed, Jun 5, 2019 at 3:09 PM Bjorn Andersson > wrote: > > > > Boot splash screen or EFI framebuffer requires the display hardware to > > operate while the Linux iommu driver probes. Therefore, we cannot simply >

Re: [RFC 2/2] iommu: arm-smmu: Don't blindly use first SMR to calculate mask

On Wed 12 Jun 10:58 PDT 2019, Jeffrey Hugo wrote: > On Wed, Jun 5, 2019 at 3:09 PM Bjorn Andersson > wrote: > > > > With the SMRs inherited from the bootloader the first SMR might actually > > be valid and in use. As such probing the SMR mask using the first SMR > &g

[RFC 2/2] iommu: arm-smmu: Don't blindly use first SMR to calculate mask

With the SMRs inherited from the bootloader the first SMR might actually be valid and in use. As such probing the SMR mask using the first SMR might break a stream in use. Search for an unused stream and use this to probe the SMR mask. Signed-off-by: Bjorn Andersson --- drivers/iommu/arm-smmu.c

[RFC 1/2] iommu: arm-smmu: Handoff SMR registers and context banks

they are associated with. Reserve these context banks for the first Linux device whose stream-id matches the SMR register. Any existing page-tables will be discarded. Heavily based on downstream implementation by Patrick Daly . Signed-off-by: Bjorn Andersson --- drivers/iommu/arm-smmu-regs.h | 2

[RFC 0/2] iommu: arm-smmu: Inherit SMR and CB config during init

, writes to the SMR registers are ignored. But as we inherit the preconfigured mapping from the bootloader we can use the arm-smmu driver on these platforms. Bjorn Andersson (2): iommu: arm-smmu: Handoff SMR registers and context banks iommu: arm-smmu: Don't blindly use first SMR to calculate mask

Re: [PATCH] iommu: io-pgtable: Support non-coherent page tables

On Wed 15 May 23:47 PDT 2019, Vivek Gautam wrote: > On Thu, May 16, 2019 at 5:03 AM Bjorn Andersson > wrote: > > > > Describe the memory related to page table walks as non-cachable for iommu > > instances that are not DMA coherent. > > > > Signed-off-by: B

[PATCH] iommu: io-pgtable: Support non-coherent page tables

Describe the memory related to page table walks as non-cachable for iommu instances that are not DMA coherent. Signed-off-by: Bjorn Andersson --- drivers/iommu/io-pgtable-arm.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/iommu/io-pgtable-arm.c b

Re: [PATCH 1/1] iommu/arm-smmu: Log CBFRSYNRA register on context fault

> dev_err_ratelimited(smmu->dev, > - "Unhandled context fault: fsr=0x%x, iova=0x%08lx, fsynr=0x%x, cb=%d\n", > - fsr, iova, fsynr, cfg->cbndx); > + "Unhandled context fault: fsr=0x%x, iova=0x%08lx, fsynr=0x%x, cbfrsynra >

Re: [PATCH v2 4/4] iommu/arm-smmu: Add support to handle Qcom's TLBI serialization errata

t; > Signed-off-by: Vivek Gautam Tested-by: Bjorn Andersson Regards, Bjorn > --- > drivers/iommu/arm-smmu-regs.h | 2 + > drivers/iommu/arm-smmu.c | 133 > +- > 2 files changed, 133 insertions(+), 2 deletions(-) > > diff --g

Re: [PATCH v2 3/4] firmware/qcom_scm: Add scm call to handle smmu errata

Signed-off-by: Vivek Gautam Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/firmware/qcom_scm-32.c | 5 + > drivers/firmware/qcom_scm-64.c | 13 + > drivers/firmware/qcom_scm.c| 6 ++ > drivers/firmware/qcom_scm.h| 5 + > incl

Re: [PATCH v2 2/4] firmware/qcom_scm: Add atomic version of io read/write APIs

On Sun 09 Sep 23:25 PDT 2018, Vivek Gautam wrote: > Add atomic versions of qcom_scm_io_readl/writel to enable > reading/writing secure registers from atomic context. > > Signed-off-by: Vivek Gautam Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/firmware/

Re: [PATCH v2 1/4] firmware: qcom_scm-64: Add atomic version of qcom_scm_call

tree/drivers/iommu/arm-smmu.c?h=msm-4.9#n4842") > > Signed-off-by: Vivek Gautam Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/firmware/qcom_scm-64.c | 136 > - > 1 file changed, 92 insertions(+), 44 deletions(-) >

Re: [PATCH v4 2/2] dts: arm64/sdm845: Add node for arm,mmu-500

On Tue 08 Jan 03:18 PST 2019, Vivek Gautam wrote: > > On 1/8/2019 12:29 PM, Bjorn Andersson wrote: > > On Thu 11 Oct 02:49 PDT 2018, Vivek Gautam wrote: > > > > > Add device node for arm,mmu-500 available on sdm845. > > > This MMU-500 with sing

Re: [PATCH v4 2/2] dts: arm64/sdm845: Add node for arm,mmu-500

On Thu 11 Oct 02:49 PDT 2018, Vivek Gautam wrote: > Add device node for arm,mmu-500 available on sdm845. > This MMU-500 with single TCU and multiple TBU architecture > is shared among all the peripherals except gpu. > Hi Vivek, Applying this patch together with UFS ([1] and [2]) ontop of

Re: [PATCH 3/3] iommu: armsmmu: set iommu ops for rpmsg bus

On Fri, Mar 2, 2018 at 8:59 AM, Robin Murphy wrote: > On 02/03/18 14:55, srinivas.kandaga...@linaro.org wrote: >> >> From: Srinivas Kandagatla >> >> On Qualcomm SoCs, ADSP exposes many functions like audio and >> others. These services need

Re: [PATCH 2/3] rpmsg: core: make rpmsg bus DMA capable

On Fri 02 Mar 08:14 PST 2018, Robin Murphy wrote: > On 02/03/18 14:55, srinivas.kandaga...@linaro.org wrote: > > From: Srinivas Kandagatla > > > > Many of the rpmsg clients like audio drivers need to allocate > > dma memory. Make this bus DMA capable so that the

Re: [PATCH v2 16/21] remoteproc: Remove depends on HAS_DMA in case of platform dependency

Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> > Reviewed-by: Mark Brown <broo...@kernel.org> > Acked-by: Robin Murphy <robin.mur...@arm.com> Acked-by: Bjorn Andersson <bjorn.anders...@linaro.org> Regards, Bjorn > --- > v2: > - Add Reviewed-by, A

Re: [PATCH 13/13] remoteproc: Use sychronized interface of the IOMMU-API

ode to use the synchronized > functions so that it will behave as before. > > Cc: Ohad Ben-Cohen <o...@wizery.com> > Cc: Bjorn Andersson <bjorn.anders...@linaro.org> > Cc: linux-remotep...@vger.kernel.org > Signed-off-by: Joerg Roedel <jroe...@suse.de> Acked-by:

<    1   2