Re: [PATCH v8 6/8] perf tool: Add support for parsing HiSilicon PCIe Trace packet

On Mon, 16 May 2022 20:52:21 +0800 Yicong Yang wrote: > From: Qi Liu > > Add support for using 'perf report --dump-raw-trace' to parse PTT packet. > > Example usage: > > Output will contain raw PTT data and its textual representation, such > as: > > 0 0 0x5810 [0x30]: PERF_RECORD_AUXTRACE

Re: [PATCH v8 5/8] perf tool: Add support for HiSilicon PCIe Tune and Trace device driver

On Mon, 16 May 2022 20:52:20 +0800 Yicong Yang wrote: > From: Qi Liu > > HiSilicon PCIe tune and trace device (PTT) could dynamically tune > the PCIe link's events, and trace the TLP headers). > > This patch add support for PTT device in perf tool, so users could > use 'perf record' to get

Re: [PATCH v8 4/8] perf arm: Refactor event list iteration in auxtrace_record__init()

On Mon, 16 May 2022 20:52:19 +0800 Yicong Yang wrote: > From: Qi Liu > > Use find_pmu_for_event() to simplify logic in auxtrace_record__init(). Possibly reword as "Add find_pmu_for_event() and use to simplify logic in auxtrace_record_init(). find_pmu_for_event() will be reused in subsequent

Re: [PATCH v8 2/8] hwtracing: hisi_ptt: Add trace function support for HiSilicon PCIe Tune and Trace device

On Mon, 16 May 2022 20:52:17 +0800 Yicong Yang wrote: > HiSilicon PCIe tune and trace device(PTT) is a PCIe Root Complex integrated > Endpoint(RCiEP) device, providing the capability to dynamically monitor and > tune the PCIe traffic and trace the TLP headers. > > Add the driver for the device

Re: [PATCH v5 3/8] hisi_ptt: Register PMU device for PTT trace

On Tue, 8 Mar 2022 19:13:08 +0800 Yicong Yang wrote: > On 2022/3/8 18:21, Jonathan Cameron wrote: > > On Tue, 8 Mar 2022 16:49:25 +0800 > > Yicong Yang wrote: > > > >> Register PMU device of PTT trace, then users can use trace through perf > >> command. The driver makes use of perf AUX trace

Re: [PATCH v5 8/8] MAINTAINERS: Add maintainer for HiSilicon PTT driver

On Tue, 8 Mar 2022 16:49:30 +0800 Yicong Yang wrote: > Add maintainer for driver and documentation of HiSilicon PTT device. > > Signed-off-by: Yicong Yang FWIW Reviewed-by: Jonathan Cameron I've left the perf tool and iommu patches without tags from me as I don't have the background to do a

Re: [PATCH v5 4/8] hisi_ptt: Add support for dynamically updating the filter list

On Tue, 8 Mar 2022 16:49:26 +0800 Yicong Yang wrote: > The PCIe devices supported by the PTT trace can be removed/rescanned by > hotplug or through sysfs. Add support for dynamically updating the > available filter list by registering a PCI bus notifier block. Then user > can always get latest

Re: [PATCH v5 3/8] hisi_ptt: Register PMU device for PTT trace

On Tue, 8 Mar 2022 16:49:25 +0800 Yicong Yang wrote: > Register PMU device of PTT trace, then users can use trace through perf > command. The driver makes use of perf AUX trace and support following > events to configure the trace: > > - filter: select Root port or Endpoint to trace > - type:

Re: [PATCH v4 2/8] hwtracing: Add trace function support for HiSilicon PCIe Tune and Trace device

On Mon, 21 Feb 2022 21:13:45 +0800 Yicong Yang wrote: > Hi Jonathan, > > On 2022/2/21 19:18, Jonathan Cameron wrote: > > On Mon, 21 Feb 2022 16:43:01 +0800 > > Yicong Yang wrote: > > > >> HiSilicon PCIe tune and trace device(PTT) is a PCIe Root Complex > >> integrated Endpoint(RCiEP)

Re: [PATCH v4 7/8] docs: Add HiSilicon PTT device driver documentation

On Mon, 21 Feb 2022 16:43:06 +0800 Yicong Yang wrote: > Document the introduction and usage of HiSilicon PTT device driver. > > Signed-off-by: Yicong Yang Reviewed-by: Jonathan Cameron > --- > Documentation/trace/hisi-ptt.rst | 303 +++ > 1 file changed, 303

Re: [PATCH v4 4/8] hisi_ptt: Add support for dynamically updating the filter list

On Mon, 21 Feb 2022 16:43:03 +0800 Yicong Yang wrote: > The PCIe devices supported by the PTT trace can be removed/rescanned > by hotplug or through sysfs. Add support for dynamically updating > the available filter list by registering a PCI bus notifier block. > Then user can always get latest

Re: [PATCH v4 3/8] hisi_ptt: Register PMU device for PTT trace

On Mon, 21 Feb 2022 16:43:02 +0800 Yicong Yang wrote: > Register PMU device of PTT trace, then users can use > trace through perf command. The driver makes use of perf > AUX trace and support following events to configure the > trace: > > - filter: select Root port or Endpoint to trace > -

Re: [PATCH v4 2/8] hwtracing: Add trace function support for HiSilicon PCIe Tune and Trace device

On Mon, 21 Feb 2022 16:43:01 +0800 Yicong Yang wrote: > HiSilicon PCIe tune and trace device(PTT) is a PCIe Root Complex > integrated Endpoint(RCiEP) device, providing the capability > to dynamically monitor and tune the PCIe traffic, and trace > the TLP headers. > > Add the driver for the

Re: [PATCH v3 6/8] docs: Add HiSilicon PTT device driver documentation

On Mon, 24 Jan 2022 21:11:16 +0800 Yicong Yang wrote: > Document the introduction and usage of HiSilicon PTT device driver. > > Signed-off-by: Yicong Yang Nice document. A few trivial typos inline. I would give a RB except I've suggested you change a part of the sysfs interface which will

Re: [PATCH v3 5/8] perf tool: Add support for HiSilicon PCIe Tune and Trace device driver

On Mon, 24 Jan 2022 21:11:15 +0800 Yicong Yang wrote: > From: Qi Liu > > 'perf record' and 'perf report --dump-raw-trace' supported in this > patch. > > Example usage: > > Output will contain raw PTT data and its textual representation, such > as: > > 0 0 0x5810 [0x30]: PERF_RECORD_AUXTRACE

Re: [PATCH v3 4/8] hisi_ptt: Add tune function support for HiSilicon PCIe Tune and Trace device

On Mon, 24 Jan 2022 21:11:14 +0800 Yicong Yang wrote: > Add tune function for the HiSilicon Tune and Trace device. The interface > of tune is exposed through sysfs attributes of PTT PMU device. > > Signed-off-by: Yicong Yang A few trivial things inline, but looks good in general to me. With

Re: [PATCH v3 1/8] hwtracing: Add trace function support for HiSilicon PCIe Tune and Trace device

On Mon, 24 Jan 2022 21:11:11 +0800 Yicong Yang wrote: > HiSilicon PCIe tune and trace device(PTT) is a PCIe Root Complex > integrated Endpoint(RCiEP) device, providing the capability > to dynamically monitor and tune the PCIe traffic, and trace > the TLP headers. > > Add the driver for the

Re: [PATCH v3 2/8] hisi_ptt: Register PMU device for PTT trace

On Mon, 24 Jan 2022 21:11:12 +0800 Yicong Yang wrote: > Register PMU device of PTT trace, then users can use > trace through perf command. The driver makes use of perf > AUX trace and support following events to configure the > trace: > > - filter: select Root port or Endpoint to trace > -

Re: [patch 08/37] genirq/msi: Provide msi_device_populate/destroy_sysfs()

On Sat, 27 Nov 2021 02:20:19 +0100 (CET) Thomas Gleixner wrote: > Add new allocation functions which can be activated by domain info > flags. They store the groups pointer in struct msi_device_data. > > Signed-off-by: Thomas Gleixner A few trivial comments... > --- > include/linux/msi.h |