Re: [PATCH v6 1/8] iommu: provide early initialisation hook for IOMMU drivers

2014-12-05 Thread Grant Likely
On Fri, Dec 5, 2014 at 12:35 PM, Robin Murphy robin.mur...@arm.com wrote: Hi Will, On 05/12/14 12:10, Will Deacon wrote: [...] Do you expect drivers to modify that *priv pointer after the ops structure is registered? I'd be very surprised if that was the use case. It's fine for the driver

Re: [PATCH v6 1/8] iommu: provide early initialisation hook for IOMMU drivers

2014-12-05 Thread Grant Likely
On Fri, Dec 5, 2014 at 1:18 PM, Thierry Reding thierry.red...@gmail.com wrote: On Fri, Dec 05, 2014 at 01:06:52PM +, Grant Likely wrote: On Fri, Dec 5, 2014 at 12:35 PM, Robin Murphy robin.mur...@arm.com wrote: Hi Will, On 05/12/14 12:10, Will Deacon wrote: [...] Do you expect

Re: [PATCH v6 1/8] iommu: provide early initialisation hook for IOMMU drivers

2014-12-04 Thread Grant Likely
Bergmann wrote: On Tuesday 02 December 2014 14:16:57 Grant Likely wrote: On Mon, Dec 1, 2014 at 11:54 PM, Rob Herring robherri...@gmail.com wrote: On Mon, Dec 1, 2014 at 10:57 AM, Will Deacon will.dea...@arm.com wrote: +static inline void of_iommu_set_ops

Re: [PATCH v6 1/8] iommu: provide early initialisation hook for IOMMU drivers

2014-12-04 Thread Grant Likely
On Thu, Dec 4, 2014 at 12:26 PM, Robin Murphy robin.mur...@arm.com wrote: Hi Arnd, On 03/12/14 19:57, Arnd Bergmann wrote: [...] Good catch. This is not good. The data pointer should be avoided since there are no controls over its use. Until a better solution can be implemented, probably

Re: [PATCH v6 1/8] iommu: provide early initialisation hook for IOMMU drivers

2014-12-04 Thread Grant Likely
On Thu, Dec 4, 2014 at 11:52 AM, Will Deacon will.dea...@arm.com wrote: On Thu, Dec 04, 2014 at 11:25:35AM +, Grant Likely wrote: On Thu, Dec 4, 2014 at 11:19 AM, Arnd Bergmann a...@arndb.de wrote: On Thursday 04 December 2014 10:21:27 Will Deacon wrote: Sure, I'll add this to my list

Re: [PATCH v6 1/8] iommu: provide early initialisation hook for IOMMU drivers

2014-12-04 Thread Grant Likely
pointer in the DT node is public and may be overwritten by conflicting code, move the DT-probed IOMMU ops to a private list where they will be safe. Signed-off-by: Robin Murphy robin.mur...@arm.com Acked-by: Grant Likely grant.lik...@linaro.org --- drivers/iommu/of_iommu.c | 40

Re: [PATCH v6 1/8] iommu: provide early initialisation hook for IOMMU drivers

2014-12-02 Thread Grant Likely
On Mon, Dec 1, 2014 at 11:54 PM, Rob Herring robherri...@gmail.com wrote: Adding Grant and Pantelis... On Mon, Dec 1, 2014 at 10:57 AM, Will Deacon will.dea...@arm.com wrote: IOMMU drivers must be initialised before any of their upstream devices, otherwise the relevant iommu_ops won't be

Re: [PATCHv6+ 01/13] of: introduce of_property_for_earch_phandle_with_args()

2013-12-12 Thread Grant Likely
On Wed, 11 Dec 2013 14:33:38 +0100, Hiroshi Doyu hd...@nvidia.com wrote: Hi Grant, Grant Likely grant.lik...@linaro.org wrote @ Wed, 11 Dec 2013 14:28:45 +0100: On Thu, 21 Nov 2013 11:57:00 -0700, Stephen Warren swar...@wwwdotorg.org wrote: On 11/21/2013 10:17 AM, Hiroshi Doyu

Re: [PATCHv6+ 01/13] of: introduce of_property_for_earch_phandle_with_args()

2013-12-11 Thread Grant Likely
. Signed-off-by: Hiroshi Doyu hd...@nvidia.com Acked-by: Grant Likely grant.lik...@linaro.org This patch can be merged with the rest of the series. g. --- v6+: Use the description, which Grant Likely proposed, to be full enough that a future reader can figure out why a patch was written. http

Re: [PATCHv6+ 01/13] of: introduce of_property_for_earch_phandle_with_args()

2013-12-11 Thread Grant Likely
of_property_for_each_phandle_with_args() macro to make the iteration simpler. Signed-off-by: Hiroshi Doyu hd...@nvidia.com --- v6+: Use the description, which Grant Likely proposed, to be full enough that a future reader can figure out why a patch was written. http://lists.linuxfoundation.org/pipermail/iommu

Re: [PATCHv5 1/9] of: introduce of_property_for_earch_phandle_with_args()

2013-11-21 Thread Grant Likely
On Thu, 21 Nov 2013 15:12:18 +0200, Hiroshi Doyu hd...@nvidia.com wrote: On Thu, 21 Nov 2013 13:43:28 +0100 Grant Likely grant.lik...@linaro.org wrote: On Tue, 19 Nov 2013 11:33:05 +0200, Hiroshi Doyu hd...@nvidia.com wrote: The following pattern of code is tempting: for (i = 0

Re: [PATCHv5 1/9] of: introduce of_property_for_earch_phandle_with_args()

2013-11-21 Thread Grant Likely
On Tue, 19 Nov 2013 11:33:05 +0200, Hiroshi Doyu hd...@nvidia.com wrote: The following pattern of code is tempting: for (i = 0; !of_parse_phandle_with_args(np, list, cells, i, args); i++) Signed-off-by: Hiroshi Doyu hd...@nvidia.com That's a very minimal commit message. Can you elaborate

Re: [PATCHv5 2/9] driver/core: populate devices in order for IOMMUs

2013-11-21 Thread Grant Likely
On Thu, 21 Nov 2013 12:04:18 -0700, Stephen Warren swar...@wwwdotorg.org wrote: On 11/21/2013 06:15 AM, Grant Likely wrote: On Tue, 19 Nov 2013 11:33:06 +0200, Hiroshi Doyu hd...@nvidia.com wrote: IOMMU devices on the bus need to be poplulated first, then iommu master devices are done

Re: [PATCHv3 01/19] [HACK] of: dev_node has struct device pointer

2013-11-15 Thread Grant Likely
On Wed, 30 Oct 2013 15:58:58 -0600, Stephen Warren swar...@wwwdotorg.org wrote: On 10/25/2013 03:11 AM, Thierry Reding wrote: ... So my proposed solution for the IOMMU case is to treat it the same as any other resources. Perhaps resource isn't the right word, but at the core the issue is

Re: [PATCHv3 01/19] [HACK] of: dev_node has struct device pointer

2013-11-11 Thread Grant Likely
On Mon, 28 Oct 2013 08:31:34 +0100, Thierry Reding thierry.red...@gmail.com wrote: On Fri, Oct 25, 2013 at 08:01:36PM +0100, Grant Likely wrote: On Fri, 25 Oct 2013 12:49:38 +0200, Thierry Reding thierry.red...@gmail.com wrote: On Fri, Oct 25, 2013 at 11:49:05AM +0200, Hiroshi Doyu wrote

Re: [PATCHv3 01/19] [HACK] of: dev_node has struct device pointer

2013-10-25 Thread Grant Likely
On Thu, 24 Oct 2013 04:36:30 -0500, Kumar Gala ga...@codeaurora.org wrote: On Oct 24, 2013, at 4:21 AM, Hiroshi Doyu wrote: Hi Grant, Grant Likely grant.lik...@linaro.org wrote @ Thu, 24 Oct 2013 10:55:31 +0200: diff --git a/include/linux/of.h b/include/linux/of.h index

Re: [PATCHv3 01/19] [HACK] of: dev_node has struct device pointer

2013-10-25 Thread Grant Likely
On Fri, 25 Oct 2013 12:49:38 +0200, Thierry Reding thierry.red...@gmail.com wrote: On Fri, Oct 25, 2013 at 11:49:05AM +0200, Hiroshi Doyu wrote: Thierry Reding thierry.red...@gmail.com wrote @ Fri, 25 Oct 2013 11:11:05 +0200: This is actually the other problem that I'm aware of that

Re: Reparenting a platform device

2012-04-19 Thread Grant Likely
On Sat, 7 Apr 2012 13:35:10 +0200, Thierry Reding thierry.red...@avionic-design.de wrote: * Grant Likely wrote: On Thu, 5 Apr 2012 10:42:58 +0200, Thierry Reding thierry.red...@avionic-design.de wrote: Hi, I have a device tree where I have a GART device and a DRM device which

Re: Reparenting a platform device

2012-04-09 Thread Grant Likely
On Thu, 5 Apr 2012 10:42:58 +0200, Thierry Reding thierry.red...@avionic-design.de wrote: Hi, I have a device tree where I have a GART device and a DRM device which uses the GART. The GART is implemented by an IOMMU driver (tegra-gart) and requires the user device to be a child of the GART