Re: [PATCH] x86/pci: Some buggy virtual functions incorrectly report 1 for intx.

2018-07-16 Thread Raj, Ashok
Hi Alex On Mon, Jul 16, 2018 at 03:17:57PM -0600, Alex Williamson wrote: > > static bool vfio_pci_nointx(struct pci_dev *pdev) > > { > > + /* > > +* Per PCI, no VF's should have INTx > > +* Simply disable it here > > +*/ > > + if (pdev->is_virtfn) > > + return true; >

Re: [PATCH] x86/pci: Some buggy virtual functions incorrectly report 1 for intx.

2018-07-16 Thread Alex Williamson
On Mon, 16 Jul 2018 13:42:25 -0700 Ashok Raj wrote: > PCI_INTERRUPT_PIN should always read 0 for SRIOV Virtual Functions. > > Some SRIOV devices have some bugs in RTL and VF's end up reading 1 > instead of 0 for the PIN. > > We could enforce it by default in vfio_pci_nointx. > > Reported-by:

[PATCH] x86/pci: Some buggy virtual functions incorrectly report 1 for intx.

2018-07-16 Thread Ashok Raj
PCI_INTERRUPT_PIN should always read 0 for SRIOV Virtual Functions. Some SRIOV devices have some bugs in RTL and VF's end up reading 1 instead of 0 for the PIN. We could enforce it by default in vfio_pci_nointx. Reported-by: Gage Eads Tested-by: Gage Eads Signed-off-by: Ashok Raj Cc: