Re: [PATCH 1/2] iommu/amd: Avoid get_irq_table() from atomic context

2018-02-13 Thread Joerg Roedel
Hi Scott, On Sun, Jan 21, 2018 at 03:28:53AM -0600, Scott Wood wrote: > The amd_iommu_rlookup_table[] check is not needed because > irq_lookup_table[devid] should never be non-NULL if > amd_iommu_rlookup_table[devid] is NULL. Your reasoning is correct, but I'd like the patch make the code more

[PATCH 1/2] iommu/amd: Avoid get_irq_table() from atomic context

2018-01-21 Thread Scott Wood
get_irq_table() acquires amd_iommu_devtable_lock which is not a raw lock, and thus cannot be acquired from atomic context on PREEMPT_RT. Many calls to modify_irte*() come from atomic context due to the IRQ desc->lock, as does amd_iommu_update_ga() due to the preemption disabling in