Re: [PATCH v3 5/7] memory: mtk-smi: Fix the return value for clk_bulk_prepare_enable

2022-01-17 Thread Yong Wu
On Mon, 2022-01-17 at 13:01 +0100, Krzysztof Kozlowski wrote: > On 13/01/2022 12:10, Yong Wu wrote: > > Function clk_bulk_prepare_enable() returns 0 for success or a > > negative > > number for error. Fix this code style issue. > > The message does not really make sense. If negative is returned, t

Re: [PATCH v3 5/7] memory: mtk-smi: Fix the return value for clk_bulk_prepare_enable

2022-01-17 Thread Krzysztof Kozlowski
On 13/01/2022 12:10, Yong Wu wrote: > Function clk_bulk_prepare_enable() returns 0 for success or a negative > number for error. Fix this code style issue. The message does not really make sense. If negative is returned, then the check (ret < 0) was correct. I guess you wanted to say that common

[PATCH v3 5/7] memory: mtk-smi: Fix the return value for clk_bulk_prepare_enable

2022-01-13 Thread Yong Wu
Function clk_bulk_prepare_enable() returns 0 for success or a negative number for error. Fix this code style issue. Signed-off-by: Yong Wu Reviewed-by: AngeloGioacchino Del Regno --- drivers/memory/mtk-smi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/memory/mtk