Re: [PATCH v6 09/22] vfio: VFIO_IOMMU_BIND/UNBIND_MSI

2019-03-22 Thread Alex Williamson
On Fri, 22 Mar 2019 10:30:02 +0100 Auger Eric wrote: > Hi Alex, > On 3/22/19 12:01 AM, Alex Williamson wrote: > > On Sun, 17 Mar 2019 18:22:19 +0100 > > Eric Auger wrote: > > > >> This patch adds the VFIO_IOMMU_BIND/UNBIND_MSI ioctl which aim > >> to pass/withdraw the guest MSI binding

Re: [git pull] IOMMU Fixes for Linux v5.1-rc1

2019-03-22 Thread pr-tracker-bot
The pull request you sent on Fri, 22 Mar 2019 12:22:29 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git > tags/iommu-fixes-v5.1-rc2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/070c95d457267eefecd70f5dd434740201d5083c Thank you! --

Re: [PATCH v2 RFC/RFT] dma-contiguous: Get normal pages for single-page allocations

2019-03-22 Thread Nicolin Chen
Hi Catalin, On Fri, Mar 22, 2019 at 10:57:13AM +, Catalin Marinas wrote: > > > Do you have any numbers to back this up? You don't seem to address > > > dma_direct_alloc() either but, as I said above, it's not trivial since > > > some platforms expect certain physical range for DMA

Re: [PATCH 1/2] iommu/vt-d: Check capability before disabling protected memory

2019-03-22 Thread Joerg Roedel
On Wed, Mar 20, 2019 at 09:58:33AM +0800, Lu Baolu wrote: > The spec states in 10.4.16 that the Protected Memory Enable > Register should be treated as read-only for implementations > not supporting protected memory regions (PLMR and PHMR fields > reported as Clear in the Capability register). >

Re: [PATCH v2 3/7] iommu/vt-d: Expose ISA direct mapping region via iommu_get_resv_regions

2019-03-22 Thread James Sewart via iommu
Hey Lu, > On 15 Mar 2019, at 02:19, Lu Baolu wrote: > > Hi James, > > On 3/14/19 7:58 PM, James Sewart wrote: >> To support mapping ISA region via iommu_group_create_direct_mappings, >> make sure its exposed by iommu_get_resv_regions. This allows >> deduplication of reserved region mappings >>

[git pull] IOMMU Fixes for Linux v5.1-rc1

2019-03-22 Thread Joerg Roedel
Hi Linus, The following changes since commit 9e98c678c2d6ae3a17cb2de55d17f69dddaa231b: Linux 5.1-rc1 (2019-03-17 14:22:26 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git tags/iommu-fixes-v5.1-rc2 for you to fetch changes up to

Re: [PATCH] dma: select GENERIC_ALLOCATOR for DMA_REMAP

2019-03-22 Thread Clément Leger via iommu
- Mail original - De: "Clément Leger" À: "linux-kernel" Envoyé: Jeudi 21 Mars 2019 11:20:29 Objet: [PATCH] dma: select GENERIC_ALLOCATOR for DMA_REMAP When DMA_REMAP is enabled, code in remap.c needs generic allocator. It currently worked since few architectures uses it (arm64, csky)

Re: [PATCH v2 0/7] iommu/vt-d: Fix-up device-domain relationship by refactoring to use iommu group default domain.

2019-03-22 Thread James Sewart via iommu
Hey Lu, > On 20 Mar 2019, at 01:26, Lu Baolu wrote: > > Hi James, > > On 3/19/19 9:35 PM, James Sewart wrote: >> Hey Lu, >>> On 15 Mar 2019, at 03:13, Lu Baolu wrote: >>> >>> Hi James, >>> >>> On 3/14/19 7:56 PM, James Sewart wrote: Patches 1 and 2 are the same as v1. v1-v2:

Re: [PATCH v2 7/7] iommu/vt-d: Remove lazy allocation of domains

2019-03-22 Thread James Sewart via iommu
Hey Jacob, > On 14 Mar 2019, at 23:35, Jacob Pan wrote: > > On Thu, 14 Mar 2019 11:59:36 + > James Sewart wrote: > >> >> -domain = get_valid_domain_for_dev(dev); >> +domain = find_domain(dev); >> if (!domain) >> return DMA_MAPPING_ERROR; >> >> @@ -3914,7

Re: [PATCH v2 RFC/RFT] dma-contiguous: Get normal pages for single-page allocations

2019-03-22 Thread Catalin Marinas
Hi Nicolin, On Thu, Mar 21, 2019 at 04:32:49PM -0700, Nicolin Chen wrote: > On Tue, Mar 19, 2019 at 02:43:01PM +, Catalin Marinas wrote: > > On Tue, Mar 05, 2019 at 10:32:02AM -0800, Nicolin Chen wrote: > > > The addresses within a single page are always contiguous, so it's > > > not so

Re: [PATCH 1/1] iommu: Add config option to set lazy mode as default

2019-03-22 Thread John Garry
On 22/03/2019 14:11, Zhen Lei wrote: This allows the default behaviour to be controlled by a kernel config option instead of changing the command line for the kernel to include "iommu.strict=0" on ARM64 where this is desired. This is similar to CONFIG_IOMMU_DEFAULT_PASSTHROUGH Note: At

Re: [PATCH v6 00/22] SMMUv3 Nested Stage Setup

2019-03-22 Thread Auger Eric
Hi, On 3/17/19 6:22 PM, Eric Auger wrote: > This series allows a virtualizer to program the nested stage mode. > This is useful when both the host and the guest are exposed with > an SMMUv3 and a PCI device is assigned to the guest using VFIO. > > In this mode, the physical IOMMU must be

[PATCH 1/1] iommu: Add config option to set lazy mode as default

2019-03-22 Thread Zhen Lei
This allows the default behaviour to be controlled by a kernel config option instead of changing the command line for the kernel to include "iommu.strict=0" on ARM64 where this is desired. This is similar to CONFIG_IOMMU_DEFAULT_PASSTHROUGH. Note: At present, intel_iommu, amd_iommu and

Re: [PATCH v3 09/10] NTB: Add MSI interrupt support to ntb_transport

2019-03-22 Thread Bjorn Helgaas
Hi Logan, Drive-by nits: On Thu, Mar 21, 2019 at 06:06:44PM -0600, Logan Gunthorpe wrote: > Introduce the module parameter 'use_msi' which, when set uses s/set/set,/ > MSI interrupts instead of doorbells for each queue pair (QP). T > he parameter is only available if NTB MSI support is

[PATCH] iommu: Don't print warning when IOMMU driver only supports unmanaged domains

2019-03-22 Thread Joerg Roedel
From: Joerg Roedel Print the warning about the fall-back to IOMMU_DOMAIN_DMA in iommu_group_get_for_dev() only when such a domain was actually allocated. Otherwise the user will get misleading warnings in the kernel log when the iommu driver used doesn't support IOMMU_DOMAIN_DMA and

Re: [PATCH v3 03/10] NTB: Introduce helper functions to calculate logical port number

2019-03-22 Thread Bjorn Helgaas
On Thu, Mar 21, 2019 at 06:06:38PM -0600, Logan Gunthorpe wrote: > This patch introduces the "Logical Port Number" which is similar to the > "Port Number" in that it enumerates the ports in the system. > > The original (or Physical) "Port Number" can be any number used by the > hardware to

Re: [PATCH v6 05/22] iommu: Introduce cache_invalidate API

2019-03-22 Thread Auger Eric
Hi Jacob, On 3/21/19 11:10 PM, Jacob Pan wrote: > On Thu, 21 Mar 2019 15:32:45 +0100 > Auger Eric wrote: > >> Hi jean, Jacob, >> >> On 3/21/19 3:13 PM, Jean-Philippe Brucker wrote: >>> On 21/03/2019 13:54, Auger Eric wrote: Hi Jacob, Jean-Philippe, On 3/20/19 5:50 PM,

Re: [PATCH v6 07/22] vfio: VFIO_IOMMU_ATTACH/DETACH_PASID_TABLE

2019-03-22 Thread Auger Eric
Hi Alex, On 3/21/19 11:19 PM, Alex Williamson wrote: > On Sun, 17 Mar 2019 18:22:17 +0100 > Eric Auger wrote: > >> From: "Liu, Yi L" >> >> This patch adds VFIO_IOMMU_ATTACH/DETACH_PASID_TABLE ioctl >> which aims to pass/withdraw the virtual iommu guest configuration >> to/from the VFIO driver

Re: [PATCH v6 02/22] iommu: introduce device fault data

2019-03-22 Thread Auger Eric
Hi Jacob, On 3/21/19 11:04 PM, Jacob Pan wrote: > On Sun, 17 Mar 2019 18:22:12 +0100 > Eric Auger wrote: > >> From: Jacob Pan >> >> Device faults detected by IOMMU can be reported outside the IOMMU >> subsystem for further processing. This patch introduces >> a generic device fault data

Re: [PATCHv7] x86/kdump: bugfix, make the behavior of crashkernel=X consistent with kaslr

2019-03-22 Thread Dave Young
Hi Pingfan, Thanks for the effort, On 03/01/19 at 11:19am, Pingfan Liu wrote: > On Fri, Mar 1, 2019 at 11:04 AM Pingfan Liu wrote: > > > > Hi Borislav, > > > > Do you think the following patch is good at present? > > diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c > > index

Re: [PATCH v6 09/22] vfio: VFIO_IOMMU_BIND/UNBIND_MSI

2019-03-22 Thread Auger Eric
Hi Alex, On 3/22/19 12:01 AM, Alex Williamson wrote: > On Sun, 17 Mar 2019 18:22:19 +0100 > Eric Auger wrote: > >> This patch adds the VFIO_IOMMU_BIND/UNBIND_MSI ioctl which aim >> to pass/withdraw the guest MSI binding to/from the host. >> >> Signed-off-by: Eric Auger >> >> --- >> v3 -> v4: >>

Re: [PATCH v2] iommu/iova: Fix tracking of recently failed iova address

2019-03-22 Thread Joerg Roedel
On Wed, Mar 20, 2019 at 06:57:23PM +, Robert Richter wrote: > From: Robert Richter > Subject: [PATCH v2] iommu/iova: Fix tracking of recently failed iova address > size > > If a 32 bit allocation request is too big to possibly succeed, it > early exits with a failure and then should never