Hi Niklas,
On Monday 05 Sep 2016 12:52:44 Laurent Pinchart wrote:
> On Wednesday 10 Aug 2016 13:22:19 Niklas Söderlund wrote:
> > Enable slave transfers to a device behind a IPMMU by mapping the slave
> > addresses using the dma-mapping API.
> >
> > Sign
llocate and export buffers from the device
with the strictest requirements, or to implement a central buffer allocator.
In any case, I don't think DMA_ATTR_FORCE_CONTIGUOUS is the right solution to
that problem.
Forcing contiguous allocation can however help with performance optimization,
as mapping physically co
0));
> + if (!addr)
> + iommu_dma_free(dev, pages, iosize, handle);
> }
> return addr;
> }
> @@ -626,6 +642,8 @@ static void __iommu_free_attrs(struct device *dev,
> size_t size, void *cpu_addr, size = PAGE_ALIGN(size);
> /*
>* @cpu_add
ometry to fix this.
>
> Signed-off-by: Geert Uytterhoeven
> Reviewed-by: Robin Murphy
Reviewed-by: Laurent Pinchart
> ---
> v2:
> - Add Reviewed-by.
> ---
> drivers/iommu/ipmmu-vmsa.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/iomm
pt bit number associated with the particular cache IPMMU
> device.
> +The interrupt bit number needs to match the main IPMMU IMSSTR register.
> +Only used by cache IPMMU instances.
> +
> +
> Each bus master connected to an IPMMU must reference the IPMMU in its
> device node with the following property:
--
Regards,
Laurent Pinchart
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Hi Sricharan,
On Wednesday 03 May 2017 15:54:59 Sricharan R wrote:
> On 5/3/2017 3:24 PM, Robin Murphy wrote:
> > On 02/05/17 19:35, Geert Uytterhoeven wrote:
> >> On Fri, Feb 3, 2017 at 4:48 PM, Sricharan R wrote:
> >>> From: Laurent Pinchart
> >>>
Hi Sricharan,
On Monday 15 May 2017 23:37:16 Laurent Pinchart wrote:
> On Wednesday 03 May 2017 15:54:59 Sricharan R wrote:
> > On 5/3/2017 3:24 PM, Robin Murphy wrote:
> >> On 02/05/17 19:35, Geert Uytterhoeven wrote:
> >>> On Fri, Feb 3, 2017 at 4:48 PM, Sricharan
Hi Sricharan,
On Tuesday 16 May 2017 07:53:57 sricha...@codeaurora.org wrote:
> On 2017-05-16 03:04, Laurent Pinchart wrote:
> > On Monday 15 May 2017 23:37:16 Laurent Pinchart wrote:
> >> On Wednesday 03 May 2017 15:54:59 Sricharan R wrote:
> >>> On 5/3/20
Hi Sricharan,
On Tuesday 16 May 2017 19:10:03 sricha...@codeaurora.org wrote:
> On 2017-05-16 12:47, Laurent Pinchart wrote:
> > On Tuesday 16 May 2017 07:53:57 sricha...@codeaurora.org wrote:
> >> On 2017-05-16 03:04, Laurent Pinchart wrote:
> >>> On Monday 15 May
Hi Robin,
On Tuesday 16 May 2017 15:04:55 Robin Murphy wrote:
> On 16/05/17 08:17, Laurent Pinchart wrote:
> > On Tuesday 16 May 2017 07:53:57 sricha...@codeaurora.org wrote:
[snip]
> >> arch_teardown_dma_ops() being the inverse of arch_setup_dma_ops()
> >> ,dma_o
Hi Sricharan,
On Tuesday 16 May 2017 19:59:01 sricha...@codeaurora.org wrote:
> On 2017-05-16 19:40, Laurent Pinchart wrote:
> > On Tuesday 16 May 2017 15:04:55 Robin Murphy wrote:
> >> On 16/05/17 08:17, Laurent Pinchart wrote:
> >> > On Tuesday 16 May 2017 07:
68d ("iommu: of: Handle IOMMU lookup failure with deferred
probing or error")
Signed-off-by: Laurent Pinchart
---
arch/arm/include/asm/device.h | 3 ++-
arch/arm/mm/dma-mapping.c | 5 +
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/arch/arm/include/asm/device.h b/arch
Hi Robin,
On Tuesday 16 May 2017 16:47:36 Robin Murphy wrote:
> On 16/05/17 16:14, Laurent Pinchart wrote:
> > arch_setup_dma_ops() is used in device probe code paths to create an
> > IOMMU mapping and attach it to the device. The function assumes that the
> > device is
Fixes: 7b07cbefb68d ("iommu: of: Handle IOMMU lookup failure with deferred
> probing or error") Signed-off-by: Sricharan R
> Reported-by: Geert Uytterhoeven
> Tested-by: Will Deacon
> Tested-by: Magnus Damn
> Acked-by: Will Deacon
Reviewed-by: Laurent Pinchart
>
/* Ignore all other errors apart from EPROBE_DEFER */
> + if (IS_ERR(ops) && (PTR_ERR(ops) != -EPROBE_DEFER)) {
> + dev_info(dev, "Adding to IOMMU failed: %ld\n", PTR_ERR(ops));
> + ops = NULL;
> + }
> +
> return ops;
> }
--
Regards,
Laurent P
Hi Sricharan,
On Thursday 18 May 2017 17:26:14 Sricharan R wrote:
> On 5/18/2017 4:09 PM, Laurent Pinchart wrote:
> > On Thursday 18 May 2017 15:37:09 Sricharan R wrote:
> >> While deferring the probe of IOMMU masters,
> >> xlate and add_device callback can pass
Hi Sricharan
On Thursday 18 May 2017 19:08:12 Sricharan R wrote:
> On 5/18/2017 6:00 PM, Laurent Pinchart wrote:
> > On Thursday 18 May 2017 17:26:14 Sricharan R wrote:
> >> On 5/18/2017 4:09 PM, Laurent Pinchart wrote:
> >>> On Thursday 18 May 2017 15:37:09 S
concern and let the master work without IOMMU, thus
> restoring the old behavior.
>
> Fixes: 7b07cbefb68d ("iommu: of: Handle IOMMU lookup failure with deferred
> probing or error") Reported-by: Geert Uytterhoeven
> Tested-by: Magnus Damn
> Signed-off-by: Sricharan R
Revi
n v4.12-rc1 and
breaks IOMMU operations on several platforms. We need a fix for v4.12-rc that
should be as nonintrusive as possible, as a larger cleanup is likely not -rc
material. Beside reverting the whole series, the simplest option I came up
with was [1]. Note that this is not the only fix needed to fix v4.12-rc1 IOMMU
breakage, there are four more patches in the series that Sricharan plans to
get merged soon. I don't think there are dependencies between the other four
drivers/ patches and the arch/arm/ patch, so the latter could be merged
independently through your tree as soon as it's deemed ready.
[1] https://www.spinics.net/lists/arm-kernel/msg583019.html
--
Regards,
Laurent Pinchart
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Hello,
On Wednesday 24 May 2017 16:01:45 Sricharan R wrote:
> On 5/24/2017 4:12 AM, Russell King - ARM Linux wrote:
> > On Wed, May 24, 2017 at 12:46:51AM +0300, Laurent Pinchart wrote:
> >> On Tuesday 23 May 2017 18:53:19 Russell King - ARM Linux wrote:
> >>> On T
Hi Russell,
On Thursday 25 May 2017 16:05:41 Russell King - ARM Linux wrote:
> On Wed, May 24, 2017 at 02:26:13PM +0300, Laurent Pinchart wrote:
> > Again, the patch I propose is the simplest v4.12-rc fix I can think of,
> > short of reverting your complete IOMMU probe deferr
figure dma operations at probe time for
> platform/amba/pci bus devices")
Reviewed-by: Laurent Pinchart
Could you please push this upstream along with "[PATCH] ARM: dma-mapping:
Don't tear third-party mappings" ?
(And feel free to s/tear/tear down/ in the subject of that p
t; + dev_err(&pdev->dev, "ioremap_nocache failed\n");
> + return -ENOMEM;
> + }
> + ipmmu->dev_names = pdata->dev_names;
> + ipmmu->num_dev_names = pdata->num_dev_names;
> + platform_set_drvdata(pdev, ipmmu);
> + ipmmu_r
ux-...@vger.kernel.org
Cc: linux-ser...@vger.kernel.org
Cc: linux-...@vger.kernel.org
Cc: Magnus Damm
Cc: Mark Brown
Cc: Mauro Carvalho Chehab
Cc: net...@vger.kernel.org
Cc: Samuel Ortiz
Cc: Sergei Shtylyov
Cc: Thierry Reding
Cc: Tomi Valkeinen
Cc: Vinod Koul
Cc: Wolfram Sang
Cc: Zhang R
@lists.linux-foundation.org
Signed-off-by: Laurent Pinchart
---
drivers/iommu/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
index c880eba..3e7fdbb 100644
--- a/drivers/iommu/Kconfig
+++ b/drivers/iommu/Kconfig
@@ -206,7 +206,7
Hi Simon and Guennadi,
On Tuesday 29 October 2013 10:12:17 Guennadi Liakhovetski wrote:
> On Tue, 29 Oct 2013, Laurent Pinchart wrote:
> > Hello,
> >
> > This patch series, based on v3.12-rc7, prepares various Renesas drivers
> > for migration to multiplatfor
Hi Artem,
On Tuesday 29 October 2013 15:06:20 Artem Bityutskiy wrote:
> On Tue, 2013-10-29 at 10:12 +0100, Guennadi Liakhovetski wrote:
> > On Tue, 29 Oct 2013, Laurent Pinchart wrote:
> > > Hello,
> > >
> > > This patch series, based on v3.12-rc7, prepar
arget architecture. Now that we have a
COMPILE_TEST Kconfig option, my preference would thus go to SUPERH || ARM ||
COMPILE_TEST over no dependency at all.
--
Regards,
Laurent Pinchart
signature.asc
Description: This is a digitally signed message part.
Hi Mark,
On Tuesday 29 October 2013 10:23:31 Mark Brown wrote:
> On Tue, Oct 29, 2013 at 06:05:53PM +0100, Laurent Pinchart wrote:
> > The first one is that I can't compile-test all those drivers on all
> > architectures. The spi-sh-msiof driver, for instance, uses
&
Roedel
Cc: iommu@lists.linux-foundation.org
Signed-off-by: Laurent Pinchart
---
drivers/iommu/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
index c880eba..9fd51e5 100644
--- a/drivers/iommu/Kconfig
+++ b/drivers/iommu
ux-ker...@vger.kernel.org
Cc: linux-me...@vger.kernel.org
Cc: linux-...@vger.kernel.org
Cc: linux-...@lists.infradead.org
Cc: linux...@vger.kernel.org
Cc: linux-...@vger.kernel.org
Cc: linux-ser...@vger.kernel.org
Cc: linux-...@vger.kernel.org
Cc: net...@vger.kernel.org
Laurent Pinchart (19):
s
_TEST support as the driver doesn't compile on
non-ARM platforms due to usage of the ARM DMA IOMMU API.
Cc: Joerg Roedel
Cc: iommu@lists.linux-foundation.org
Signed-off-by: Laurent Pinchart
---
drivers/iommu/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu
Hi Russell,
[CC'ing Mark Brown]
On Wednesday 30 October 2013 11:26:25 Russell King - ARM Linux wrote:
> On Wed, Oct 30, 2013 at 12:20:43PM +0100, Laurent Pinchart wrote:
> > Renesas ARM platforms are transitioning from single-platform to
> > multi-platform k
On Wednesday 30 October 2013 09:28:54 Mark Brown wrote:
> On Wed, Oct 30, 2013 at 12:40:12PM +0100, Laurent Pinchart wrote:
> > > For similar reasons as x86, can we please think about using:
> > > depends on ARM
> > > depends on ARCH_SHMOBILE || ARCH_SHMOBILE_MULT
Hello,
On Tuesday 29 October 2013 23:37:35 Laurent Pinchart wrote:
> Hello,
>
> This patch series, based on v3.12-rc7, prepares various Renesas drivers
> for migration to multiplatform kernels by enabling their compilation or
> otherwise fixing them on all ARM platforms. The pat
This helps increasing build testing coverage.
The driver doesn't compile on non-ARM platforms due to usage of the ARM
DMA IOMMU API, restrict compilation to ARM.
Cc: Joerg Roedel
Cc: iommu@lists.linux-foundation.org
Signed-off-by: Laurent Pinchart
---
drivers/iommu/Kconfig | 1 +
1
oul
Cc: Wolfram Sang
Cc: Zhang Rui
Laurent Pinchart (15):
i2c: shmobile/rcar: Restrict non-COMPILE_TEST compilation
input: sh_keysc: Restrict non-COMPILE_TEST compilation
serial: sh-sci: Restrict non-COMPILE_TEST compilation
iommu: shmobile: Enable driver compilation with COMPILE_TEST
Hi Joerg,
Could you please pick this patch up for v3.14 ?
On Thursday 28 November 2013 16:36:51 Simon Horman wrote:
> On Wed, Nov 27, 2013 at 02:18:26AM +0100, Laurent Pinchart wrote:
> > This helps increasing build testing coverage.
> >
> > The driver doesn't compil
The lock is taken in atomic context, replace it with a spinlock.
Signed-off-by: Laurent Pinchart
---
drivers/iommu/shmobile-ipmmu.c | 10 +-
drivers/iommu/shmobile-ipmmu.h | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/iommu/shmobile-ipmmu.c b/drivers
Hello,
These two small patches fix bugs in the SH Mobile IOMMU driver that result in
crashes at runtime. Given that the bugs have been present in the driver since
v3.9 there's no urgency to push the fixes to v3.13.
Laurent Pinchart (2):
iommu/shmobile: Allocate archdata with kzalloc()
The archdata attached_list field isn't initialized, leading to random
crashes when accessed. Use kzalloc() to allocate the whole structure and
make sure all fields get initialized properly.
Signed-off-by: Laurent Pinchart
---
drivers/iommu/shmobile-iommu.c | 3 +--
1 file changed, 1 inse
On Wednesday 18 December 2013 10:15:21 Simon Horman wrote:
> On Tue, Dec 17, 2013 at 06:18:49PM +0100, Laurent Pinchart wrote:
> > The archdata attached_list field isn't initialized, leading to random
> > crashes when accessed. Use kzalloc() to allocate the whole structure a
h,
If CONFIG_OF isn't defined (pretty unlikely I agree, but a possibility you
seem to be prepared for nonetheless given the above #if), this will fail to
compile.
> },
> };
--
Regards,
Laurent Pinchart
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
seems ARCH_SHMOBILE was intended. Use
> that.
>
> Signed-off-by: Paul Bolle
Acked-by: Laurent Pinchart
Joerg, could you please pick this patch up ?
> ---
> Completely untested.
>
> drivers/iommu/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff
Hi Suman,
Thank you for the patch.
On Thursday 13 February 2014 12:15:32 Suman Anna wrote:
> Use the various devm_ interfaces to simplify the cleanup in
> probe and remove functions.
>
> Signed-off-by: Florian Vaussard
> Signed-off-by: Suman Anna
Acked-by: Laurent Pinchart
&
tatic struct omap_iommu *omap_iommu_attach(const char
> *name, u32 *iopgd) (void *)name,
> device_match_by_alias);
> if (!dev)
> - return NULL;
> + return ERR_PTR(err);
I would return ERR_PTR(-ENODEV) here, and remove th
s OMAP do not yet has a proper reset controller driver,
> IOMMUs requiring a reset signal should use pdata-quirks as a
> transitional solution.
>
> Signed-off-by: Florian Vaussard
This looks good to me, but you should move this patch before 04/16, otherwise
you'll break
flag and
> the corresponding hwmod data can be enabled.
>
> Cc: Paul Walmsley
> Signed-off-by: Florian Vaussard
> [s-a...@ti.com: revise commit log]
> Signed-off-by: Suman Anna
Acked-by: Laurent Pinchart
> ---
> arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 8
+Example:
> + /* OMAP3 ISP MMU */
> + mmu_isp: mmu@480bd400 {
> + compatible = "ti,omap2-iommu";
> + reg = <0x480bd400 0x80>;
> + interrupts = <24>;
> + ti,hwmods = "mmu_isp"
Hi Suman,
On Tuesday 25 February 2014 16:32:03 Suman Anna wrote:
> On 02/25/2014 03:13 PM, Laurent Pinchart wrote:
> > On Thursday 13 February 2014 12:15:33 Suman Anna wrote:
> >> From: Florian Vaussard
> >>
> >> omap_iommu_attach() returns N
Hi Suman,
On Tuesday 25 February 2014 17:02:35 Suman Anna wrote:
> On 02/25/2014 03:26 PM, Laurent Pinchart wrote:
> > On Thursday 13 February 2014 12:15:34 Suman Anna wrote:
> >> From: Florian Vaussard
> >>
> >> This patch adds the iommu bindings for
Hi Suman,
On Wednesday 26 February 2014 11:02:24 Suman Anna wrote:
> On 02/25/2014 08:13 PM, Laurent Pinchart wrote:
> > On Tuesday 25 February 2014 17:02:35 Suman Anna wrote:
> >> On 02/25/2014 03:26 PM, Laurent Pinchart wrote:
> >>> On Thursday 13 February
Hi Suman,
On Wednesday 26 February 2014 14:23:03 Suman Anna wrote:
> > On Wednesday 26 February 2014 11:02:24 Suman Anna wrote:
> >> On 02/25/2014 08:13 PM, Laurent Pinchart wrote:
> >>> On Tuesday 25 February 2014 17:02:35 Suman Anna wrote:
> >>>> On 0
-window = <0 0xd000>;
I'm not too familiar with the M3 MPU in the OMAP4, but doesn't its memory map
also include other reserved regions, such as 0x5504- 0x5505 to access
the ISS ?
> + ti,iommu-bus-err-back;
> + };
> +
> wdt2: wdt@4a314000
Hi Suman,
On Wednesday 26 February 2014 16:28:08 Suman Anna wrote:
> On 02/26/2014 04:18 PM, Suman Anna wrote:
> > On 02/26/2014 02:36 PM, Laurent Pinchart wrote:
> >> On Wednesday 26 February 2014 14:23:03 Suman Anna wrote:
> >>>> On Wednesday 26 Februa
the kernel. Although this makes the
IPMMU unusable at the moment, it shouldn't block review of the driver as it
shouldn't be involved in the problem. I'm of course investigating this.
Laurent Pinchart (2):
iommu: Add driver for Renesas VMSA-compatible IPMMU
[TEST] ARM: shmobile: koels
Signed-off-by: Laurent Pinchart
---
drivers/iommu/Kconfig| 12 +
drivers/iommu/Makefile |1 +
drivers/iommu/ipmmu-vmsa.c | 1070 ++
include/linux/platform_data/ipmmu-vmsa.h | 24 +
4 files changed, 1107
Not-Signed-off-by: Laurent Pinchart
---
arch/arm/mach-shmobile/board-koelsch-reference.c | 30
1 file changed, 30 insertions(+)
diff --git a/arch/arm/mach-shmobile/board-koelsch-reference.c
b/arch/arm/mach-shmobile/board-koelsch-reference.c
index a3fd302..d2f4ed8
Hello Will,
I've studied your arm-smmu driver as a base to write a Renesas IOMMU driver
and found two small issues. Here are patches to fix them. Please bear with me
if my understanding was incorrect and the patches wrong :-)
Laurent Pinchart (2):
iommu/arm-smmu: Replace list walk
Instead of walking the list of registered SMMU devices at remove time to
locate the device being removed, set platform driver data at probe time
to point to the SMMU and retrieve the pointer at remove time.
Signed-off-by: Laurent Pinchart
---
drivers/iommu/arm-smmu.c | 15 ---
1
The IOMMU core expects the unmap operation to return the number of bytes
that have been unmapped or 0 on failure, a negative return value being
treated like a number of bytes.
Signed-off-by: Laurent Pinchart
---
drivers/iommu/arm-smmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
; > +#endif /* __IPMMU_VMSA_H__ */
>
> Also, what about the of-bindings?
That's planned and will come in a second step. I was first trying to get the
IPMMU working.
--
Regards,
Laurent Pinchart
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Hi Will,
On Friday 28 February 2014 16:38:37 Will Deacon wrote:
> Hi Laurent,
>
> On Fri, Feb 28, 2014 at 03:37:09PM +, Laurent Pinchart wrote:
> > Instead of walking the list of registered SMMU devices at remove time to
> > locate the device being removed, set platform
Hi Geert,
Thank you for the review.
On Friday 28 February 2014 18:48:22 Geert Uytterhoeven wrote:
> On Fri, Feb 28, 2014 at 4:24 PM, Laurent Pinchart wrote:
> > +/*
> > + * VMSA that states in section B3.6.3 "Control of Secure or Non-secure
> > memory
>
> VMS
The page table entries must be cleaned from the cache before being
accessed by the IOMMU. Instead of implementing cache management manually
(and ignoring L2 cache), use clean_dcache_area() to make sure the
entries are visible to the device.
Signed-off-by: Laurent Pinchart
---
drivers/iommu/omap
The IOMMU core breaks out mappings into pages already, there's no
need to support mapping multiple pages in one go.
Signed-off-by: Laurent Pinchart
---
drivers/iommu/omap-iommu.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c
The flush_iotlb_page() function prints a debug message when no
corresponding page was found in the TLB. That condition is incorrectly
checked and always resolves to true, given that the for_each_iotlb_cr()
loop is never interrupted and always reaches obj->nr_tlb_entries.
Signed-off-by: Laur
after only.
Signed-off-by: Laurent Pinchart
---
drivers/iommu/omap-iommu.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c
index cb1e1de..fedd303 100644
--- a/drivers/iommu/omap-iommu.c
+++ b/drivers/iommu/omap-io
uple of remaining bugs (I'm aware that I have broken userspace
PFNMAP buffers).
Laurent Pinchart (5):
iommu/omap: Use the cache cleaning API
iommu/omap: Fix 'no page for' debug message in flush_iotlb_page()
iommu/omap: Flush the TLB only after updating translation table
parameters to little-endian, 8-bits and
non-mixed page attributes. Furthermore, as the OMAP IOMMU doesn't
support read-only or write-only mappings, ignore the prot value.
Signed-off-by: Laurent Pinchart
---
drivers/iommu/omap-iommu.c | 17 +++--
1 file changed, 7 insertions(+
.
On Saturday 08 March 2014 01:46:09 Laurent Pinchart wrote:
> Hello,
>
> This patch set fixes miscellaneous issues with the OMAP IOMMU driver, found
> when trying to port the OMAP3 ISP away from omap-iovmm to the ARM DMA API.
> The biggest issue is fixed by patch 5/5, while t
Hi Suman,
Thank you for the review.
On Thursday 13 March 2014 19:07:33 Suman Anna wrote:
> On 03/07/2014 06:46 PM, Laurent Pinchart wrote:
> > The prot flags passed to the IOMMU map handler are defined in
> > include/linux/iommu.h as IOMMU_(READ|WRITE|CACHE|EXEC). However, the
>
Hi Suman,
On Thursday 13 March 2014 17:16:07 Suman Anna wrote:
> On 03/07/2014 06:46 PM, Laurent Pinchart wrote:
> > The flush_iotlb_page() function prints a debug message when no
> > corresponding page was found in the TLB. That condition is incorrectly
> > checked and al
Hi Suman,
On Thursday 13 March 2014 17:27:38 Suman Anna wrote:
> Hi Laurent,
>
> On 03/07/2014 06:46 PM, Laurent Pinchart wrote:
> > Flushing the TLB before updating translation entries creates a race
> > condition and can lead to stale TLB entries if a translation reques
Hi Suman,
(CC'ing Joerg Roedel and Marek Szyprowski for the core IOMMU discussion)
On Thursday 13 March 2014 21:33:37 Suman Anna wrote:
> On 03/07/2014 06:46 PM, Laurent Pinchart wrote:
> > Hello,
> >
> > This patch set fixes miscellaneous issues with the OMAP IO
Hi Santosh,
On Friday 14 March 2014 12:15:11 Santosh Shilimkar wrote:
> + Russell, Arnd
>
> On Thursday 13 March 2014 10:47 PM, Anna, Suman wrote:
> > On 03/07/2014 06:46 PM, Laurent Pinchart wrote:
> >> The page table entries must be cleaned from the cache before be
Hi Suman and Sakari,
On Monday 17 March 2014 14:58:24 Suman Anna wrote:
> On 03/16/2014 04:54 PM, Sakari Ailus wrote:
> > On Fri, Mar 14, 2014 at 12:00:16PM +0100, Laurent Pinchart wrote:
> >> Hi Suman,
> >>
> >> (CC'ing Joerg Roedel and Marek
Hi all,
On Friday 14 March 2014 20:49:56 Suman Anna wrote:
> On 03/14/2014 12:51 PM, Santosh Shilimkar wrote:
> > On Friday 14 March 2014 12:38 PM, Laurent Pinchart wrote:
> >> On Friday 14 March 2014 12:15:11 Santosh Shilimkar wrote:
> >>> On Thursday 13 March 20
st the Renesas
IOMMU doesn't need coherent memory as long as the driver makes sure that
changes to the page tables are made visible to the device. That IOMMU can also
use the DVM hardware coherency protocols on a cache coherent interconnect, but
I haven't investigated that yet.
--
Re
Signed-off-by: Laurent Pinchart
---
drivers/iommu/Kconfig| 12 +
drivers/iommu/Makefile |1 +
drivers/iommu/ipmmu-vmsa.c | 1070 ++
include/linux/platform_data/ipmmu-vmsa.h | 24 +
4 files changed, 1107
Make platform data optional when the device is instantiated from DT and
look up the micro-TLB number in the bus master DT node.
Signed-off-by: Laurent Pinchart
---
drivers/iommu/ipmmu-vmsa.c | 37 +
1 file changed, 29 insertions(+), 8 deletions(-)
diff --git
iver in a
round-robin way. A more configurable solution might be needed later, but I
believe that's out of scope of DT.
Cc: devicet...@vger.kernel.org
Cc: Will Deacon
Laurent Pinchart (5):
iommu/ipmmu-vmsa: Refactor micro-TLB lookup
iommu/ipmmu-vmsa: Add device tree bindings documen
Signed-off-by: Laurent Pinchart
---
arch/arm/boot/dts/r8a7791.dtsi | 49 ++
1 file changed, 49 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts/r8a7791.dtsi
index 2e22cb2..bbadf7a 100644
--- a/arch/arm/boot/dts/r8a7791.dtsi
Cache the micro-TLB number in archdata allocated in the .add_device
handler instead of looking it up when the deviced is attached and
detached. This simplifies the .attach_dev and .detach_dev operations and
prepares for DT support.
Signed-off-by: Laurent Pinchart
---
drivers/iommu/ipmmu-vmsa.c
Signed-off-by: Laurent Pinchart
---
arch/arm/boot/dts/r8a7791.dtsi | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts/r8a7791.dtsi
index bbadf7a..26edcbe 100644
--- a/arch/arm/boot/dts/r8a7791.dtsi
+++ b/arch/arm/boot/dts
Cc: devicet...@vger.kernel.org
Cc: Will Deacon
Signed-off-by: Laurent Pinchart
---
.../bindings/iommu/renesas,ipmmu-vmsa.txt | 35 ++
1 file changed, 35 insertions(+)
create mode 100644
Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.txt
diff --git a
Hi Geert,
On Monday 31 March 2014 10:39:48 Geert Uytterhoeven wrote:
> On Sat, Mar 29, 2014 at 12:36 AM, Laurent Pinchart wrote:
> > +Required Properties:
> > +
> > + - compatible: Must contain "renesas,ipmmu-vmsa".
> > + - reg: Base address and size of the
Hi Geert,
On Monday 31 March 2014 10:52:28 Geert Uytterhoeven wrote:
> On Sat, Mar 29, 2014 at 12:36 AM, Laurent Pinchart wrote:
> > + ipmmu_sy0: mmu@e6280800 {
> > + compatible = "renesas,ipmmu-vmsa";
> > + reg = <0 0xe628080
Hi Geert,
On Monday 31 March 2014 10:45:00 Geert Uytterhoeven wrote:
> On Sat, Mar 29, 2014 at 12:36 AM, Laurent Pinchart wrote:
> > @@ -828,16 +829,31 @@ static phys_addr_t ipmmu_iova_to_phys(struct
> > iommu_domain *io_domain,>
> > static int ipmmu_find_utlb(struc
Hi Ben,
On Monday 31 March 2014 15:30:00 Ben Dooks wrote:
> On 31/03/14 15:01, Laurent Pinchart wrote:
> > On Monday 31 March 2014 10:52:28 Geert Uytterhoeven wrote:
> >> On Sat, Mar 29, 2014 at 12:36 AM, Laurent Pinchart wrote:
> >>> +
Hi Sergei,
Thank you for the review.
On Saturday 29 March 2014 18:50:16 Sergei Shtylyov wrote:
> On 03/29/2014 02:36 AM, Laurent Pinchart wrote:
> > Cc: devicet...@vger.kernel.org
> > Cc: Will Deacon
> > Signed-off-by: Laurent Pinchart
> >
> > ---
> >
Signed-off-by: Laurent Pinchart
---
drivers/iommu/Kconfig| 12 +
drivers/iommu/Makefile |1 +
drivers/iommu/ipmmu-vmsa.c | 1070 ++
include/linux/platform_data/ipmmu-vmsa.h | 24 +
4 files changed, 1107
Hello,
These three patches are small cleanups for the SH-Mobile IPMMU driver. Nothing
special here, please see individual patches for details.
I plan to send a pull request in a couple of days.
Laurent Pinchart (2):
iommu/shmobile: Don't ignore the ipmmu_iommu_init() return value
Replace the devm_ioremap_nocache() call with devm_ioremap_resource().
This simplifies error checking.
Signed-off-by: Laurent Pinchart
---
drivers/iommu/shmobile-ipmmu.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/drivers/iommu/shmobile-ipmmu.c b
From: Paul Bolle
Commit 78a2e12f51d9 ("iommu: shmobile: Enable driver compilation with
COMPILE_TEST") added an optional dependency on SH_MOBILE. But that
Kconfig symbol doesn't exist. It seems ARCH_SHMOBILE was intended. Use
that.
Signed-off-by: Paul Bolle
Signed-off-by: L
The function can fail, don't ignore its error value.
Signed-off-by: Laurent Pinchart
---
drivers/iommu/shmobile-ipmmu.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/iommu/shmobile-ipmmu.c b/drivers/iommu/shmobile-ipmmu.c
index e3bc2e1..6ba6110 100644
Hi Will,
On Friday 28 February 2014 16:37:08 Laurent Pinchart wrote:
> Hello Will,
>
> I've studied your arm-smmu driver as a base to write a Renesas IOMMU driver
> and found two small issues. Here are patches to fix them. Please bear with
> me if my understanding was incor
I" and "iommu/omap: Flush
the TLB only after updating translation table entries" patches
- Reworked "iommu/omap: Fix 'no page for' debug message in flush_iotlb_page()"
to just break out of the loop
- Added patches 1/6 to 3/6
Laurent Pinchart (3):
iommu/omap: F
From: Suman Anna
The to_iommu definition is used only locally to the omap-iommu.c
source file, and it has nothing to do with the page attributes
defined in omap-iopgtable.h. So, move the definition out of
omap-iopgtable.h header file.
Signed-off-by: Suman Anna
---
drivers/iommu/omap-iommu.c
7;t have two TLB entries for the same VA, break from the
loop when a match is found.
Signed-off-by: Laurent Pinchart
---
drivers/iommu/omap-iommu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c
index fdf3dd0..428b47a 100644
--- a/drive
1 - 100 of 468 matches
Mail list logo
