Re: [PATCH v2 4/6] iommu/vt-d: Add debugfs extension to show register contents

On Mon, 2017-11-27 at 20:52 +, Kammela, Gayatri wrote: > > > > > From: Andy Shevchenko [mailto:andriy.shevche...@linux.intel.com] > > Sent: Wednesday, November 22, 2017 1:19 PM > >  > > Moreover, see the patch I have just sent [1] and use same > > DEFINE_SHOW_ATTRIBUTE() macro here. In that

Re: [PATCH v4 5/5] iommu/vt-d: Add debugfs support for Interrupt remapping

On Tue, 2017-12-19 at 23:30 +0200, Andy Shevchenko wrote: > On Tue, 2017-12-19 at 13:08 -0800, Sohil Mehta wrote: > > > > Debugfs extension for Intel IOMMU to dump Interrupt remapping table > > entries for Interrupt remapping and Interrupt posting. > > > > The file

Re: [PATCH v4 0/5] Add Intel IOMMU debugfs support

On Tue, 2017-12-19 at 23:25 +0200, Andy Shevchenko wrote: >  > Perhaps you need to switch to SPDX license pointer. > I dunno if Thomas' patch with documentation how to do this made > upstream >  / linux-next yet. > Thanks. I found the information at https://patchwork.kernel.org/patch/1 0091607/. 

Re: [PATCH v3 2/6] iommu/vt-d: Add Intel IOMMU debugfs to show context internals

On Wed, 2017-12-13 at 10:28 +0800, Lu Baolu wrote: >  > > Would the recommendation be to use pr_warn instead of pr_err or > > should > > we entirely skip the message altogether? > Greg ever educated me about the use of debugfs_ functions in > this thread. > >

Re: [PATCH v3 2/6] iommu/vt-d: Add Intel IOMMU debugfs to show context internals

On Wed, 2017-12-06 at 16:16 +0800, Lu Baolu wrote: > Hi, > > On 12/06/2017 11:43 AM, Sohil Mehta wrote: > > > > From: Gayatri Kammela > > > >  > > + seq_printf(m, "%s Context table entries for Bus: %d\n", > > +    ext ? "Lower" : "", bus); > > +

Re: [PATCH v3 3/6] iommu/vt-d: Add Intel IOMMU debugfs to show extended context internals

On Wed, 2017-12-06 at 16:17 +0800, Lu Baolu wrote: > Hi, > > On 12/06/2017 11:43 AM, Sohil Mehta wrote: > > > > From: Gayatri Kammela > > > > + > > + if (new_ext) { > > + seq_printf(m, "Higher Context tbl entries for Bus: > > %d\n", bus); > > +

Re: [PATCH v6 0/5] Add Intel IOMMU debugfs support

On Wed, 2018-01-10 at 15:46 +0200, Andy Shevchenko wrote: > On Tue, 2018-01-09 at 19:48 -0800, Sohil Mehta wrote: > > > > Hi All, > > > > This series aims to add debugfs support for Intel IOMMU. It exposes > > IOMMU > > registers, internal context and dumps individual table entries to > > help >

Re: [PATCH v3 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU

On Fri, 2018-04-06 at 08:17 -0500, Gary R Hook wrote: >  > + > +void amd_iommu_debugfs_setup(struct amd_iommu *iommu) > +{ > + char name[MAX_NAME_LEN + 1]; > + struct dentry *d_top; > + > + if (!debugfs_initialized()) Probably not needed. > + return; > + > +

Re: [PATCH v3 1/2] iommu - Enable debugfs exposure of the IOMMU

On Fri, 2018-04-06 at 08:17 -0500, Gary R Hook wrote: >  >  > +struct dentry *iommu_debugfs_setup(void) > +{ > + if (!debugfs_initialized()) This check is probably not needed. > + return NULL; > + > + if (!iommu_debugfs_dir) > + iommu_debugfs_dir =

Re: [PATCH v3 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU

On Wed, 2018-04-18 at 08:31 +, Yang, Shunyong wrote: > Maybe the original design is to call debugfs_initialized() before > calling debugfs_create_xxx()? I am unaware of the original design. Someone else would probably have more context. However, looking at other places in the kernel where

Re: [PATCH v3 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU

On Wed, 2018-04-18 at 05:58 +, Yang, Shunyong wrote: > Hi, Gary and Sohil, > > On Tue, 2018-04-17 at 13:38 -0400, Hook, Gary wrote: > > On 4/13/2018 8:08 PM, Mehta, Sohil wrote: > > >  > > > On Fri, 2018-04-06 at 08:17 -0500, Gary R Hook wrote: > >

Re: [PATCH v3 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU

On Fri, 2018-04-06 at 08:17 -0500, Gary R Hook wrote: > > diff --git a/drivers/iommu/Makefile b/drivers/iommu/Makefile > index 5eb1121d54b9..0ca250f626d9 100644 > --- a/drivers/iommu/Makefile > +++ b/drivers/iommu/Makefile > @@ -11,6 +11,7 @@ obj-$(CONFIG_IOMMU_IOVA) += iova.o >  

Re: [PATCH 5/6] iommu/vt-d: Cleanup after delegating DMA domain to generic iommu

On Sun, 2019-06-09 at 10:38 +0800, Lu Baolu wrote: >  static int __init si_domain_init(int hw) > @@ -3306,14 +3252,13 @@ static int __init init_dmars(void) > if (pasid_supported(iommu)) > intel_svm_init(iommu); >  #endif > -   } >   > -   /* > -  

Re: [PATCH] iommu/vt-d: Add Scalable Mode fault information

On Tue, 2019-09-10 at 10:08 +0200, Joerg Roedel wrote: > > + "Unknown", "Unknown", "Unknown", "Unknown", "Unknown", > "Unknown", "Unknown", /* 0x49-0x4F */ > > Maybe add the number (0x49-0x4f) to the respecting "Unknown" fields? > If > we can't give a reason we should give the number for