Re: [Issue]platform/x86: iommu: System can't shutdown because iommu driver keeps checking the status of DMA_GSTS_TES
Hi Mario On Fri, Jul 10, 2020 at 4:58 AM Limonciello, Mario wrote: > > > -Original Message- > > From: iommu On Behalf Of Koba Ko > > Sent: Sunday, June 14, 2020 10:47 PM > > To: David Woodhouse; Lu Baolu; Joerg Roedel > > Cc: iommu@lists.linux-foundation.org; Kai Heng Feng; Linux Kernel Mailing > > List > > Subject: [Issue]platform/x86: iommu: System can't shutdown because iommu > > driver keeps checking the status of DMA_GSTS_TES > > > > hi All, > > I have a machine and there's only intel gpu. > > the secureboot and vt-d is enabled in BIOS. > > On the Ubuntu desktop, I do s2idle first and restart the machine. > > The machine can't restart successfully, so I need to press the power > > button to shutdown. > > I tried each of the following and the issue can't be triggered. > > 1. disable secure boot in BIOS. > > Just to explain why this happens, on many of Dell's systems VT-d is only > enabled > when secure boot is enabled. > > > 2. intel_iommu=off. > > 3. intel_iomm=igfx_off. > > 4. nomodeset > > 5. i915.modeset=0. > > > > After I investigate further, find inte_iommu keeps checking the status > > of DMA_GSTS_TES. > > During the procedure of restart, the driver would disable iommu translation > > and > > check the status of DMA_GSTS_TES until status of DMA_GSTS_TES is 0. > > > > If you need more information, I can provide it. > > > > Thanks > > Koba Ko > > ___ > > iommu mailing list > > iommu@lists.linux-foundation.org > > https://lists.linuxfoundation.org/mailman/listinfo/iommu > > This is reported on TGL pre-production system, but actually same symptom is > also > happening in ICL production systems such as XPS 7390 2-in-1 and XPS 9300. > > Details for the ICL issue are available here: > https://bugzilla.kernel.org/show_bug.cgi?id=206571 > > A user did bisect it back to commit 6c3a44ed3c553c324845744f30bcd1d3b07d61fd > in > 5.5. Glancing through the code and comparing the suspend case, I would ask > is it > just a case of missing a flush at shutdown (IE iommu_flush_all)? > If dma translation doesn't be disabled during shutdown, the machine would be powered off successfully. I have tried to flush before disabled and this can't affect the result of the issue. koba ko ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
RE: [Issue]platform/x86: iommu: System can't shutdown because iommu driver keeps checking the status of DMA_GSTS_TES
> -Original Message- > From: iommu On Behalf Of Koba Ko > Sent: Sunday, June 14, 2020 10:47 PM > To: David Woodhouse; Lu Baolu; Joerg Roedel > Cc: iommu@lists.linux-foundation.org; Kai Heng Feng; Linux Kernel Mailing > List > Subject: [Issue]platform/x86: iommu: System can't shutdown because iommu > driver keeps checking the status of DMA_GSTS_TES > > hi All, > I have a machine and there's only intel gpu. > the secureboot and vt-d is enabled in BIOS. > On the Ubuntu desktop, I do s2idle first and restart the machine. > The machine can't restart successfully, so I need to press the power > button to shutdown. > I tried each of the following and the issue can't be triggered. > 1. disable secure boot in BIOS. Just to explain why this happens, on many of Dell's systems VT-d is only enabled when secure boot is enabled. > 2. intel_iommu=off. > 3. intel_iomm=igfx_off. > 4. nomodeset > 5. i915.modeset=0. > > After I investigate further, find inte_iommu keeps checking the status > of DMA_GSTS_TES. > During the procedure of restart, the driver would disable iommu translation > and > check the status of DMA_GSTS_TES until status of DMA_GSTS_TES is 0. > > If you need more information, I can provide it. > > Thanks > Koba Ko > ___ > iommu mailing list > iommu@lists.linux-foundation.org > https://lists.linuxfoundation.org/mailman/listinfo/iommu This is reported on TGL pre-production system, but actually same symptom is also happening in ICL production systems such as XPS 7390 2-in-1 and XPS 9300. Details for the ICL issue are available here: https://bugzilla.kernel.org/show_bug.cgi?id=206571 A user did bisect it back to commit 6c3a44ed3c553c324845744f30bcd1d3b07d61fd in 5.5. Glancing through the code and comparing the suspend case, I would ask is it just a case of missing a flush at shutdown (IE iommu_flush_all)? ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [Issue]platform/x86: iommu: System can't shutdown because iommu driver keeps checking the status of DMA_GSTS_TES
Hi Koba KO, On 2020/7/7 11:27, Koba Ko wrote: Dear Baolu, On Tue, Jun 30, 2020 at 3:52 PM Lu Baolu wrote: Hi Koba, On 2020/6/30 15:31, Koba Ko wrote: On Mon, Jun 15, 2020 at 3:20 PM Lu Baolu wrote: Hi Koba Ko, On 2020/6/15 11:19, Koba Ko wrote: hi All, I have a machine and there's only intel gpu. the secureboot and vt-d is enabled in BIOS. On the Ubuntu desktop, I do s2idle first and restart the machine. The machine can't restart successfully, so I need to press the power button to shutdown. I tried each of the following and the issue can't be triggered. 1. disable secure boot in BIOS. 2. intel_iommu=off. 3. intel_iomm=igfx_off. 4. nomodeset 5. i915.modeset=0. After I investigate further, find inte_iommu keeps checking the status of DMA_GSTS_TES. During the procedure of restart, the driver would disable iommu translation and check status of DMA_GSTS_TES until status of DMA_GSTS_TES is 0. If you need more information, I can provide it. Do you mind telling what platform is it? Best regards, baolu Hi Baolu, Sorry, i missed your email. I'm running on TGL. My colleague has reported this on bugzilla. Have tested your patch and it works fine. https://bugzilla.kernel.org/show_bug.cgi?id=208363 Could you explain more about these patches!? Why do we need a flag for active iommu!? We're still investigating this issue. If we find out more, I'll let you know. Thanks a lot for the reporting. Best regards, baolu Sorry for disturbing, Do you have any updates for this issue?! https://bugzilla.kernel.org/show_bug.cgi?id=208363 We are in process of collecting what kind of platforms are affected. I will push the workaround patch to the community as soon as we are done. Best regards, baolu ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [Issue]platform/x86: iommu: System can't shutdown because iommu driver keeps checking the status of DMA_GSTS_TES
Dear Baolu, On Tue, Jun 30, 2020 at 3:52 PM Lu Baolu wrote: > > Hi Koba, > > On 2020/6/30 15:31, Koba Ko wrote: > > On Mon, Jun 15, 2020 at 3:20 PM Lu Baolu wrote: > >> > >> Hi Koba Ko, > >> > >> On 2020/6/15 11:19, Koba Ko wrote: > >>> hi All, > >>> I have a machine and there's only intel gpu. > >>> the secureboot and vt-d is enabled in BIOS. > >>> On the Ubuntu desktop, I do s2idle first and restart the machine. > >>> The machine can't restart successfully, so I need to press the > >>> power button to shutdown. > >>> I tried each of the following and the issue can't be triggered. > >>> 1. disable secure boot in BIOS. > >>> 2. intel_iommu=off. > >>> 3. intel_iomm=igfx_off. > >>> 4. nomodeset > >>> 5. i915.modeset=0. > >>> > >>> After I investigate further, find inte_iommu keeps checking the status > >>> of DMA_GSTS_TES. > >>> During the procedure of restart, the driver would disable iommu > >>> translation and > >>> check status of DMA_GSTS_TES until status of DMA_GSTS_TES is 0. > >>> > >>> If you need more information, I can provide it. > >> > >> Do you mind telling what platform is it? > >> > >> Best regards, > >> baolu > > Hi Baolu, > > Sorry, i missed your email. > > I'm running on TGL. > > My colleague has reported this on bugzilla. > > Have tested your patch and it works fine. > > https://bugzilla.kernel.org/show_bug.cgi?id=208363 > > > > Could you explain more about these patches!? Why do we need a flag > > for active iommu!? > > > > We're still investigating this issue. If we find out more, I'll let you > know. Thanks a lot for the reporting. > > Best regards, > baolu > Sorry for disturbing, Do you have any updates for this issue?! https://bugzilla.kernel.org/show_bug.cgi?id=208363 Koba KO ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [Issue]platform/x86: iommu: System can't shutdown because iommu driver keeps checking the status of DMA_GSTS_TES
Hi Koba, On 2020/6/30 15:31, Koba Ko wrote: On Mon, Jun 15, 2020 at 3:20 PM Lu Baolu wrote: Hi Koba Ko, On 2020/6/15 11:19, Koba Ko wrote: hi All, I have a machine and there's only intel gpu. the secureboot and vt-d is enabled in BIOS. On the Ubuntu desktop, I do s2idle first and restart the machine. The machine can't restart successfully, so I need to press the power button to shutdown. I tried each of the following and the issue can't be triggered. 1. disable secure boot in BIOS. 2. intel_iommu=off. 3. intel_iomm=igfx_off. 4. nomodeset 5. i915.modeset=0. After I investigate further, find inte_iommu keeps checking the status of DMA_GSTS_TES. During the procedure of restart, the driver would disable iommu translation and check status of DMA_GSTS_TES until status of DMA_GSTS_TES is 0. If you need more information, I can provide it. Do you mind telling what platform is it? Best regards, baolu Hi Baolu, Sorry, i missed your email. I'm running on TGL. My colleague has reported this on bugzilla. Have tested your patch and it works fine. https://bugzilla.kernel.org/show_bug.cgi?id=208363 Could you explain more about these patches!? Why do we need a flag for active iommu!? We're still investigating this issue. If we find out more, I'll let you know. Thanks a lot for the reporting. Best regards, baolu ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [Issue]platform/x86: iommu: System can't shutdown because iommu driver keeps checking the status of DMA_GSTS_TES
On Mon, Jun 15, 2020 at 3:20 PM Lu Baolu wrote: > > Hi Koba Ko, > > On 2020/6/15 11:19, Koba Ko wrote: > > hi All, > > I have a machine and there's only intel gpu. > > the secureboot and vt-d is enabled in BIOS. > > On the Ubuntu desktop, I do s2idle first and restart the machine. > > The machine can't restart successfully, so I need to press the > > power button to shutdown. > > I tried each of the following and the issue can't be triggered. > > 1. disable secure boot in BIOS. > > 2. intel_iommu=off. > > 3. intel_iomm=igfx_off. > > 4. nomodeset > > 5. i915.modeset=0. > > > > After I investigate further, find inte_iommu keeps checking the status > > of DMA_GSTS_TES. > > During the procedure of restart, the driver would disable iommu > > translation and > > check status of DMA_GSTS_TES until status of DMA_GSTS_TES is 0. > > > > If you need more information, I can provide it. > > Do you mind telling what platform is it? > > Best regards, > baolu Hi Baolu, Sorry, i missed your email. I'm running on TGL. My colleague has reported this on bugzilla. Have tested your patch and it works fine. https://bugzilla.kernel.org/show_bug.cgi?id=208363 Could you explain more about these patches!? Why do we need a flag for active iommu!? Koba Ko ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
[Issue]platform/x86: iommu: System can't shutdown because iommu driver keeps checking the status of DMA_GSTS_TES
hi All, I have a machine and there's only intel gpu. the secureboot and vt-d is enabled in BIOS. On the Ubuntu desktop, I do s2idle first and restart the machine. The machine can't restart successfully, so I need to press the power button to shutdown. I tried each of the following and the issue can't be triggered. 1. disable secure boot in BIOS. 2. intel_iommu=off. 3. intel_iomm=igfx_off. 4. nomodeset 5. i915.modeset=0. After I investigate further, find inte_iommu keeps checking the status of DMA_GSTS_TES. During the procedure of restart, the driver would disable iommu translation and check status of DMA_GSTS_TES until status of DMA_GSTS_TES is 0. If you need more information, I can provide it. Thanks *Koba Ko* ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
[Issue]platform/x86: iommu: System can't shutdown because iommu driver keeps checking the status of DMA_GSTS_TES
hi All, I have a machine and there's only intel gpu. the secureboot and vt-d is enabled in BIOS. On the Ubuntu desktop, I do s2idle first and restart the machine. The machine can't restart successfully, so I need to press the power button to shutdown. I tried each of the following and the issue can't be triggered. 1. disable secure boot in BIOS. 2. intel_iommu=off. 3. intel_iomm=igfx_off. 4. nomodeset 5. i915.modeset=0. After I investigate further, find inte_iommu keeps checking the status of DMA_GSTS_TES. During the procedure of restart, the driver would disable iommu translation and check the status of DMA_GSTS_TES until status of DMA_GSTS_TES is 0. If you need more information, I can provide it. Thanks Koba Ko ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [Issue]platform/x86: iommu: System can't shutdown because iommu driver keeps checking the status of DMA_GSTS_TES
Hi Koba Ko, On 2020/6/15 11:19, Koba Ko wrote: hi All, I have a machine and there's only intel gpu. the secureboot and vt-d is enabled in BIOS. On the Ubuntu desktop, I do s2idle first and restart the machine. The machine can't restart successfully, so I need to press the power button to shutdown. I tried each of the following and the issue can't be triggered. 1. disable secure boot in BIOS. 2. intel_iommu=off. 3. intel_iomm=igfx_off. 4. nomodeset 5. i915.modeset=0. After I investigate further, find inte_iommu keeps checking the status of DMA_GSTS_TES. During the procedure of restart, the driver would disable iommu translation and check status of DMA_GSTS_TES until status of DMA_GSTS_TES is 0. If you need more information, I can provide it. Do you mind telling what platform is it? Best regards, baolu ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
