Re: [PATCH 01/15] iommu/arm-smmu: Convert GR0 registers to bitfields

2019-08-14 Thread Robin Murphy
On 14/08/2019 18:20, Will Deacon wrote: On Fri, Aug 09, 2019 at 06:07:38PM +0100, Robin Murphy wrote: FIELD_PREP remains a terrible name, but the overall simplification will make further work on this stuff that much more manageable. This also serves as an audit of the header, wherein we can

Re: [PATCH 01/15] iommu/arm-smmu: Convert GR0 registers to bitfields

2019-08-14 Thread Will Deacon
On Fri, Aug 09, 2019 at 06:07:38PM +0100, Robin Murphy wrote: > FIELD_PREP remains a terrible name, but the overall simplification will > make further work on this stuff that much more manageable. This also > serves as an audit of the header, wherein we can impose a consistent > grouping and

[PATCH 01/15] iommu/arm-smmu: Convert GR0 registers to bitfields

2019-08-09 Thread Robin Murphy
FIELD_PREP remains a terrible name, but the overall simplification will make further work on this stuff that much more manageable. This also serves as an audit of the header, wherein we can impose a consistent grouping and ordering of the offset and field definitions Signed-off-by: Robin Murphy