Re: [PATCH 0/5] iommu/amd: fixes for suspend/resume

2022-01-27 Thread Mike Lothian
On Thu, 27 Jan 2022 at 10:22, Maxim Levitsky wrote: > > On Thu, 2022-01-27 at 00:39 +, Mike Lothian wrote: > > On Wed, 26 Jan 2022 at 10:12, Maxim Levitsky wrote: > > > Great, your system does seem to support GA log > > > (but a patch to check if, other that assume blindly that it is

Re: [PATCH 0/5] iommu/amd: fixes for suspend/resume

2022-01-27 Thread Maxim Levitsky
On Thu, 2022-01-27 at 00:39 +, Mike Lothian wrote: > On Wed, 26 Jan 2022 at 10:12, Maxim Levitsky wrote: > > Great, your system does seem to support GA log > > (but a patch to check if, other that assume blindly that it is supported is > > something that should be done). > > > > So could you

Re: [PATCH 0/5] iommu/amd: fixes for suspend/resume

2022-01-26 Thread Mike Lothian
On Wed, 26 Jan 2022 at 10:12, Maxim Levitsky wrote: > > Great, your system does seem to support GA log > (but a patch to check if, other that assume blindly that it is supported is > something that should be done). > > So could you bump the LOOP_TIMEOUT like by 10x or so and see if the problem >

Re: [PATCH 0/5] iommu/amd: fixes for suspend/resume

2022-01-26 Thread Maxim Levitsky
On Wed, 2022-01-26 at 09:54 +, Mike Lothian wrote: > On Wed, 26 Jan 2022 at 07:34, Maxim Levitsky wrote: > > Could you post the whole dmesg, or at least: > > > > dmesg | grep AMD-Vi > > > > > > What CPU does your system have? > > > > I suspect that your system doesn't GA log feature

Re: [PATCH 0/5] iommu/amd: fixes for suspend/resume

2022-01-26 Thread Mike Lothian
On Wed, 26 Jan 2022 at 07:34, Maxim Levitsky wrote: > > Could you post the whole dmesg, or at least: > > dmesg | grep AMD-Vi > > > What CPU does your system have? > > I suspect that your system doesn't GA log feature enabled in the IOMMU, and > the code never checks > for that, and here it fails

Re: [PATCH 0/5] iommu/amd: fixes for suspend/resume

2022-01-25 Thread Maxim Levitsky
On Tue, 2022-01-25 at 23:25 +, Mike Lothian wrote: > On Tue, 25 Jan 2022 at 19:26, Maxim Levitsky wrote: > > Could you just apply these patches on top of 5.15 kernel and see if you get > > the warning? > > > > If something could case it is I think patch 1, it does move the GA log > >

Re: [PATCH 0/5] iommu/amd: fixes for suspend/resume

2022-01-25 Thread Mike Lothian
On Tue, 25 Jan 2022 at 19:26, Maxim Levitsky wrote: > > Could you just apply these patches on top of 5.15 kernel and see if you get > the warning? > > If something could case it is I think patch 1, it does move the GA log enabled > to be a bit later. > I also added few warnings there. I wonder

Re: [PATCH 0/5] iommu/amd: fixes for suspend/resume

2022-01-25 Thread Maxim Levitsky
On Tue, 2022-01-25 at 15:08 +, Mike Lothian wrote: > Hi > > I'm seeing a WARNING that I think might be related to these patches, > unfortunately another issue is making bisecting difficult > > [0.359362] AMD-Vi: X2APIC enabled > [0.395140] [ cut here ] > [

Re: [PATCH 0/5] iommu/amd: fixes for suspend/resume

2022-01-25 Thread Mike Lothian
Hi I'm seeing a WARNING that I think might be related to these patches, unfortunately another issue is making bisecting difficult [0.359362] AMD-Vi: X2APIC enabled [0.395140] [ cut here ] [0.395142] WARNING: CPU: 0 PID: 1 at

Re: [PATCH 0/5] iommu/amd: fixes for suspend/resume

2021-12-17 Thread Joerg Roedel
On Tue, Nov 23, 2021 at 06:10:33PM +0200, Maxim Levitsky wrote: > Maxim Levitsky (5): > iommu/amd: restore GA log/tail pointer on host resume > iommu/amd: x2apic mode: re-enable after resume > iommu/amd: x2apic mode: setup the INTX registers on mask/unmask > iommu/amd: x2apic mode:

Re: [PATCH 0/5] iommu/amd: fixes for suspend/resume

2021-12-10 Thread Maxim Levitsky
On Thu, 2021-12-02 at 01:08 +0200, Maxim Levitsky wrote: > On Tue, 2021-11-23 at 18:10 +0200, Maxim Levitsky wrote: > > As I sadly found out, a s3 cycle makes the AMD's iommu stop sending > > interrupts > > until the system is rebooted. > > > > I only noticed it now because otherwise the IOMMU

Re: [PATCH 0/5] iommu/amd: fixes for suspend/resume

2021-12-06 Thread Joerg Roedel
On Tue, Nov 23, 2021 at 06:10:33PM +0200, Maxim Levitsky wrote: > Best regards, >Maxim Levitsky > > Maxim Levitsky (5): > iommu/amd: restore GA log/tail pointer on host resume > iommu/amd: x2apic mode: re-enable after resume > iommu/amd: x2apic mode: setup the INTX registers on

Re: [PATCH 0/5] iommu/amd: fixes for suspend/resume

2021-12-01 Thread Maxim Levitsky
On Tue, 2021-11-23 at 18:10 +0200, Maxim Levitsky wrote: > As I sadly found out, a s3 cycle makes the AMD's iommu stop sending interrupts > until the system is rebooted. > > I only noticed it now because otherwise the IOMMU works, and these interrupts > are only used for errors and for GA log