Re: [PATCH v2 0/4] iommu: Add device fault reporting API
On Wed, 12 Jun 2019 15:11:43 +0200 Joerg Roedel wrote: > On Wed, Jun 12, 2019 at 12:54:51PM +0100, Jean-Philippe Brucker wrote: > > Thanks! As discussed I think we need to add padding into the > > iommu_fault structure before this reaches mainline, to make the > > UAPI easier to extend in the future. It's already possible to > > extend but requires introducing a new ABI version number and > > support two structures. Adding some padding would only require > > introducing new flags. If there is no objection I'll send a > > one-line patch bumping the structure size to 64 bytes (currently > > 48) > > Sounds good, please submit the patch. > Could you also add padding to page response per our discussion here? https://lkml.org/lkml/2019/6/12/1131 > Regards, > > Joerg [Jacob Pan]
Re: [PATCH v2 0/4] iommu: Add device fault reporting API
On Wed, Jun 12, 2019 at 12:54:51PM +0100, Jean-Philippe Brucker wrote: > Thanks! As discussed I think we need to add padding into the iommu_fault > structure before this reaches mainline, to make the UAPI easier to > extend in the future. It's already possible to extend but requires > introducing a new ABI version number and support two structures. Adding > some padding would only require introducing new flags. If there is no > objection I'll send a one-line patch bumping the structure size to 64 > bytes (currently 48) Sounds good, please submit the patch. Regards, Joerg
Re: [PATCH v2 0/4] iommu: Add device fault reporting API
On 12/06/2019 09:19, Joerg Roedel wrote: > On Mon, Jun 03, 2019 at 03:57:45PM +0100, Jean-Philippe Brucker wrote: >> Jacob Pan (3): >> driver core: Add per device iommu param >> iommu: Introduce device fault data >> iommu: Introduce device fault report API >> >> Jean-Philippe Brucker (1): >> iommu: Add recoverable fault reporting >> >> drivers/iommu/iommu.c | 236 - >> include/linux/device.h | 3 + >> include/linux/iommu.h | 87 ++ >> include/uapi/linux/iommu.h | 153 >> 4 files changed, 476 insertions(+), 3 deletions(-) >> create mode 100644 include/uapi/linux/iommu.h > > Applied, thanks. Thanks! As discussed I think we need to add padding into the iommu_fault structure before this reaches mainline, to make the UAPI easier to extend in the future. It's already possible to extend but requires introducing a new ABI version number and support two structures. Adding some padding would only require introducing new flags. If there is no objection I'll send a one-line patch bumping the structure size to 64 bytes (currently 48) Thanks, Jean
Re: [PATCH v2 0/4] iommu: Add device fault reporting API
On Mon, Jun 03, 2019 at 03:57:45PM +0100, Jean-Philippe Brucker wrote: > Jacob Pan (3): > driver core: Add per device iommu param > iommu: Introduce device fault data > iommu: Introduce device fault report API > > Jean-Philippe Brucker (1): > iommu: Add recoverable fault reporting > > drivers/iommu/iommu.c | 236 - > include/linux/device.h | 3 + > include/linux/iommu.h | 87 ++ > include/uapi/linux/iommu.h | 153 > 4 files changed, 476 insertions(+), 3 deletions(-) > create mode 100644 include/uapi/linux/iommu.h Applied, thanks.
Re: [PATCH v2 0/4] iommu: Add device fault reporting API
On 03/06/2019 22:59, Jacob Pan wrote: > On Mon, 3 Jun 2019 15:57:45 +0100 > Jean-Philippe Brucker wrote: > >> Allow device drivers and VFIO to get notified on IOMMU translation >> fault, and handle recoverable faults (PCI PRI). Several series require >> this API (Intel VT-d and Arm SMMUv3 nested support, as well as the >> generic host SVA implementation). >> >> Changes since v1 [1]: >> * Allocate iommu_param earlier, in iommu_probe_device(). >> * Pass struct iommu_fault to fault handlers, instead of the >> iommu_fault_event wrapper. >> * Removed unused iommu_fault_event::iommu_private. >> * Removed unnecessary iommu_page_response::addr. >> * Added iommu_page_response::version, which would allow to introduce a >> new incompatible iommu_page_response structure (as opposed to just >> adding a flag + field). >> >> [1] [PATCH 0/4] iommu: Add device fault reporting API >> >> https://lore.kernel.org/lkml/20190523180613.55049-1-jean-philippe.bruc...@arm.com/ >> >> Jacob Pan (3): >> driver core: Add per device iommu param >> iommu: Introduce device fault data >> iommu: Introduce device fault report API >> >> Jean-Philippe Brucker (1): >> iommu: Add recoverable fault reporting >> > This interface meet the need for vt-d, just one more comment on 2/4. Do > you want to add Co-developed-by you for the three patches from me? I'm fine without it, I don't think it adds much to the Signed-off-by, which is required Thanks, Jean ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v2 0/4] iommu: Add device fault reporting API
On Mon, 3 Jun 2019 15:57:45 +0100 Jean-Philippe Brucker wrote: > Allow device drivers and VFIO to get notified on IOMMU translation > fault, and handle recoverable faults (PCI PRI). Several series require > this API (Intel VT-d and Arm SMMUv3 nested support, as well as the > generic host SVA implementation). > > Changes since v1 [1]: > * Allocate iommu_param earlier, in iommu_probe_device(). > * Pass struct iommu_fault to fault handlers, instead of the > iommu_fault_event wrapper. > * Removed unused iommu_fault_event::iommu_private. > * Removed unnecessary iommu_page_response::addr. > * Added iommu_page_response::version, which would allow to introduce a > new incompatible iommu_page_response structure (as opposed to just > adding a flag + field). > > [1] [PATCH 0/4] iommu: Add device fault reporting API > > https://lore.kernel.org/lkml/20190523180613.55049-1-jean-philippe.bruc...@arm.com/ > > Jacob Pan (3): > driver core: Add per device iommu param > iommu: Introduce device fault data > iommu: Introduce device fault report API > > Jean-Philippe Brucker (1): > iommu: Add recoverable fault reporting > This interface meet the need for vt-d, just one more comment on 2/4. Do you want to add Co-developed-by you for the three patches from me? Thanks, Jacob > drivers/iommu/iommu.c | 236 > - include/linux/device.h | > 3 + include/linux/iommu.h | 87 ++ > include/uapi/linux/iommu.h | 153 > 4 files changed, 476 insertions(+), 3 deletions(-) > create mode 100644 include/uapi/linux/iommu.h > ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
