Re: [Ipmitool-devel] Sensor display logic issues

2012-02-21 Thread Jim Mank
ts. >> >> A patch for this had been submitted upstream by Dann Frazier a couple >> years ago. Not sure where it went. >> >> Pat >> >> >> -Original Message- >> From: Albert Chu [mailto:ch...@llnl.gov] >> Sent: Tuesday, February 21, 2012 1

Re: [Ipmitool-devel] Sensor display logic issues

2012-02-21 Thread Jim Mank
units are identified in "Sensor Units 1". -- Jim Mankovich | jm...@hp.com -- On 2/21/2012 12:11 PM, Albert Chu wrote: > Hi Jim, > > On Tue, 2012-02-21 at 10:03 -0800, Jim Mank wrote: >> All, >> >> I've been looking a incorrect sensor display issues with th

[Ipmitool-devel] Sensor display logic issues

2012-02-21 Thread Jim Mank
All, I've been looking a incorrect sensor display issues with the ipmitool that I would like to get some feedback on before proposing a specific solution. 1. ipmitool does not properly decode discrete vrs analog units in all cases 2. ipmitool does not correctly identify the Threshold Sens

Re: [Ipmitool-devel] lanplus session close failures

2012-02-17 Thread Jim Mank
Zdenek, I'm going clean up the indentation some and then commit the change. Thanks, -- Jim Mankovich | jm...@hp.com -- On 2/17/2012 8:13 AM, Zdenek Styblik wrote: > On Fri, Feb 17, 2012 at 3:54 PM, Jim Mank wrote: >> All, >> >> Just to close the loop, here is the

Re: [Ipmitool-devel] lanplus session close failures

2012-02-17 Thread Jim Mank
9:43 AM, Jim Mank wrote: Zdenek, To answer your questions, I did test the patch and it does resolve the problem. I just now fixed up the indentation on the return statement. As Andy pointed out, -t is used to specify a one byte IPMI slave address so the parsing of the -t argument is correct

Re: [Ipmitool-devel] lanplus session close failures

2012-02-16 Thread Jim Mank
...@hp.com -- On 2/16/2012 6:53 AM, Zdenek Styblik wrote: > On Wed, Feb 15, 2012 at 7:12 PM, Jim Mank wrote: >> All, > [...] >> I've attached a patch with does resolve the "Close Session command failure" >> for lanplus. >> Please let me know if I corr

[Ipmitool-devel] lanplus session close failures

2012-02-15 Thread Jim Mank
All, We have run across the following problem when using the ipmitool lanplus interface to perform bridged IPMI commands (using the -b -t or -m switches in conjunction with -I lanplus). Use of lanplus and bridging will result in a "Close Session command failure". This problem is due to tw

Re: [Ipmitool-devel] ipmitool fix to display percentage units correctly

2012-02-14 Thread Jim Mank
d then spaces which doesn't align to above. > I can't think of anything else looking at the diff. Perhaps > indentations here and there, but I don't know(nit picking). > > Regards, > Z. > > On Mon, Feb 13, 2012 at 3:36 PM, Jim Mank wrote: >> Z, >> >>

Re: [Ipmitool-devel] ipmitool fix to display percentage units correctly

2012-02-13 Thread Jim Mank
should it be: static char * ipmi_sdr_get_unit_string(uint8_t pct, uint8_t type, uint8_t base, uint8_t modifier) { ... } as well? Regards, Z. On Thu, Feb 9, 2012 at 10:01 PM, Jim Mank wrote: [...] Any/All comments and questions would be much appreciated. /* ipmi_sdr_get_unit_string - return u

Re: [Ipmitool-devel] ipmitool fix to display percentage units correctly

2012-02-13 Thread Jim Mank
: > > static char * > ipmi_sdr_get_unit_string(uint8_t pct, uint8_t type, uint8_t base, > uint8_t modifier) > { ... } > > as well? > > Regards, > Z. > > On Thu, Feb 9, 2012 at 10:01 PM, Jim Mank wrote: > [...] >> Any/All comments and questions would be much appreciated. >&g

Re: [Ipmitool-devel] ipmitool fix to display percentage units correctly

2012-02-09 Thread Jim Mank
} else { snprintf(unitstr, sizeof (unitstr), "%s%s", pctstr, unit_desc[base]); } break; } return unitstr; } -- Jim Mankovich | jm...@hp.com -- On 2/8/2012 12:04 PM, Jim Mank wrote:

Re: [Ipmitool-devel] ipmitool fix to display percentage units correctly

2012-02-08 Thread Jim Mank
nit specification could cause problems if platform IPMI implementations were done that did not interpret the percent bit in exactly the way we are talking about it. -- Jim Mankovich | jm...@hp.com -- On 2/8/2012 11:01 AM, Albert Chu wrote: > Hi Jim, > > On Wed, 2012-02-08 at 08:37

[Ipmitool-devel] ipmitool fix to display percentage units correctly

2012-02-08 Thread Jim Mank
All, I would like to start contributing to the ipmitool project and as a initial task I thought I would resolve the open bug associated with ipmitool's inability to display percentage units correctly (https://sourceforge.net/tracker/?func=detail&aid=3014014&group_id=95200&atid=610550). I'm