[Ipmitool-devel] Sensor display logic issues

2012-02-21 Thread Jim Mank
All, I've been looking a incorrect sensor display issues with the ipmitool that I would like to get some feedback on before proposing a specific solution. 1. ipmitool does not properly decode discrete vrs analog units in all cases 2. ipmitool does not correctly identify the Threshold

Re: [Ipmitool-devel] Sensor display logic issues

2012-02-21 Thread Jim Mank
that the units are identified in Sensor Units 1. -- Jim Mankovich | jm...@hp.com -- On 2/21/2012 12:11 PM, Albert Chu wrote: Hi Jim, On Tue, 2012-02-21 at 10:03 -0800, Jim Mank wrote: All, I've been looking a incorrect sensor display issues with the ipmitool that I would like to get some feedback

Re: [Ipmitool-devel] Sensor display logic issues

2012-02-21 Thread Jim Mank
Hi Jim, On Tue, 2012-02-21 at 10:03 -0800, Jim Mank wrote: All, I've been looking a incorrect sensor display issues with the ipmitool that I would like to get some feedback on before proposing a specific solution. 1. ipmitool does not properly decode discrete vrs analog units

Re: [Ipmitool-devel] lanplus session close failures

2012-02-17 Thread Jim Mank
9:43 AM, Jim Mank wrote: Zdenek, To answer your questions, I did test the patch and it does resolve the problem. I just now fixed up the indentation on the return statement. As Andy pointed out, -t is used to specify a one byte IPMI slave address so the parsing of the -t argument is correct

Re: [Ipmitool-devel] lanplus session close failures

2012-02-17 Thread Jim Mank
to be done :) btw as for my question about '-t' - I was the one whom put input checking in place, so it was kind of panic attack whether I haven't messed up something. Z. -- Jim Mankovich | jm...@hp.com -- On 2/16/2012 9:43 AM, Jim Mank wrote: Zdenek, To answer your questions, I did test

Re: [Ipmitool-devel] lanplus session close failures

2012-02-16 Thread Jim Mank
Zdenek, To answer your questions, I did test the patch and it does resolve the problem. I just now fixed up the indentation on the return statement. As Andy pointed out, -t is used to specify a one byte IPMI slave address so the parsing of the -t argument is correct. -- Jim Mankovich |

Re: [Ipmitool-devel] ipmitool fix to display percentage units correctly

2012-02-14 Thread Jim Mank
); } else { snprintf(unitstr, sizeof (unitstr), %s%s, pctstr, unit_desc[base]); } break; } return unitstr; } -- Jim Mankovich | jm...@hp.com -- On 2/8/2012 12:04 PM, Jim Mank

Re: [Ipmitool-devel] ipmitool fix to display percentage units correctly

2012-02-13 Thread Jim Mank
; } return unitstr; } -- Jim Mankovich | jm...@hp.com -- On 2/8/2012 12:04 PM, Jim Mank wrote: Al, It does appear from the spec that percent can be applied to any validly specified Unit given that is an independent bit that can be specified in addition to the Base/Modifier units

Re: [Ipmitool-devel] ipmitool fix to display percentage units correctly

2012-02-13 Thread Jim Mank
); } else { snprintf(unitstr, sizeof (unitstr), %s%s, pctstr, unit_desc[base]); } break; } return unitstr; } -- Jim Mankovich | jm...@hp.com -- On 2/8/2012 12:04 PM, Jim Mank

Re: [Ipmitool-devel] ipmitool fix to display percentage units correctly

2012-02-09 Thread Jim Mank
]); } break; } return unitstr; } -- Jim Mankovich | jm...@hp.com -- On 2/8/2012 12:04 PM, Jim Mank wrote: Al, It does appear from the spec that percent can be applied to any validly specified Unit given that is an independent bit that can be specified

[Ipmitool-devel] ipmitool fix to display percentage units correctly

2012-02-08 Thread Jim Mank
All, I would like to start contributing to the ipmitool project and as a initial task I thought I would resolve the open bug associated with ipmitool's inability to display percentage units correctly (https://sourceforge.net/tracker/?func=detailaid=3014014group_id=95200atid=610550). I'm