Re: [Ipmitool-devel] [PATCH 1/2] Add the instance to the SOL commands

2013-03-27 Thread Zdenek Styblik
On Mon, Mar 25, 2013 at 5:01 PM, Corey Minyard wrote: > On 03/25/2013 05:29 AM, Zdenek Styblik wrote: >> >> On Mon, Mar 25, 2013 at 10:16 AM, Zdenek Styblik >> wrote: >>> >>> On Fri, Mar 22, 2013 at 2:40 PM, Corey Minyard >>> wrote: The SOL protocol supports multiple serial ports using

Re: [Ipmitool-devel] [PATCH 1/2] Add the instance to the SOL commands

2013-03-25 Thread Corey Minyard
On 03/25/2013 05:29 AM, Zdenek Styblik wrote: > On Mon, Mar 25, 2013 at 10:16 AM, Zdenek Styblik > wrote: >> On Fri, Mar 22, 2013 at 2:40 PM, Corey Minyard wrote: >>> The SOL protocol supports multiple serial ports using the "instance", >>> allow this to be passed in to ipmitool. >>> >> Corey, >>

Re: [Ipmitool-devel] [PATCH 1/2] Add the instance to the SOL commands

2013-03-25 Thread Zdenek Styblik
On Mon, Mar 25, 2013 at 10:16 AM, Zdenek Styblik wrote: > On Fri, Mar 22, 2013 at 2:40 PM, Corey Minyard wrote: >> The SOL protocol supports multiple serial ports using the "instance", >> allow this to be passed in to ipmitool. >> > > Corey, > > please, use str2*() functions from 'lib/helper.c' r

Re: [Ipmitool-devel] [PATCH 1/2] Add the instance to the SOL commands

2013-03-25 Thread Zdenek Styblik
On Mon, Mar 25, 2013 at 10:16 AM, Zdenek Styblik wrote: > On Fri, Mar 22, 2013 at 2:40 PM, Corey Minyard wrote: >> The SOL protocol supports multiple serial ports using the "instance", >> allow this to be passed in to ipmitool. >> > > Corey, > > please, use str2*() functions from 'lib/helper.c' r

Re: [Ipmitool-devel] [PATCH 1/2] Add the instance to the SOL commands

2013-03-25 Thread Zdenek Styblik
On Fri, Mar 22, 2013 at 2:40 PM, Corey Minyard wrote: > The SOL protocol supports multiple serial ports using the "instance", > allow this to be passed in to ipmitool. > Corey, please, use str2*() functions from 'lib/helper.c' rather than strtol(). Unless this is fixed, I'm against getting this

Re: [Ipmitool-devel] [PATCH 1/2] Add the instance to the SOL commands

2013-03-22 Thread Corey Minyard
Hank, The ability to query the name is useful, but I don't really have a way to implement it or test it. If it's compatible with the spec (like you are using an OEM parameter and the set selector) it would be cool to implement. But I don't have access to the HPM.2 spec. The IPMI 2.0 spec all

Re: [Ipmitool-devel] [PATCH 1/2] Add the instance to the SOL commands

2013-03-22 Thread Hank Bruning
Cory, Just an idea. In PICMG HPM.2 we added that capability to use 255 serial ports per IPM Controller and and can query the name of each. Only 14(might be +1/-1) are allowed active per IPMI at one time. Maybe the sytanx should allow for mapping X to Y where X is an active IPMI SOL session(one of 1

[Ipmitool-devel] [PATCH 1/2] Add the instance to the SOL commands

2013-03-22 Thread Corey Minyard
The SOL protocol supports multiple serial ports using the "instance", allow this to be passed in to ipmitool. Index: doc/ipmitool.1 === RCS file: /cvsroot/ipmitool/ipmitool/doc/ipmitool.1,v retrieving revision 1.50 diff -u -r1.50 ipm