Re: [Ipmitool-devel] SEL code review nits

2010-02-22 Thread Al Chu
; -Original Message- > From: Al Chu [mailto:ch...@llnl.gov] > Sent: Friday, February 19, 2010 1:44 PM > To: ipmitool-devel@lists.sourceforge.net > Subject: [Ipmitool-devel] SEL code review nits > > Saw these as I was looking through the ipmitool SEL code. > &g

Re: [Ipmitool-devel] SEL code review nits

2010-02-22 Thread Andy Cress
panic string is an ASCII string, it needs to be displayed as ASCII rather than raw HEX. Andy -Original Message- From: Al Chu [mailto:ch...@llnl.gov] Sent: Friday, February 19, 2010 1:44 PM To: ipmitool-devel@lists.sourceforge.net Subject: [Ipmitool-devel] SEL code review nits Saw these

[Ipmitool-devel] SEL code review nits

2010-02-19 Thread Al Chu
Saw these as I was looking through the ipmitool SEL code. A) evt->record_type = 0; if (evt->record_type < 0xc0) { } else if (evt->record_type < 0xe0) { } else { } The evt->record_type