Re: [Ipmitool-devel] lanplus session close failures

2012-02-17 Thread Jim Mank
Zdenek, I'm going clean up the indentation some and then commit the change. Thanks, -- Jim Mankovich | jm...@hp.com -- On 2/17/2012 8:13 AM, Zdenek Styblik wrote: > On Fri, Feb 17, 2012 at 3:54 PM, Jim Mank wrote: >> All, >> >> Just to close the loop, here is the patch with the indentation ch

Re: [Ipmitool-devel] lanplus session close failures

2012-02-17 Thread Zdenek Styblik
On Fri, Feb 17, 2012 at 3:54 PM, Jim Mank wrote: > All, > > Just to close the loop, here is the patch with the indentation changed :) > > It looks to me like the indentation in this part of the file is pretty > messed up.   Is it reasonable for me to fix up more indentation before I > commit this

Re: [Ipmitool-devel] lanplus session close failures

2012-02-17 Thread Jim Mank
All, Just to close the loop, here is the patch with the indentation changed :) It looks to me like the indentation in this part of the file is pretty messed up. Is it reasonable for me to fix up more indentation before I commit this change? -- Jim Mankovich | jm...@hp.com -- On 2/16/2012

Re: [Ipmitool-devel] lanplus session close failures

2012-02-16 Thread Jim Mank
Zdenek, To answer your questions, I did test the patch and it does resolve the problem. I just now fixed up the indentation on the return statement. As Andy pointed out, -t is used to specify a one byte IPMI slave address so the parsing of the -t argument is correct. -- Jim Mankovich | jm...@hp

Re: [Ipmitool-devel] lanplus session close failures

2012-02-16 Thread Zdenek Styblik
On Thu, Feb 16, 2012 at 3:21 PM, Andy Cress wrote: > Zdenek, > > RE: 'lib/ipmi_main.c' >> I presume '-t' should accept either FQDN or IP address, thus lines >> above are wrong, aren't they? Or is it a hex as in case of '-m'? > > The -t option supplies an IPMI slave address (one byte). > > Andy >

Re: [Ipmitool-devel] lanplus session close failures

2012-02-16 Thread Andy Cress
Zdenek, RE: 'lib/ipmi_main.c' > I presume '-t' should accept either FQDN or IP address, thus lines > above are wrong, aren't they? Or is it a hex as in case of '-m'? The -t option supplies an IPMI slave address (one byte). Andy

Re: [Ipmitool-devel] lanplus session close failures

2012-02-16 Thread Zdenek Styblik
On Wed, Feb 15, 2012 at 7:12 PM, Jim Mank wrote: > All, [...] > I've attached a patch with does resolve the "Close Session command failure" > for lanplus. > Please let me know if I correctly characterized the problem and applied a > correct solution. > I don't know about this issue(without lookin

[Ipmitool-devel] lanplus session close failures

2012-02-15 Thread Jim Mank
All, We have run across the following problem when using the ipmitool lanplus interface to perform bridged IPMI commands (using the -b -t or -m switches in conjunction with -I lanplus). Use of lanplus and bridging will result in a "Close Session command failure". This problem is due to tw