On Fri, Mar 22, 2013 at 2:40 PM, Corey Minyard wrote:
> The SOL protocol supports multiple serial ports using the "instance",
> allow this to be passed in to ipmitool.
>
Corey,
please, use str2*() functions from 'lib/helper.c' rather than
strtol(). Unless this is fixed, I'm against getting this
On Fri, Mar 22, 2013 at 2:42 PM, Corey Minyard wrote:
> The event data and SDRs support assertions and deassertions for
> threshold events as well as
> discrete events. So print out assertion and deassertion on all events.
>
Corey,
is it possible to change coding style to ``if (...) { ... } els
On Fri, Mar 22, 2013 at 2:39 PM, Corey Minyard wrote:
> I sent both of these in previously and I didn't hear anything. These are
> some minor enhancements to ipmitool
>
> -corey
>
Hello Corey,
I'm almost sure I've ignored these, because I have no access to
servers with SOL support. And I did it
On Mon, Mar 25, 2013 at 10:16 AM, Zdenek Styblik
wrote:
> On Fri, Mar 22, 2013 at 2:40 PM, Corey Minyard wrote:
>> The SOL protocol supports multiple serial ports using the "instance",
>> allow this to be passed in to ipmitool.
>>
>
> Corey,
>
> please, use str2*() functions from 'lib/helper.c' r
On Mon, Mar 25, 2013 at 10:16 AM, Zdenek Styblik
wrote:
> On Fri, Mar 22, 2013 at 2:40 PM, Corey Minyard wrote:
>> The SOL protocol supports multiple serial ports using the "instance",
>> allow this to be passed in to ipmitool.
>>
>
> Corey,
>
> please, use str2*() functions from 'lib/helper.c' r
Beware, excavations below.
Looking at the proposed change and at the values already printed...
The new: (evt->sel_type.standard_type.event_dir ? "Deasserted" : "Asserted"),
And old: ((evt->sel_type.standard_type.event_data[0] & 0xf) % 2) ? ">" : "<",
The old line does not make much sense to me.
Ignore the part with the 2005 changeset. Missed the hunk beginning.
So I am back at: "What is the event_data[0] supposed to be doing there?"
- Original Message -
From: "Ales Ledvinka"
To: miny...@acm.org
Cc: ipmitool-devel@lists.sourceforge.net
Sent: Monday, March 25, 2013 3:41:25 PM
Subj
On 03/25/2013 05:29 AM, Zdenek Styblik wrote:
> On Mon, Mar 25, 2013 at 10:16 AM, Zdenek Styblik
> wrote:
>> On Fri, Mar 22, 2013 at 2:40 PM, Corey Minyard wrote:
>>> The SOL protocol supports multiple serial ports using the "instance",
>>> allow this to be passed in to ipmitool.
>>>
>> Corey,
>>
On 03/25/2013 04:16 AM, Zdenek Styblik wrote:
> On Fri, Mar 22, 2013 at 2:42 PM, Corey Minyard wrote:
>> The event data and SDRs support assertions and deassertions for
>> threshold events as well as
>> discrete events. So print out assertion and deassertion on all events.
>>
> Corey,
>
> is it p
Hi Zdenek,
On Fri, Mar 22, 2013 at 9:12 AM, Zdenek Styblik
wrote:
> Hello all,
>
> attached is a rather large diff which sets all pointers in ipmitool to
> NULL right after free() is called. The aim of the patch is not to
> investigate whether there these pointers are being freed elsewhere
> agai
On Mon, Mar 25, 2013 at 7:59 PM, Dan Gora wrote:
[...]
>> 1] check whether really all of ``free(p); p = NULL;'' are handled
>
> Not entirely clear really
> If I do this in the ipmitool cvs tree:
>
> find . -name '*.c' |xargs egrep free.?\\\(|wc
>
> I get:
>
> dg:speedy:ipmitool(master) => find
On Mon, Mar 25, 2013 at 9:00 PM, Dan Gora wrote:
> On Mon, Mar 25, 2013 at 4:54 PM, Zdenek Styblik
> wrote:
>> Because not every free() case needs this patch, I guess. I went
>> through the sources again and it looks ok to me.
>
> Agreed.. I didn't see anything wrong with any of it, but to prove
On Mon, Mar 25, 2013 at 4:54 PM, Zdenek Styblik
wrote:
> Because not every free() case needs this patch, I guess. I went
> through the sources again and it looks ok to me.
Agreed.. I didn't see anything wrong with any of it, but to prove that
nothing is missing is a harder question...
>> I guess
13 matches
Mail list logo
