Re: [Ipmitool-devel] [PATCH 2/2] Add assertion/deassertion to threshold events

2013-03-25 Thread Zdenek Styblik
On Fri, Mar 22, 2013 at 2:42 PM, Corey Minyard tcminy...@gmail.com wrote: The event data and SDRs support assertions and deassertions for threshold events as well as discrete events. So print out assertion and deassertion on all events. Corey, is it possible to change coding style to ``if

Re: [Ipmitool-devel] [PATCH 0/2] Some minor enhancements to SOL and event printing

2013-03-25 Thread Zdenek Styblik
On Fri, Mar 22, 2013 at 2:39 PM, Corey Minyard tcminy...@gmail.com wrote: I sent both of these in previously and I didn't hear anything. These are some minor enhancements to ipmitool -corey Hello Corey, I'm almost sure I've ignored these, because I have no access to servers with SOL

Re: [Ipmitool-devel] [PATCH 1/2] Add the instance to the SOL commands

2013-03-25 Thread Zdenek Styblik
On Mon, Mar 25, 2013 at 10:16 AM, Zdenek Styblik zdenek.styb...@gmail.com wrote: On Fri, Mar 22, 2013 at 2:40 PM, Corey Minyard tcminy...@gmail.com wrote: The SOL protocol supports multiple serial ports using the instance, allow this to be passed in to ipmitool. Corey, please, use str2*()

Re: [Ipmitool-devel] [PATCH 1/2] Add the instance to the SOL commands

2013-03-25 Thread Zdenek Styblik
On Mon, Mar 25, 2013 at 10:16 AM, Zdenek Styblik zdenek.styb...@gmail.com wrote: On Fri, Mar 22, 2013 at 2:40 PM, Corey Minyard tcminy...@gmail.com wrote: The SOL protocol supports multiple serial ports using the instance, allow this to be passed in to ipmitool. Corey, please, use str2*()

Re: [Ipmitool-devel] [PATCH 0/2] Some minor enhancements to SOL and event printing

2013-03-25 Thread Ales Ledvinka
Beware, excavations below. Looking at the proposed change and at the values already printed... The new: (evt-sel_type.standard_type.event_dir ? Deasserted : Asserted), And old: ((evt-sel_type.standard_type.event_data[0] 0xf) % 2) ? : , The old line does not make much sense to me. The spec

Re: [Ipmitool-devel] [PATCH 0/2] Some minor enhancements to SOL and event printing

2013-03-25 Thread Ales Ledvinka
Ignore the part with the 2005 changeset. Missed the hunk beginning. So I am back at: What is the event_data[0] supposed to be doing there? - Original Message - From: Ales Ledvinka aledv...@redhat.com To: miny...@acm.org Cc: ipmitool-devel@lists.sourceforge.net Sent: Monday, March 25, 2013

Re: [Ipmitool-devel] [PATCH 1/2] Add the instance to the SOL commands

2013-03-25 Thread Corey Minyard
On 03/25/2013 05:29 AM, Zdenek Styblik wrote: On Mon, Mar 25, 2013 at 10:16 AM, Zdenek Styblik zdenek.styb...@gmail.com wrote: On Fri, Mar 22, 2013 at 2:40 PM, Corey Minyard tcminy...@gmail.com wrote: The SOL protocol supports multiple serial ports using the instance, allow this to be passed

Re: [Ipmitool-devel] [PATCH 2/2] Add assertion/deassertion to threshold events

2013-03-25 Thread Corey Minyard
On 03/25/2013 04:16 AM, Zdenek Styblik wrote: On Fri, Mar 22, 2013 at 2:42 PM, Corey Minyard tcminy...@gmail.com wrote: The event data and SDRs support assertions and deassertions for threshold events as well as discrete events. So print out assertion and deassertion on all events. Corey,

Re: [Ipmitool-devel] Code Review - ID#3608149 - always set free()-d pointer to NULL

2013-03-25 Thread Dan Gora
Hi Zdenek, On Fri, Mar 22, 2013 at 9:12 AM, Zdenek Styblik zdenek.styb...@gmail.com wrote: Hello all, attached is a rather large diff which sets all pointers in ipmitool to NULL right after free() is called. The aim of the patch is not to investigate whether there these pointers are being

Re: [Ipmitool-devel] Code Review - ID#3608149 - always set free()-d pointer to NULL

2013-03-25 Thread Zdenek Styblik
On Mon, Mar 25, 2013 at 9:00 PM, Dan Gora dan.g...@gmail.com wrote: On Mon, Mar 25, 2013 at 4:54 PM, Zdenek Styblik zdenek.styb...@gmail.com wrote: Because not every free() case needs this patch, I guess. I went through the sources again and it looks ok to me. Agreed.. I didn't see anything

Re: [Ipmitool-devel] Code Review - ID#3608149 - always set free()-d pointer to NULL

2013-03-25 Thread Dan Gora
On Mon, Mar 25, 2013 at 4:54 PM, Zdenek Styblik zdenek.styb...@gmail.com wrote: Because not every free() case needs this patch, I guess. I went through the sources again and it looks ok to me. Agreed.. I didn't see anything wrong with any of it, but to prove that nothing is missing is a harder