Re: [Ipmitool-devel] Code Review - ID: 3603419 - 'lib/ipmi_dcmi.c' - waste of resources

2013-03-14 Thread Ales Ledvinka
Though when -I lanplus -I lan is on the command line the original wording is better. This is ack for any change there. - Original Message - From: Ales Ledvinka aledv...@redhat.com To: Zdenek Styblik zdenek.styb...@gmail.com Cc: ipmitool-devel ipmitool-devel@lists.sourceforge.net Sent:

Re: [Ipmitool-devel] Code Review - ID: 3603419 - 'lib/ipmi_dcmi.c' - waste of resources

2013-03-14 Thread Zdenek Styblik
On Thu, Mar 14, 2013 at 10:15 AM, Ales Ledvinka aledv...@redhat.com wrote: Hello, This seems to be a bit more user friendly. s/when LANplus(IPMI v2.0)/with -I lanplus/ Ales, adding '-l lanplus' won't change anything at that point, because discovery feature hasn't been compiled in. I'm not

Re: [Ipmitool-devel] Code Review - ID: 3603419 - 'lib/ipmi_dcmi.c' - waste of resources

2013-03-14 Thread Ales Ledvinka
Right, overlooked the N if the ifndef completely and focused at the message text. - Original Message - From: Zdenek Styblik zdenek.styb...@gmail.com To: Ales Ledvinka aledv...@redhat.com Cc: ipmitool-devel ipmitool-devel@lists.sourceforge.net Sent: Thursday, March 14, 2013 10:40:46 AM