Brian King writes:
> On 03/28/2016 03:05 PM, Gabriel Krisman Bertazi wrote:
>> Commit 855e7fd ("iprutils: Enable editor choice for new log system")
>> introduced a new error code but the patch missed the symbol declaration,
>> causing the build to fail with an Undefined Reference error, like belo
Some new external drawers like ESLS have an internal clock, used by the
internal microcode. This patch enables iprinit to configure the clock
at boot time, and allow users to fetch and override this configuration
in iprconfig.
Signed-off-by: Gabriel Krisman Bertazi
---
iprconfig.c | 52
Nice patch Gabriel! Some questions/comments below:
On 03/29/2016 11:02 AM, Gabriel Krisman Bertazi wrote:
> Some new external drawers like ESLS have an internal clock, used by the
> internal microcode. This patch enables iprinit to configure the clock
> at boot time, and allow users to fetch and
"Guilherme G. Piccoli" writes:
>> +printf ("%s(%s)\n", ctime(×tamp), origin_str[origin]);
>> +}
>
> Just curious here: the function is declared as int, so shouldn't it
> return an int value in case it succeeds?
>
Thanks for your review!
yes, you are correct. I added a return value for this
On 03/29/2016 12:38 PM, Gabriel Krisman Bertazi wrote:
> Thanks for your review!
>
> yes, you are correct. I added a return value for this function and
> changed the return type for init_ses_dev, as you suggested.
Very nice Gabriel, thank you.
>
>>> +int ipr_ses_get_time(struct ipr_dev *dev, u6
Hi Gabriel,
This doesn't apply cleanly. Can you rebase the patch? Also, a couple of
minor comments below.
Thanks,
Brian
On 03/28/2016 12:15 PM, Gabriel Krisman Bertazi wrote:
> diff --git a/iprconfig.c b/iprconfig.c
> index 3189af0..3262816 100644
> --- a/iprconfig.c
> +++ b/iprconfig.c
> @@ -
Brian King writes:
> I think I'd prefer if we managed to only change the download behavior
> on the new drawer rather than affecting all older SAS enclosures as well,
> since this then impacts 5802, 5803, 5886, 5887, 5888, EDR1, as well as
> embedded
> enclosures in a whole bunch of systems goi
When user passed 0x0 to old firmwares, rebuild rate would be set to the
implementation default value, defined by SIS, and any further read to
Mode Page 0x24 would display 0x0 in the Rebuild Rate field. Newer
firmwares, on the other hand, will correctly set the rebuild rate to the
implementation de
