Re: [Ironruby-core] FYI Code Review: config

2010-03-12 Thread Jim Deville
Watch out for leaking Microsoft-speak ;) Sorry about that. JD From: ironruby-core-boun...@rubyforge.org [mailto:ironruby-core-boun...@rubyforge.org] On Behalf Of Shri Borde Sent: Friday, March 12, 2010 9:58 AM To: ironruby-core@rubyforge.org Subject: Re: [Ironruby-core] FYI Code Review: config

Re: [Ironruby-core] FYI Code Review: config

2010-03-12 Thread Shri Borde
PM To: ironruby-core Subject: Re: [Ironruby-core] FYI Code Review: config +1000 on cleaning up RbConfig. Perhaps a bost-build step that writes out rbconfig.rb? What is MQ? -- Will Green http://hotgazpacho.org/ On Thu, Mar 11, 2010 at 2:53 PM, Jim Deville mailto:jdevi...@microsoft.com>>

Re: [Ironruby-core] FYI Code Review: config

2010-03-11 Thread Will Green
+1000 on cleaning up RbConfig. Perhaps a bost-build step that writes out rbconfig.rb? What is MQ? -- Will Green http://hotgazpacho.org/ On Thu, Mar 11, 2010 at 2:53 PM, Jim Deville wrote: > Looks good. As part of MQ, we should look deeply at the compilation based > variables and see if they c

Re: [Ironruby-core] FYI Code Review: config

2010-03-11 Thread Will Green
I still have misgivings about RUBY_PLATFORM identifying the underlying OS, when in reality, the platform that Ruby is running on is the CLR. Based on this change, I will update my patch for Ruby Gems and resubmit to that team. -- Will Green http://hotgazpacho.org/ On Thu, Mar 11, 2010 at 2:53 P

Re: [Ironruby-core] FYI Code Review: config

2010-03-11 Thread Jim Deville
Looks good. As part of MQ, we should look deeply at the compilation based variables and see if they can be removed or picked up from the arguments to csc. JD -Original Message- From: Shri Borde Sent: Thursday, March 11, 2010 11:36 AM To: IronRuby External Code Reviewers Cc: ironruby-co

[Ironruby-core] FYI Code Review: config

2010-03-11 Thread Shri Borde
tfpt review "/shelveset:config;REDMOND\sborde" Comment : Change RbConfig::CONFIG["arch"] to "universal-dotnet2.0" (or "universal-dotnet4.0" on .NET 4) Also changed RbConfig::CONFIG["host_os"] to be based on RUBY_PLATFORM so that it will be mswin32 on Windows and linux on Linux. Remove