Re: [Ironruby-core] Review: Array\to_s fix for : properly handles recursive array

2009-05-12 Thread Jimmy Schementi
Looks good. From: ironruby-core-boun...@rubyforge.org [mailto:ironruby-core-boun...@rubyforge.org] On Behalf Of Tim Chen (SDO) Sent: Monday, May 11, 2009 6:03 PM To: ironruby-core@rubyforge.org Subject: Re: [Ironruby-core] Review: Array\to_s fix for : properly handles recursive array Forgot to

Re: [Ironruby-core] Review: Array\to_s fix for : properly handles recursive array

2009-05-12 Thread Shri Borde
Looks good! From: ironruby-core-boun...@rubyforge.org [mailto:ironruby-core-boun...@rubyforge.org] On Behalf Of Tim Chen (SDO) Sent: Tuesday, May 12, 2009 12:12 AM To: ironruby-core@rubyforge.org Subject: Re: [Ironruby-core] Review: Array\to_s fix for : properly handles recursive array It is

Re: [Ironruby-core] Review: Array\to_s fix for : properly handles recursive array

2009-05-12 Thread Tim Chen (SDO)
...@gmail.com [jirapong.na...@gmail.com] Sent: Monday, May 11, 2009 7:11 PM To: ironruby-core@rubyforge.org Subject: Re: [Ironruby-core] Review: Array\to_s fix for : properly handles recursive array Hello Tim, I would like to share experience about code convention with you. You should set a braces on

Re: [Ironruby-core] Review: Array\to_s fix for : properly handles recursive array

2009-05-11 Thread jirapong.na...@gmail.com
deleted the tag files that has no more tags in it. Tim From: ironruby-core-boun...@rubyforge.org [mailto:ironruby-core-boun...@rubyforge.org ] On Behalf Of Tim Chen (SDO) Sent: Monday, May 11, 2009 6:02 PM To: ironruby-core@rubyforge.org Subject: [Ironruby-core] Review: Array\to_s fix for

Re: [Ironruby-core] Review: Array\to_s fix for : properly handles recursive array

2009-05-11 Thread Tim Chen (SDO)
: Array\to_s fix for : properly handles recursive array http://github.com/tnachen/ironruby/commit/eeaf82a8d833c763fc617b602cd7415cb228a0f6 Modified IListOps to fix the recursive array problem during to_s call. It used to only print the values in the array, and skip over arrays in the array that

[Ironruby-core] Review: Array\to_s fix for : properly handles recursive array

2009-05-11 Thread Tim Chen (SDO)
http://github.com/tnachen/ironruby/commit/eeaf82a8d833c763fc617b602cd7415cb228a0f6 Modified IListOps to fix the recursive array problem during to_s call. It used to only print the values in the array, and skip over arrays in the array that contains the same values. However, to conform with mri,