Re: [Ironruby-core] Time class instance

2009-05-04 Thread jirapong.na...@gmail.com
04, 2009 12:15 AM To: ironruby-core@rubyforge.org Subject: Re: [Ironruby-core] Time class instance The approach looks good. I have some comments though... You should do a search for “DateTime” in the code base to find all the places that might need updating. For example, Yaml.DateTimeOps n

Re: [Ironruby-core] Time class instance

2009-05-04 Thread jirapong.na...@gmail.com
plies to your changes within 48 hours. From: ironruby-core-boun...@rubyforge.org [mailto:ironruby-core-boun...@rubyforge.org ] On Behalf Of jirapong.na...@gmail.com Sent: Sunday, May 03, 2009 7:12 PM To: ironruby-core@rubyforge.org Subject: Re: [Ironruby-core] Time class instance Hi,

Re: [Ironruby-core] Time class instance

2009-05-04 Thread Shri Borde
examples should be "modifies the receiver" From: ironruby-core-boun...@rubyforge.org [mailto:ironruby-core-boun...@rubyforge.org] On Behalf Of Shri Borde Sent: Monday, May 04, 2009 12:15 AM To: ironruby-core@rubyforge.org Subject: Re: [Ironruby-core] Time class instance The approach

Re: [Ironruby-core] Time class instance

2009-05-04 Thread Shri Borde
avoid it until there are too many code reviews. So do send a reminder if no one replies to your changes within 48 hours. From: ironruby-core-boun...@rubyforge.org [mailto:ironruby-core-boun...@rubyforge.org] On Behalf Of jirapong.na...@gmail.com Sent: Sunday, May 03, 2009 7:12 PM To: ironru

Re: [Ironruby-core] Time class instance

2009-05-03 Thread jirapong.na...@gmail.com
Hi, It would be nice to have anyone to review my code :-). bug file in at http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1021 Thanks, -Jirapong On May 4, 2009, at 8:43 AM, Jimmy Schementi wrote: Doesn’t look like anyone has reviewed this yet. To make sure it doesn’t get lost,

Re: [Ironruby-core] Time class instance

2009-05-03 Thread Jimmy Schementi
Doesn't look like anyone has reviewed this yet. To make sure it doesn't get lost, can you also make a bug on codeplex for this? From: ironruby-core-boun...@rubyforge.org [mailto:ironruby-core-boun...@rubyforge.org] On Behalf Of jirapong.na...@gmail.com Sent: Friday, April 24, 2009 1:56 PM To: i